diff options
author | Loïc Hoguin <[email protected]> | 2020-11-06 11:52:03 +0100 |
---|---|---|
committer | Loïc Hoguin <[email protected]> | 2020-11-06 11:52:03 +0100 |
commit | b28950d5e701055f536f66c70b581c3cf806f3dd (patch) | |
tree | 1d8e53ab3632d8333480cb29ca550454b0207f68 /test/socks_SUITE.erl | |
parent | d5f1a47e9ab758a51b23440eb72a0251527f3f7b (diff) | |
download | gun-b28950d5e701055f536f66c70b581c3cf806f3dd.tar.gz gun-b28950d5e701055f536f66c70b581c3cf806f3dd.tar.bz2 gun-b28950d5e701055f536f66c70b581c3cf806f3dd.zip |
Fix IsFin mismatch in HTTP/2 CONNECT response
The response ends when the tunnel is established, even if the
stream itself does not. The data coming in on the stream after
is not part of the response.
This makes both HTTP/1.1 and HTTP/2 send 'fin' to successful
CONNECT responses.
Diffstat (limited to 'test/socks_SUITE.erl')
-rw-r--r-- | test/socks_SUITE.erl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/socks_SUITE.erl b/test/socks_SUITE.erl index f6686a3..e23124f 100644 --- a/test/socks_SUITE.erl +++ b/test/socks_SUITE.erl @@ -449,7 +449,7 @@ do_socks5_through_h2_connect_proxy(_OriginScheme, OriginTransport, ProxyScheme, <<":method">> := <<"CONNECT">>, <<":authority">> := Authority1 }} = receive_from(Proxy1Pid), - {response, nofin, 200, _} = gun:await(ConnPid, StreamRef), + {response, fin, 200, _} = gun:await(ConnPid, StreamRef), %% First the HTTP/2 tunnel is up, then the SOCKS tunnel to the origin HTTP server. {up, socks} = gun:await(ConnPid, StreamRef), {up, http} = gun:await(ConnPid, StreamRef), |