diff options
| -rw-r--r-- | README.md | 167 | ||||
| -rw-r--r-- | bash_completion/kerl | 26 | ||||
| -rwxr-xr-x | kerl | 219 |
3 files changed, 199 insertions, 213 deletions
@@ -3,7 +3,7 @@ kerl Easy building and installing of [Erlang/OTP](http://www.erlang.org) instances -Kerl aims to be shell agnostic and its only dependencies, excluding what's required to actually build Erlang/OTP, are curl and git. +Kerl aims to be shell agnostic and its only dependencies, excluding what's required to actually build Erlang/OTP, are `curl` and `git`. All is done so that, once a specific release has been built, creating a new installation is as fast as possible. @@ -12,7 +12,7 @@ Downloading You can download the script directly from github: - $ curl -O https://raw.githubusercontent.com/spawngrid/kerl/master/kerl + $ curl -O https://raw.githubusercontent.com/yrashk/kerl/master/kerl Then ensure it is executable @@ -20,9 +20,9 @@ Then ensure it is executable and drop it in your $PATH -Optionally download and install kerl's bash_completion file from https://github.com/spawngrid/kerl/raw/master/bash_completion/kerl +Optionally download and install kerl's bash_completion file from https://github.com/yrashk/kerl/raw/master/bash_completion/kerl -Optionally download and install kerl's zsh-completion file from https://github.com/spawngrid/kerl/raw/master/zsh_completion/_kerl +Optionally download and install kerl's zsh-completion file from https://github.com/yrashk/kerl/raw/master/zsh_completion/_kerl How it works @@ -64,7 +64,7 @@ Note that named builds allow you to have different builds for the same Erlang/OT Building Erlang/OTP R14B02 (r14b02_hipe), please wait... Erlang/OTP R14B02 (r14b02_hipe) has been successfully built -(Note that kerl uses the otp_build script internally, and './otp_build configure' disables HiPE on linux) +(Note that kerl uses the otp_build script internally, and `./otp_build configure` disables HiPE on linux) You can verify your build has been registered: @@ -90,14 +90,15 @@ And at last activate it: $ . /path/to/install/dir/activate -Activation will backup your $PATH, prepend it with the installation's bin/ directory. Thus it's only valid for the current shell session, and until you activate another installation or call kerl_deactivate. +Activation will backup your $PATH, prepend it with the installation's bin/ directory. Thus it's only valid for the current shell session, and until you activate another installation or call `kerl_deactivate`. You're now ready to work with your r14b02 installation: $ erl -version Erlang (SMP,ASYNC_THREADS,HIPE) (BEAM) emulator version 5.8.3 -When you're done just type: +When you're done just call the shell function: + $ kerl_deactivate Anytime you can check which installation, if any, is currently active with: @@ -123,21 +124,19 @@ You can delete builds and installations with the following commands: $ kerl delete build r14b02 The r14b02 build has been deleted - $ kerl delete installation /path/to/install/dir The installation in /path/to/install/dir has been deleted -You can easily deploy an installation to another host having ssh and rsync access with the following command: +You can easily deploy an installation to another host having `ssh` and `rsync` access with the following command: $ kerl deploy anotherhost /path/to/install/dir - Cloning Erlang/OTP r14b02 (/path/to/install/dir) to anotherhost (/path/to/install/dir) ... On anotherhost, you can activate this installation running the following command: . /path/to/install/dir/activate Later on, you can leave the installation typing: kerl_deactivate -As an experimental feature, you can build Erlang directly from a git repository with a command of the form "kerl build git <git_url> <git_version> <build_name>" where <git_version> can be either a branch, a tag or a commit id as it will be passed to "git checkout": +As an experimental feature, you can build Erlang directly from a git repository with a command of the form `kerl build git <git_url> <git_version> <build_name>` where <git_version> can be either a branch, a tag or a commit id as it will be passed to `git checkout`: $ kerl build git https://github.com/erlang/otp.git dev r14b02_dev Checking Erlang/OTP git repositoy from https://github.com/erlang/otp.git... @@ -151,24 +150,24 @@ You can tune kerl using the .kerlrc file in your $HOME directory. You can set the following variables: -- KERL_DOWNLOAD_DIR where to put downloaded files, defaults to $HOME/.kerl/archives -- KERL_BUILD_DIR where to hold the builds, defaults to $HOME/.kerl/builds -- KERL_DEFAULT_INSTALL_DIR if set in ~/.kerlrc, install builds to this dir if no path is provided on installs, (recommend "$KERL_BASE_DIR/installs") -- KERL_CONFIGURE_OPTIONS options to pass to Erlang's ./configure script, e.g. --without-termcap -- KERL_CONFIGURE_APPLICATIONS if non-empty, subset of applications used in the builds (and subsequent installations) process, e.g. "kernel stdlib sasl" -- KERL_CONFIGURE_DISABLE_APPLICATIONS if non-empty, subset of applications disabled in the builds (and subsequent installations) process, e.g. "odbc" -- KERL_SASL_STARTUP use SASL system startup instead of minimal -- KERL_USE_AUTOCONF use autoconf in the builds process -- KERL_INSTALL_MANPAGES if non-empty will install manpages -- KERL_INSTALL_HTMLDOCS if non-empty will install HTML docs -- KERL_DEPLOY_SSH_OPTIONS if additional options are required, e.g. "-qx -o PasswordAuthentication=no" -- KERL_DEPLOY_RSYNC_OPTIONS if additional options are required, e.g. "--delete" -- KERL_ENABLE_PROMPT if set, the prompt will be prefixed with the name of the active build +- `KERL_DOWNLOAD_DIR` where to put downloaded files, defaults to $HOME/.kerl/archives +- `KERL_BUILD_DIR` where to hold the builds, defaults to $HOME/.kerl/builds +- `KERL_DEFAULT_INSTALL_DIR` if set in ~/.kerlrc, install builds to this dir if no path is provided on installs, (recommend `$KERL_BASE_DIR/installs`) +- `KERL_CONFIGURE_OPTIONS` options to pass to Erlang's `./configure` script, e.g. `--without-termcap` +- `KERL_CONFIGURE_APPLICATIONS` if non-empty, subset of applications used in the builds (and subsequent installations) process, e.g. `kernel stdlib sasl` +- `KERL_CONFIGURE_DISABLE_APPLICATIONS` if non-empty, subset of applications disabled in the builds (and subsequent installations) process, e.g. `odbc` +- `KERL_SASL_STARTUP` use SASL system startup instead of minimal +- `KERL_USE_AUTOCONF` use autoconf in the builds process +- `KERL_INSTALL_MANPAGES` if non-empty will install manpages +- `KERL_INSTALL_HTMLDOCS` if non-empty will install HTML docs +- `KERL_DEPLOY_SSH_OPTIONS` if additional options are required, e.g. `-qx -o PasswordAuthentication=no` +- `KERL_DEPLOY_RSYNC_OPTIONS` if additional options are required, e.g. `--delete` +- `KERL_ENABLE_PROMPT` if set, the prompt will be prefixed with the name of the active build Note on .kerlrc =============== -Since .kerlrc is a dot file for /bin/sh, running shell commands inside the .kerlrc will affect the shell and environment variables for the commands being executed later. For example, the shell `export` commands in .kerlrc will affect *your login shell environment* when activating curl. Use with care. +Since .kerlrc is a dot file for `/bin/sh`, running shell commands inside the .kerlrc will affect the shell and environment variables for the commands being executed later. For example, the shell `export` commands in .kerlrc will affect *your login shell environment* when activating `curl`. Use with care. Glossary ======== @@ -187,47 +186,43 @@ Commands reference build ----- -Create a named build either from an official Erlang/OTP release or from a git repository - -### Syntax - kerl build <release_code> <build_name> kerl build git <git_url> <git_version> <build_name> -### Examples +Creates a named build either from an official Erlang/OTP release or from a git repository. $ kerl build R14B02 r14b02 $ kerl build git https://github.com/erlang/otp dev r14b02_dev -### Tuning +#### Tuning -#### Configure options +##### Configure options -You can specify the configure options to use when building Erlang/OTP with the KERL_CONFIGURE_OPTIONS variable, either in your $HOME/.kerlrc file or prepending it to the command line. +You can specify the configure options to use when building Erlang/OTP with the `KERL_CONFIGURE_OPTIONS` variable, either in your $HOME/.kerlrc file or prepending it to the command line. $ KERL_CONFIGURE_OPTIONS=--enable-hipe kerl build R14B02 r14b02_hipe -#### Configure applications +##### Configure applications -If non-empty, you can specify the subset of applications to use when building (and subsequent installing) Erlang/OTP with the KERL_CONFIGURE_APPLICATIONS variable, either in your $HOME/.kerlrc file or prepending it to the command line. +If non-empty, you can specify the subset of applications to use when building (and subsequent installing) Erlang/OTP with the `KERL_CONFIGURE_APPLICATIONS` variable, either in your $HOME/.kerlrc file or prepending it to the command line. $ KERL_CONFIGURE_APPLICATIONS="kernel stdlib sasl" kerl build R15B01 r15b01_minimal -#### Configure disable applications +##### Configure disable applications -If non-empty, you can specify the subset of applications to disable when building (and subsequent installing) Erlang/OTP with the KERL_CONFIGURE_DISABLE_APPLICATIONS variable, either in your $HOME/.kerlrc file or prepending it to the command line. +If non-empty, you can specify the subset of applications to disable when building (and subsequent installing) Erlang/OTP with the `KERL_CONFIGURE_DISABLE_APPLICATIONS` variable, either in your $HOME/.kerlrc file or prepending it to the command line. $ KERL_CONFIGURE_DISABLE_APPLICATIONS="odbc" kerl build R16B02 r16b02_no_odbc -#### Enable autoconf +##### Enable autoconf -You can enable the use of autoconf in the build process setting KERL_USE_AUTOCONF=yes in your $HOME/.kerlrc file +You can enable the use of `autoconf` in the build process setting `KERL_USE_AUTOCONF=yes` in your $HOME/.kerlrc file -*Note*: autoconf is always enabled for git builds +*Note*: `autoconf` is always enabled for git builds -#### Using shell export command in .kerlrc +##### Using shell export command in .kerlrc -Configure variables which includes spaces such as those in CFLAGS cannot be passed on with KERL_CONFIGURE_OPTIONS. In such a case you can use shell `export` command to define the environment variables for Configure. Note well: this method has a side effect to change your shell execution environment after activating a kerl installation of Erlang/OTP. Here is an example of .kerlrc for building Erlang/OTP for FreeBSD with clang compiler: +Configure variables which includes spaces such as those in `CFLAGS` cannot be passed on with `KERL_CONFIGURE_OPTIONS`. In such a case you can use shell `export` command to define the environment variables for `./configure`. Note well: this method has a side effect to change your shell execution environment after activating a kerl installation of Erlang/OTP. Here is an example of .kerlrc for building Erlang/OTP for FreeBSD with clang compiler: # for clang export CC=clang CXX=clang CFLAGS="-g -O3 -fstack-protector" LDFLAGS="-fstack-protector" @@ -237,108 +232,97 @@ Configure variables which includes spaces such as those in CFLAGS cannot be pass install ------- -Install a named build to the specified filesystem location - -### Syntax - kerl install <build_name> [path] -If path is omitted the current working directory will be used. However, if KERL_DEFAULT_INSTALL_DIR is defined in ~/.kerlrc, KERL_DEFAULT_INSTALL_DIR/<build-name> will be used instead. +Installs a named build to the specified filesystem location. -*Note*: kerl assumes the specified directory is for its sole use. If you later delete it with the kerl delete command, the whole directory will be deleted, along with anything you may have added to it! + $ kerl install r14b02 /srv/otp/r14b02 -### Example +If path is omitted the current working directory will be used. However, if `KERL_DEFAULT_INSTALL_DIR` is defined in ~/.kerlrc, `KERL_DEFAULT_INSTALL_DIR/<build-name>` will be used instead. - $ kerl install r14b02 /srv/otp/r14b02 +*Note*: kerl assumes the specified directory is for its sole use. If you later delete it with the kerl delete command, the whole directory will be deleted, along with anything you may have added to it! -### Tuning +#### Tuning -#### SASL startup +##### SASL startup -You can have SASL started automatically setting KERL_SASL_STARTUP=yes in your $HOME/.kerlrc file or prepending it to the command line +You can have SASL started automatically setting `KERL_SASL_STARTUP=yes` in your $HOME/.kerlrc file or prepending it to the command line. -#### Manpages installation +##### Manpages installation -You can have manpages installed automatically setting KERL_INSTALL_MANPAGES=yes in your $HOME/.kerlrc file or prepending it to the command line +You can have manpages installed automatically setting `KERL_INSTALL_MANPAGES=yes` in your $HOME/.kerlrc file or prepending it to the command line. *Note*: for git-based builds, kerl downloads and installs the newest official manpages which may or may not correspond to the contents of your local build. -#### HTML docs installation +##### HTML docs installation -You can have HTML docs installed automatically setting KERL_INSTALL_HTMLDOCS=yes in your $HOME/.kerlrc file or prepending it to the command line +You can have HTML docs installed automatically setting `KERL_INSTALL_HTMLDOCS=yes` in your $HOME/.kerlrc file or prepending it to the command line. *Note*: for git-based builds, kerl downloads and installs the newest official HTML docs which may or may not correspond to the contents of your local build. deploy ------ -Deploy the specified installation to the given host and location + kerl deploy <[user@]host> [directory] [remote_directory] -### Syntax +Deploys the specified installation to the given host and location. - kerl deploy <[user@]host> [directory] [remote_directory] + $ kerl deploy anotherhost /path/to/install/dir If remote_directory is omitted the specified directory will be used. If directory and remote_directory is omitted the current working directory will be used. -*NOTE*: kerl assumes the specified host is accessible via ssh and rsync. +*NOTE*: kerl assumes the specified host is accessible via `ssh` and `rsync`. -### Example +#### Tuning - $ kerl deploy anotherhost /path/to/install/dir +##### Additional SSH options -### Tuning +You can have additional options given to `ssh` by setting them in the `KERL_DEPLOY_SSH_OPTIONS` variable in your $HOME/.kerlrc file or on the command line, e.g. `KERL_DEPLOY_SSH_OPTIONS='-qx -o PasswordAuthentication=no'`. -#### Additional SSH options +##### Additional RSYNC options -You can have additional options given to SSH by setting them in the KERL_DEPLOY_SSH_OPTIONS variable in your $HOME/.kerlrc file or on the command line, e.g. KERL_DEPLOY_SSH_OPTIONS="-qx -o PasswordAuthentication=no" - -#### Additional RSYNC options - -You can have additional options given to RSYNC by setting them in the KERL_DEPLOY_RSYNC_OPTIONS variable in your $HOME/.kerlrc file or on the command line, e.g. KERL_DEPLOY_RSYNC_OPTIONS="--delete" +You can have additional options given to `rsync` by setting them in the `KERL_DEPLOY_RSYNC_OPTIONS` variable in your $HOME/.kerlrc file or on the command line, e.g. `KERL_DEPLOY_RSYNC_OPTIONS='--delete'`. update ------ -Update the list of releases - -### Syntax - kerl update releases +Fetches the up-to-date list of OTP releases from erlang.org. + list ---- -List the releases, builds or installations available - -### Syntax - kerl list <releases|builds|installations> +Lists the releases, builds or installations available. + delete ------ -Delete the specified build or installation - -### Syntax - kerl delete build <build_name> kerl delete installation <path> -### Examples +Deletes the specified build or installation. - $ kerl delete build r14b02 - The r14b02 build has been deleted - $ kerl delete installation /srv/otp/r14b02 - The installation in /srv/otp/r14b02 has been deleted +``` +$ kerl delete build r14b02 +The r14b02 build has been deleted +``` + +``` +$ kerl delete installation /srv/otp/r14b02 +The installation in /srv/otp/r14b02 has been deleted +``` active ------ -Print the path of the currently active installation, if any + kerl active -### Example +Prints the path of the currently active installation, if any. $ kerl active The current active installation is: @@ -347,9 +331,9 @@ Print the path of the currently active installation, if any status ------ -Print the available builds and installations as well as the currently active installation + kerl status -### Example +Prints the available builds and installations as well as the currently active installation. $ kerl status Available builds: @@ -361,4 +345,3 @@ Print the available builds and installations as well as the currently active ins r14b02 /srv/otp/r14b02_dev ---------- No Erlang/OTP kerl installation is currently active - diff --git a/bash_completion/kerl b/bash_completion/kerl index 559d844..76c4ad2 100644 --- a/bash_completion/kerl +++ b/bash_completion/kerl @@ -1,3 +1,4 @@ +#!/bin/bash # bash_completion for kerl _kerl() @@ -14,33 +15,33 @@ _kerl() ;; build) if [ "$COMP_CWORD" -eq 2 ]; then - if [ -f "$HOME/.kerl/otp_releases" ]; then - RELEASES=`cat "$HOME/.kerl/otp_releases"` + if [ -f "$HOME"/.kerl/otp_releases ]; then + RELEASES=$(cat "$HOME"/.kerl/otp_releases) fi COMPREPLY=( $( compgen -W "git $RELEASES" -- "$cur") ) else - if [ -f "$HOME/.kerl/otp_builds" ]; then - BUILDS=`cat "$HOME/.kerl/otp_builds" | cut -d "," -f 2` + if [ -f "$HOME"/.kerl/otp_builds ]; then + BUILDS=$(cut -d ',' -f 2 "$HOME"/.kerl/otp_builds) fi COMPREPLY=( $( compgen -W "$BUILDS" -- "$cur") ) fi ;; installation) - if [ -f "$HOME/.kerl/otp_installations" ]; then - PATHS=`cat "$HOME/.kerl/otp_installations" | cut -d " " -f 2` + if [ -f "$HOME"/.kerl/otp_installations ]; then + PATHS=$(cut -d ' ' -f 2 "$HOME"/.kerl/otp_installations) fi COMPREPLY=( $( compgen -W "$PATHS" -- "$cur") ) ;; install) - if [ -f "$HOME/.kerl/otp_builds" ]; then - BUILDS=`cat "$HOME/.kerl/otp_builds" | cut -d "," -f 2` + if [ -f "$HOME"/.kerl/otp_builds ]; then + BUILDS=$(cut -d ',' -f 2 "$HOME"/.kerl/otp_builds) fi COMPREPLY=( $( compgen -W "$BUILDS" -- "$cur") ) ;; deploy) if [ "$COMP_CWORD" -eq 3 ]; then - if [ -f "$HOME/.kerl/otp_installations" ]; then - PATHS=`cat "$HOME/.kerl/otp_installations" | cut -d " " -f 2` + if [ -f "$HOME"/.kerl/otp_installations ]; then + PATHS=$(cut -d ' ' -f 2 "$HOME"/.kerl/otp_installations) fi fi COMPREPLY=( $( compgen -W "$PATHS" -- "$cur") ) @@ -53,8 +54,8 @@ _kerl() ;; *) if [ "$COMP_CWORD" -eq 3 ]; then - if [ -f "$HOME/.kerl/otp_builds" ]; then - BUILDS=`cat "$HOME/.kerl/otp_builds" | cut -d "," -f 2` + if [ -f "$HOME"/.kerl/otp_builds ]; then + BUILDS=$(cut -d ',' -f 2 "$HOME"/.kerl/otp_builds) fi if [ -n "$BUILDS" ]; then for b in $BUILDS; do @@ -69,4 +70,3 @@ _kerl() esac } complete -F _kerl kerl - @@ -21,13 +21,16 @@ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN # THE SOFTWARE. +#Grep fix for mac pcre errors +GREP_OPTIONS='' + ERLANG_DOWNLOAD_URL=http://www.erlang.org/download -KERL_BASE_DIR="$HOME/.kerl" -KERL_CONFIG="$HOME/.kerlrc" -KERL_DOWNLOAD_DIR="$KERL_BASE_DIR/archives" -KERL_BUILD_DIR="$KERL_BASE_DIR/builds" -KERL_GIT_DIR="$KERL_BASE_DIR/gits" +KERL_BASE_DIR="$HOME"/.kerl +KERL_CONFIG="$HOME"/.kerlrc +KERL_DOWNLOAD_DIR="${KERL_BASE_DIR:?}"/archives +KERL_BUILD_DIR="${KERL_BASE_DIR:?}"/builds +KERL_GIT_DIR="${KERL_BASE_DIR:?}"/gits if [ -n "$KERL_CONFIGURE_OPTIONS" ]; then _KCO="$KERL_CONFIGURE_OPTIONS" fi @@ -60,10 +63,10 @@ KERL_INSTALL_MANPAGES= KERL_BUILD_PLT= # ensure the base dir exsists -mkdir -p "$KERL_BASE_DIR" +mkdir -p "$KERL_BASE_DIR" || exit 1 # source the config file if available -if [ -f "$KERL_CONFIG" ]; then . "$KERL_CONFIG"; fi +if [ -f "$KERL_CONFIG" ]; then source "$KERL_CONFIG"; fi if [ -n "$_KCO" ]; then KERL_CONFIGURE_OPTIONS="$_KCO" @@ -96,7 +99,7 @@ else INSTALL_OPT=-sasl fi -KERL_SYSTEM=`uname -s` +KERL_SYSTEM=$(uname -s) case "$KERL_SYSTEM" in Darwin|FreeBSD|OpenBSD) MD5SUM="openssl md5" @@ -114,7 +117,7 @@ usage() { echo "kerl: build and install Erlang/OTP" echo "usage: $0 <command> [options ...]" - echo "\n <command> Command to be executed\n" + printf "\n <command> Command to be executed\n\n" echo "Valid commands are:" echo " build Build specified release or git repository" echo " install Install the specified release at the given location" @@ -135,7 +138,7 @@ if [ $# -eq 0 ]; then usage; fi get_releases() { curl -L -s $ERLANG_DOWNLOAD_URL/ | \ - sed $SED_OPT -e 's/^.*<[aA] [hH][rR][eE][fF]=\"\/download\/otp_src_([-0-9A-Za-z_.]+)\.tar\.gz\">.*$/\1/' \ + sed $SED_OPT -e 's/^.*<[aA] [hH][rR][eE][fF]=\"\otp_src_([-0-9A-Za-z_.]+)\.tar\.gz\">.*$/\1/' \ -e '/^R1|^[0-9]/!d' | \ sed -e "s/^R\(.*\)/\1:R\1/" | sed -e "s/^\([^\:]*\)$/\1-z:\1/" | sort | cut -d':' -f2 } @@ -143,21 +146,21 @@ get_releases() update_checksum_file() { echo "Getting the checksum file from erlang.org..." - curl -L $ERLANG_DOWNLOAD_URL/MD5 > "$KERL_DOWNLOAD_DIR/MD5" || exit 1 + curl -L $ERLANG_DOWNLOAD_URL/MD5 > "$KERL_DOWNLOAD_DIR"/MD5 || exit 1 } ensure_checksum_file() { - if [ ! -f "$KERL_DOWNLOAD_DIR/MD5" ]; then + if [ ! -f "$KERL_DOWNLOAD_DIR"/MD5 ]; then update_checksum_file fi } check_releases() { - if [ ! -f "$KERL_BASE_DIR/otp_releases" ]; then + if [ ! -f "$KERL_BASE_DIR"/otp_releases ]; then echo "Getting the available releases from erlang.org..." - get_releases > "$KERL_BASE_DIR/otp_releases" + get_releases > "$KERL_BASE_DIR"/otp_releases fi } @@ -177,17 +180,17 @@ lion_support() { is_valid_release() { check_releases - for rel in `cat $KERL_BASE_DIR/otp_releases`; do + while read -r rel; do if [ "$1" = "$rel" ]; then return 0 fi - done + done < "$KERL_BASE_DIR"/otp_releases return 1 } assert_valid_release() { - if ! is_valid_release $1; then + if ! is_valid_release "$1"; then echo "$1 is not a valid Erlang/OTP release" exit 1 fi @@ -196,15 +199,15 @@ assert_valid_release() get_release_from_name() { - if [ -f "$KERL_BASE_DIR/otp_builds" ]; then - for l in `cat "$KERL_BASE_DIR/otp_builds"`; do - rel=`echo $l | cut -d "," -f 1` - name=`echo $l | cut -d "," -f 2` + if [ -f "$KERL_BASE_DIR"/otp_builds ]; then + while read -r l; do + rel=$(echo "$l" | cut -d "," -f 1) + name=$(echo "$l" | cut -d "," -f 2) if [ "$name" = "$1" ]; then echo "$rel" return 0 fi - done + done < "$KERL_BASE_DIR"/otp_builds fi return 1 } @@ -212,18 +215,18 @@ get_release_from_name() get_newest_valid_release() { check_releases - for rel in `cat $KERL_BASE_DIR/otp_releases | tail -1`; do + while read -r rel; do if [ ! -z "$rel" ]; then echo "$rel" return 0 fi - done + done < "$KERL_BASE_DIR"/otp_releases | tail -1 return 1 } is_valid_installation() { - if [ -f "$1/activate" ]; then + if [ -f "$1"/activate ]; then return 0 fi return 1 @@ -231,7 +234,7 @@ is_valid_installation() assert_valid_installation() { - if ! is_valid_installation $1; then + if ! is_valid_installation "$1"; then echo "$1 is not a kerl-managed Erlang/OTP installation" exit 1 fi @@ -240,24 +243,24 @@ assert_valid_installation() assert_build_name_unused() { - if [ -f "$KERL_BASE_DIR/otp_builds" ]; then - for l in `cat "$KERL_BASE_DIR/otp_builds"`; do - name=`echo $l | cut -d "," -f 2` + if [ -f "$KERL_BASE_DIR"/otp_builds ]; then + while read -r l; do + name=$(echo "$l" | cut -d "," -f 2) if [ "$name" = "$1" ]; then echo "There's already a build named $1" exit 1 fi - done + done < "$KERL_BASE_DIR"/otp_builds fi } do_git_build() { - assert_build_name_unused $3 + assert_build_name_unused "$3" - GIT=`echo -n "$1" | $MD5SUM | cut -d " " -f $MD5SUM_FIELD` + GIT=$(echo -n "$1" | $MD5SUM | cut -d ' ' -f $MD5SUM_FIELD) mkdir -p "$KERL_GIT_DIR" - cd "$KERL_GIT_DIR" + cd "$KERL_GIT_DIR" || exit 1 echo "Checking Erlang/OTP git repository from $1..." if [ ! -d "$GIT" ]; then git clone -q --mirror "$1" "$GIT" > /dev/null 2>&1 @@ -266,37 +269,37 @@ do_git_build() exit 1 fi fi - cd "$GIT" + cd "$GIT" || exit 1 git remote update --prune > /dev/null 2>&1 if [ $? -ne 0 ]; then echo "Error updating remote git repository" exit 1 fi - rm -Rf "$KERL_BUILD_DIR/$3" + rm -Rf "${KERL_BUILD_DIR:?}/$3" mkdir -p "$KERL_BUILD_DIR/$3" - cd "$KERL_BUILD_DIR/$3" + cd "$KERL_BUILD_DIR/$3" || exit 1 git clone -l "$KERL_GIT_DIR/$GIT" otp_src_git > /dev/null 2>&1 if [ $? -ne 0 ]; then echo "Error cloning local git repository" exit 1 fi - cd otp_src_git - git checkout $2 > /dev/null 2>&1 + cd otp_src_git || exit 1 + git checkout "$2" > /dev/null 2>&1 if [ $? -ne 0 ]; then - git checkout -b $2 $2 > /dev/null 2>&1 + git checkout -b "$2" "$2" > /dev/null 2>&1 fi if [ $? -ne 0 ]; then echo "Couldn't checkout specified version" - rm -Rf "$KERL_BUILD_DIR/$3" + rm -Rf "${KERL_BUILD_DIR:?}/$3" exit 1 fi if [ ! -x otp_build ]; then echo "Not a valid Erlang/OTP repository" - rm -Rf "$KERL_BUILD_DIR/$3" + rm -Rf "${KERL_BUILD_DIR:?}/$3" exit 1 fi - LOGFILE="$KERL_BUILD_DIR/$3/otp_build.log" + LOGFILE="$KERL_BUILD_DIR/$3"/otp_build.log echo "Building Erlang/OTP $3 from git, please wait..." ./otp_build autoconf $KERL_CONFIGURE_OPTIONS > "$LOGFILE" 2>&1 && \ ./otp_build configure $KERL_CONFIGURE_OPTIONS > "$LOGFILE" 2>&1 @@ -307,7 +310,7 @@ do_git_build() if [ -n "$KERL_CONFIGURE_APPLICATIONS" ]; then find ./lib -maxdepth 1 -type d -exec touch -f {}/SKIP \; for i in $KERL_CONFIGURE_APPLICATIONS; do - rm ./lib/$i/SKIP + rm ./lib/"$i"/SKIP if [ $? -ne 0 ]; then echo "Couldn't prepare '$i' application for building" exit 1 @@ -316,7 +319,7 @@ do_git_build() fi if [ -n "$KERL_CONFIGURE_DISABLE_APPLICATIONS" ]; then for i in $KERL_CONFIGURE_DISABLE_APPLICATIONS; do - touch -f ./lib/$i/SKIP + touch -f ./lib/"$i"/SKIP if [ $? -ne 0 ]; then echo "Couldn't disable '$i' application for building" exit 1 @@ -329,9 +332,9 @@ do_git_build() exit 1 fi rm -f "$LOGFILE" - ./otp_build release -a "$KERL_BUILD_DIR/$3/release_git" > /dev/null 2>&1 - cd "$KERL_BUILD_DIR/$3/release_git" - ./Install $INSTALL_OPT "$KERL_BUILD_DIR/$3/release_git" > /dev/null 2>&1 + ./otp_build release -a "$KERL_BUILD_DIR/$3"/release_git > /dev/null 2>&1 + cd "$KERL_BUILD_DIR/$3"/release_git || exit 1 + ./Install $INSTALL_OPT "$KERL_BUILD_DIR/$3"/release_git > /dev/null 2>&1 echo "Erlang/OTP $3 from git has been successfully built" list_add builds "git,$3" } @@ -340,11 +343,11 @@ do_build() { case "$KERL_SYSTEM" in Darwin) - if [ `gcc --version 2>/dev/null | grep -i llvm | wc -l` = "1" ]; then - if lion_support $1; then + if [ "$(gcc --version 2>/dev/null | grep -i -c llvm)" = "1" ]; then + if lion_support "$1"; then KERL_CONFIGURE_OPTIONS="CFLAGS=-O0 $KERL_CONFIGURE_OPTIONS" else - if [ -x "`which gcc-4.2`" ]; then + if [ -x "$(which gcc-4.2)" ]; then KERL_CONFIGURE_OPTIONS="CC=gcc-4.2 $KERL_CONFIGURE_OPTIONS" else KERL_CONFIGURE_OPTIONS="CC=llvm-gcc-4.2 CFLAGS=-O0 $KERL_CONFIGURE_OPTIONS" @@ -356,8 +359,8 @@ do_build() ;; esac - assert_valid_release $1 - assert_build_name_unused $2 + assert_valid_release "$1" + assert_build_name_unused "$2" FILENAME=otp_src_$1.tar.gz download "$FILENAME" @@ -367,12 +370,12 @@ do_build() UNTARDIRNAME="$KERL_BUILD_DIR/$2/otp_src_$1-kerluntar-$$" rm -rf "$UNTARDIRNAME" mkdir -p "$UNTARDIRNAME" - (cd "$UNTARDIRNAME" && tar xfz "$KERL_DOWNLOAD_DIR/$FILENAME" && mv * "$KERL_BUILD_DIR/$2/otp_src_$1") + (cd "$UNTARDIRNAME" && tar xfz "$KERL_DOWNLOAD_DIR/$FILENAME" && mv ./* "$KERL_BUILD_DIR/$2/otp_src_$1") rm -rf "$UNTARDIRNAME" fi echo "Building Erlang/OTP $1 ($2), please wait..." ERL_TOP="$KERL_BUILD_DIR/$2/otp_src_$1" - cd "$ERL_TOP" + cd "$ERL_TOP" || exit 1 LOGFILE="$KERL_BUILD_DIR/$2/otp_build_$1.log" if [ -n "$KERL_USE_AUTOCONF" ]; then ./otp_build autoconf $KERL_CONFIGURE_OPTIONS > "$LOGFILE" 2>&1 && \ @@ -389,7 +392,7 @@ do_build() if [ -n "$KERL_CONFIGURE_APPLICATIONS" ]; then find ./lib -maxdepth 1 -type d -exec touch -f {}/SKIP \; for i in $KERL_CONFIGURE_APPLICATIONS; do - rm ./lib/$i/SKIP + rm ./lib/"$i"/SKIP if [ $? -ne 0 ]; then echo "Couldn't prepare '$i' application for building" list_remove builds "$1 $2" @@ -399,7 +402,7 @@ do_build() fi if [ -n "$KERL_CONFIGURE_DISABLE_APPLICATIONS" ]; then for i in $KERL_CONFIGURE_DISABLE_APPLICATIONS; do - touch -f ./lib/$i/SKIP + touch -f ./lib/"$i"/SKIP if [ $? -ne 0 ]; then echo "Couldn't disable '$i' application for building" exit 1 @@ -414,7 +417,7 @@ do_build() fi rm -f "$LOGFILE" ERL_TOP="$ERL_TOP" ./otp_build release -a "$KERL_BUILD_DIR/$2/release_$1" > /dev/null 2>&1 - cd "$KERL_BUILD_DIR/$2/release_$1" + cd "$KERL_BUILD_DIR/$2/release_$1" || exit 1 ./Install $INSTALL_OPT "$KERL_BUILD_DIR/$2/release_$1" > /dev/null 2>&1 echo "Erlang/OTP $1 ($2) has been successfully built" list_add builds "$1,$2" @@ -422,7 +425,7 @@ do_build() do_install() { - rel=`get_release_from_name $1` + rel=$(get_release_from_name "$1") if [ $? -ne 0 ]; then echo "No build named $1" exit 1 @@ -432,10 +435,10 @@ do_install() echo "Destination is not a directory" exit 1 fi - absdir=`cd "$2" && pwd` + absdir=$(cd "$2" && pwd) echo "Installing Erlang/OTP $rel ($1) in $absdir..." ERL_TOP="$KERL_BUILD_DIR/$1/otp_src_$rel" - cd "$ERL_TOP" + cd "$ERL_TOP" || exit 1 ERL_TOP="$ERL_TOP" ./otp_build release -a "$absdir" > /dev/null 2>&1 && cd "$absdir" && ./Install $INSTALL_OPT "$absdir" > /dev/null 2>&1 if [ $? -ne 0 ]; then @@ -443,7 +446,7 @@ do_install() exit 1 fi list_add installations "$1 $absdir"; - cat <<ACTIVATE > "$absdir/activate" + cat <<ACTIVATE > "$absdir"/activate # credits to virtualenv kerl_deactivate() { @@ -513,7 +516,7 @@ ACTIVATE do_install_htmldocs "$rel" fi else - rel=`get_newest_valid_release` + rel=$(get_newest_valid_release) if [ $? -ne 0 ]; then echo "No newest valid release" exit 1 @@ -602,18 +605,18 @@ do_deploy() echo "No host given" exit 1 fi - host=$1 + host="$1" assert_valid_installation "$2" - rel=`get_name_from_install_path "$2"` - path=$2 - remotepath=$path + rel="$(get_name_from_install_path "$2")" + path="$2" + remotepath="$path" if [ ! -z "$3" ]; then - remotepath=$3 + remotepath="$3" fi - ssh $KERL_DEPLOY_SSH_OPTIONS $host true > /dev/null 2>&1 + ssh $KERL_DEPLOY_SSH_OPTIONS "$host" true > /dev/null 2>&1 if [ $? -ne 0 ]; then echo "Couldn't ssh to $host" exit 1 @@ -627,13 +630,13 @@ do_deploy() exit 1 fi - ssh $KERL_DEPLOY_SSH_OPTIONS $host "cd \"$remotepath\" && env ERL_TOP=\`pwd\` ./Install $INSTALL_OPT \`pwd\` > /dev/null 2>&1" + ssh $KERL_DEPLOY_SSH_OPTIONS "$host" "cd \"$remotepath\" && env ERL_TOP=\"\`pwd\`\" ./Install $INSTALL_OPT \"\`pwd\`\" > /dev/null 2>&1" if [ $? -ne 0 ]; then echo "Couldn't install Erlang/OTP $rel to $host ($remotepath)" exit 1 fi - ssh $KERL_DEPLOY_SSH_OPTIONS $host "cd \"$remotepath\" && sed -i -e \"s#$path#\`pwd\`#g\" activate" + ssh $KERL_DEPLOY_SSH_OPTIONS "$host" "cd \"$remotepath\" && sed -i -e \"s#$path#\"\`pwd\`\"#g\" activate" if [ $? -ne 0 ]; then echo "Couldn't completely install Erlang/OTP $rel to $host ($remotepath)" exit 1 @@ -647,8 +650,8 @@ do_deploy() list_print() { - if [ -f $KERL_BASE_DIR/otp_$1 ]; then - if [ "`cat "$KERL_BASE_DIR/otp_$1" | wc -l`" != "0" ]; then + if [ -f "$KERL_BASE_DIR/otp_$1" ]; then + if [ "$(wc -l "$KERL_BASE_DIR/otp_$1")" != "0" ]; then if [ -z "$2" ]; then cat "$KERL_BASE_DIR/otp_$1" else @@ -663,11 +666,11 @@ list_print() list_add() { if [ -f "$KERL_BASE_DIR/otp_$1" ]; then - for l in `cat "$KERL_BASE_DIR/otp_$1"`; do + while read -r l; do if [ "$l" = "$2" ]; then return 1 fi - done + done < "$KERL_BASE_DIR/otp_$1" echo "$2" >> "$KERL_BASE_DIR/otp_$1" else echo "$2" > "$KERL_BASE_DIR/otp_$1" @@ -684,7 +687,7 @@ list_remove() list_has() { if [ -f "$KERL_BASE_DIR/otp_$1" ]; then - grep $2 "$KERL_BASE_DIR/otp_$1" > /dev/null 2>&1 && return 0 + grep "$2" "$KERL_BASE_DIR/otp_$1" > /dev/null 2>&1 && return 0 fi return 1 } @@ -712,25 +715,25 @@ update_usage() get_active_path() { if [ -n "$_KERL_ACTIVE_DIR" ]; then - echo $_KERL_ACTIVE_DIR + echo "$_KERL_ACTIVE_DIR" fi return 0 } get_name_from_install_path() { - if [ -f "$KERL_BASE_DIR/otp_installations" ]; then - grep -F "$1" "$KERL_BASE_DIR/otp_installations" | cut -d ' ' -f 1 + if [ -f "$KERL_BASE_DIR"/otp_installations ]; then + grep -F "$1" "$KERL_BASE_DIR"/otp_installations | cut -d ' ' -f 1 fi return 0 } do_active() { - ACTIVE_PATH=`get_active_path` + ACTIVE_PATH="$(get_active_path)" if [ -n "$ACTIVE_PATH" ]; then echo "The current active installation is:" - echo $ACTIVE_PATH + echo "$ACTIVE_PATH" return 0 else echo "No Erlang/OTP kerl installation is currently active" @@ -748,8 +751,8 @@ download() fi ensure_checksum_file echo "Verifying archive checksum..." - SUM=`$MD5SUM "$KERL_DOWNLOAD_DIR/$1" | cut -d " " -f $MD5SUM_FIELD` - ORIG_SUM=`grep -F "$1" "$KERL_DOWNLOAD_DIR/MD5" | cut -d " " -f 2` + SUM="$($MD5SUM "$KERL_DOWNLOAD_DIR/$1" | cut -d ' ' -f $MD5SUM_FIELD)" + ORIG_SUM="$(grep -F "$1" "$KERL_DOWNLOAD_DIR"/MD5 | cut -d ' ' -f 2)" if [ "$SUM" != "$ORIG_SUM" ]; then echo "Checksum error, check the files in $KERL_DOWNLOAD_DIR" exit 1 @@ -764,13 +767,13 @@ case "$1" in echo "usage: $0 $1 $2 <git_url> <git_version> <build_name>" exit 1 fi - do_git_build $3 $4 $5 + do_git_build "$3" "$4" "$5" else if [ $# -lt 3 ]; then echo "usage: $0 $1 <release> <build_name>" exit 1 fi - do_build $2 $3 + do_build "$2" "$3" fi ;; install) @@ -783,7 +786,7 @@ case "$1" in echo "Refusing to install in $HOME, this is a bad idea." exit 1 else - do_install $2 "$3" + do_install "$2" "$3" fi else if [ -z "$KERL_DEFAULT_INSTALL_DIR" ]; then @@ -791,10 +794,10 @@ case "$1" in echo "Refusing to install in $HOME, this is a bad idea." exit 1 else - do_install $2 . + do_install "$2" . fi else - do_install $2 "$KERL_DEFAULT_INSTALL_DIR/$2" + do_install "$2" "$KERL_DEFAULT_INSTALL_DIR/$2" fi fi ;; @@ -804,12 +807,12 @@ case "$1" in exit 1 fi if [ $# -eq 4 ]; then - do_deploy $2 "$3" "$4" + do_deploy "$2" "$3" "$4" else if [ $# -eq 3 ]; then - do_deploy $2 "$3" + do_deploy "$2" "$3" else - do_deploy $2 . + do_deploy "$2" '.' fi fi ;; @@ -820,7 +823,7 @@ case "$1" in fi case "$2" in releases) - rm -f "$KERL_BASE_DIR/otp_releases" + rm -f "${KERL_BASE_DIR:?}"/otp_releases check_releases echo "The available releases are:" list_print releases spaces @@ -839,14 +842,14 @@ case "$1" in case "$2" in releases) check_releases - list_print $2 space - echo "Run \"$0 update releases\" to update this list from erlang.org" + list_print "$2" space + echo "Run '$0 update releases' to update this list from erlang.org" ;; builds) - list_print $2 + list_print "$2" ;; installations) - list_print $2 + list_print "$2" ;; *) echo "Cannot list $2" @@ -862,23 +865,23 @@ case "$1" in fi case "$2" in build) - rel=`get_release_from_name $3` - if [ -d "$KERL_BUILD_DIR/$3" ]; then - rm -Rf "$KERL_BUILD_DIR/$3" + rel="$(get_release_from_name "$3")" + if [ -d "${KERL_BUILD_DIR:?}/$3" ]; then + rm -Rf "${KERL_BUILD_DIR:?}/$3" else if [ -z "$rel" ]; then echo "No build named $3" exit 1 fi fi - list_remove $2s "$rel,$3" + list_remove "$2"s "$rel,$3" echo "The $3 build has been deleted" ;; installation) assert_valid_installation "$3" rm -Rf "$3" - escaped=`echo "$3" | sed $SED_OPT -e 's#/$##' -e 's#\/#\\\/#g'` - list_remove $2s "$escaped" + escaped="$(echo "$3" | sed $SED_OPT -e 's#/$##' -e 's#\/#\\\/#g')" + list_remove "$2"s "$escaped" echo "The installation in $3 has been deleted" ;; *) @@ -915,11 +918,11 @@ case "$1" in if [ -n "$2" ]; then FMT="$2" fi - ACTIVE_PATH=`get_active_path` + ACTIVE_PATH="$(get_active_path)" if [ -n "$ACTIVE_PATH" ]; then - ACTIVE_NAME=`get_name_from_install_path "$ACTIVE_PATH"` + ACTIVE_NAME="$(get_name_from_install_path "$ACTIVE_PATH")" if [ -z "$ACTIVE_NAME" ]; then - VALUE="`basename "$ACTIVE_PATH"`*" + VALUE="$(basename "$ACTIVE_PATH")*" else VALUE="$ACTIVE_NAME" fi @@ -935,14 +938,14 @@ case "$1" in case "$2" in all) echo "Cleaning up compilation products for ALL builds" - rm -rf $KERL_BUILD_DIR/* - rm -rf $KERL_DOWNLOAD_DIR/* - rm -rf $KERL_GIT_DIR/* + rm -rf "${KERL_BUILD_DIR:?}"/* + rm -rf "${KERL_DOWNLOAD_DIR:?}"/* + rm -rf "${KERL_GIT_DIR:?}"/* echo "Cleaned up all compilation products under $KERL_BUILD_DIR" ;; *) echo "Cleaning up compilation products for $3" - rm -rf $KERL_BUILD_DIR/$3 + rm -rf "${KERL_BUILD_DIR:?}/$3" echo "Cleaned up all compilation products under $KERL_BUILD_DIR" ;; esac |