diff options
author | Anders Svensson <[email protected]> | 2017-09-02 16:17:38 +0200 |
---|---|---|
committer | Anders Svensson <[email protected]> | 2017-09-04 11:43:12 +0200 |
commit | a85d5ae40463ac5157ce4c386c37d30505488466 (patch) | |
tree | bc834389595dcad3d967678798dbea8e7eeedfa7 /.gitattributes | |
parent | ab20efcfec9b9ba72a734c235510aca4d37a10fd (diff) | |
download | otp-a85d5ae40463ac5157ce4c386c37d30505488466.tar.gz otp-a85d5ae40463ac5157ce4c386c37d30505488466.tar.bz2 otp-a85d5ae40463ac5157ce4c386c37d30505488466.zip |
Fix decode undef
Function avp/5 isn't exported from dictionary modules. Not necessarily
intentional, but don't just export it since that requires recompilation
of all dictionary modules, since the function is in diameter_gen.hrl.
Not having to recompile was the main motivation for moving most of the
included code to module diameter_gen in commit 205521d3.
This reveals a weakness in the decode of answers setting the E-bit: any
AVP that isn't defined by the common application won't be decoded; the
diameter_avp records that these are packed into (in the 'AVP' field of a
message record, or equivalent) will have value = undefined. This is
nothing new (same in OTP 19), but the values should be decoded. Fix it
(and the lack of test coverage) in a subsequent commit that will add
avp_dictionaries config.
Diffstat (limited to '.gitattributes')
0 files changed, 0 insertions, 0 deletions