Merge branch 'siri/cuddle-with-tests' into maint

* siri/cuddle-with-tests:
  Fix gen_server_SUITE:call_with_huge_message_queue
  Fix zip_SUITE:borderline test

2 files changed, 35 insertions, 6 deletions

diff --git a/lib/stdlib/test/gen_server_SUITE.erl b/lib/stdlib/test/gen_server_SUITE.erl
index 3b6a3f38bc..a360a0809b 100644
--- a/lib/stdlib/test/gen_server_SUITE.erl
+++ b/lib/stdlib/test/gen_server_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1996-2012. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2013. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -1082,13 +1082,23 @@ replace_state(Config) when is_list(Config) ->
 %% Test that the time for a huge message queue is not
 %% significantly slower than with an empty message queue.
 call_with_huge_message_queue(Config) when is_list(Config) ->
+    case test_server:is_native(gen) of
+	true ->
+	    {skip,
+	     "gen is native - huge message queue optimization "
+	     "is not implemented"};
+	false ->
+	    do_call_with_huge_message_queue()
+		end.
+
+do_call_with_huge_message_queue() ->
     ?line Pid = spawn_link(fun echo_loop/0),
 
-    ?line {Time,ok} = tc(fun() -> calls(10, Pid) end),
+    ?line {Time,ok} = tc(fun() -> calls(10000, Pid) end),
 
     ?line [self() ! {msg,N} || N <- lists:seq(1, 500000)],
     erlang:garbage_collect(),
-    ?line {NewTime,ok} = tc(fun() -> calls(10, Pid) end),
+    ?line {NewTime,ok} = tc(fun() -> calls(10000, Pid) end),
     io:format("Time for empty message queue: ~p", [Time]),
     io:format("Time for huge message queue: ~p", [NewTime]),
 
diff --git a/lib/stdlib/test/zip_SUITE.erl b/lib/stdlib/test/zip_SUITE.erl
index 7233c061ef..a57641ef62 100644
--- a/lib/stdlib/test/zip_SUITE.erl
+++ b/lib/stdlib/test/zip_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2006-2011. All Rights Reserved.
+%% Copyright Ericsson AB 2006-2013. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -109,13 +109,32 @@ borderline_test(Size, TempDir) ->
     ok.
 
 unzip_list(Archive, Name) ->
-    case os:find_executable("unzip") of
-        Unzip when is_list(Unzip) ->
+    case unix_unzip_exists() of
+	true ->
             unzip_list1(Archive, Name);
         _ ->
             ok
     end.
 
+%% Used to do os:find_executable() to check if unzip exists, but on
+%% some hosts that would give an unzip program which did not take the
+%% "-Z" option.
+%% Here we check that "unzip -Z" (which should display usage) and
+%% check that it exists with status 0.
+unix_unzip_exists() ->
+    case os:type() of
+	{unix,_} ->
+	    Port = open_port({spawn,"unzip -Z > /dev/null"}, [exit_status]),
+	    receive
+		{Port,{exit_status,0}} ->
+		    true;
+		{Port,{exit_status,_Fail}} ->
+		    false
+	    end;
+	_ ->
+	    false
+    end.
+
 unzip_list1(Archive, Name) ->
     Expect = Name ++ "\n",
     cmd_expect("unzip -Z -1 " ++ Archive, Expect).