Improved (transport) domain error reporting.

3 files changed, 62 insertions, 47 deletions

diff --git a/lib/snmp/src/agent/snmpa_mpd.erl b/lib/snmp/src/agent/snmpa_mpd.erl
index 21c333b950..4f50b1a674 100644
--- a/lib/snmp/src/agent/snmpa_mpd.erl
+++ b/lib/snmp/src/agent/snmpa_mpd.erl
@@ -1080,8 +1080,13 @@ transform_taddr(?transportDomainUdpIpv6,
     {ok, {Domain, Address}};
 transform_taddr(?transportDomainUdpIpv6, BadAddr) ->
     {error, {bad_transportDomainUdpIpv6_address, BadAddr}};
-transform_taddr(BadTDomain, BadTAddress) ->
-    {error, {bad_domain, BadTDomain, BadTAddress}}.
+transform_taddr(BadTDomain, TAddress) ->
+    case lists:member(BadTDomain, snmp_conf:all_tdomains()) of
+	true ->
+	    {error, {unsupported_tdomain, BadTDomain, TAddress}};
+	false ->
+	    {error, {unknown_tdomain, BadTDomain, TAddress}}
+    end.
 
 
 process_taddrs(Dests) ->
diff --git a/lib/snmp/src/manager/snmpm_config.erl b/lib/snmp/src/manager/snmpm_config.erl
index e61e7abb31..c2e57abddb 100644
--- a/lib/snmp/src/manager/snmpm_config.erl
+++ b/lib/snmp/src/manager/snmpm_config.erl
@@ -147,7 +147,7 @@
 %% -define(DEF_ADDR_TAG, default_addr_tag).
 -define(DEFAULT_TARGETNAME, default_agent).
 -define(DEF_PORT_TAG,       default_port_tag).
--define(VALID_DOMAINS,      [transportDomainUdpIpv4, transportDomainUdpIpv6]).
+-define(SUPPORTED_DOMAINS,  [transportDomainUdpIpv4, transportDomainUdpIpv6]).
 
 -ifdef(snmp_debug).
 -define(GS_START_LINK(Opts),
@@ -3000,15 +3000,20 @@ verify_val(reg_type, RegType)
     {ok, RegType};
 verify_val(tdomain = Item, snmpUDPDomain = _Domain) ->
     verify_val(Item, transportDomainUdpIpv4);
-verify_val(tdomain, TDomain) ->
-    case lists:member(TDomain, ?VALID_DOMAINS) of
+verify_val(tdomain, Domain) ->
+    case lists:member(Domain, ?SUPPORTED_DOMAINS) of
 	true ->
-	    {ok, TDomain};
+	    {ok, Domain};
 	false ->
-	    error({bad_tdomain, TDomain})
+	    case lists:member(Domain, snmp_conf:all_domains()) of
+		true ->
+		    error({unsupported_domain, Domain});
+		false ->
+		    error({unknown_domain, Domain})
+	    end
     end;
-verify_val(address, {TDomain, Addr0}) ->
-    case normalize_address(TDomain, Addr0) of
+verify_val(address, {Domain, Addr0}) ->
+    case normalize_address(Domain, Addr0) of
 	{_A1, _A2, _A3, _A4} = Addr ->
 	    {ok, Addr};
 	{_A1, _A2, _A3, _A4, _A5, _A6, _A7, _A8} = Addr ->
diff --git a/lib/snmp/src/misc/snmp_conf.erl b/lib/snmp/src/misc/snmp_conf.erl
index 99f97cd6e1..7249def24e 100644
--- a/lib/snmp/src/misc/snmp_conf.erl
+++ b/lib/snmp/src/misc/snmp_conf.erl
@@ -37,7 +37,9 @@
 
 	 check_timer/1,
 
+	 all_domains/0, 
 	 check_domain/1, 
+	 all_tdomains/0, 
 	 check_tdomain/1,  
 	 mk_tdomain/1, 
 	 which_domain/1, 
@@ -345,6 +347,25 @@ check_sec_level(BadSecLevel) ->
 
 
 %% ---------
+all_tdomains() ->
+    [
+     ?transportDomainUdpIpv4, 
+     ?transportDomainUdpIpv6, 
+     ?transportDomainUdpIpv4z, 
+     ?transportDomainUdpIpv6z, 
+     ?transportDomainTcpIpv4, 
+     ?transportDomainTcpIpv6, 
+     ?transportDomainTcpIpv4z, 
+     ?transportDomainTcpIpv6z, 
+     ?transportDomainSctpIpv4, 
+     ?transportDomainSctpIpv6, 
+     ?transportDomainSctpIpv4z, 
+     ?transportDomainSctpIpv6z, 
+     ?transportDomainLocal, 
+     ?transportDomainUdpDns, 
+     ?transportDomainTcpDns,
+     ?transportDomainSctpDns
+    ].
 
 check_tdomain(TDomain) ->
     SupportedTDomains = 
@@ -353,25 +374,7 @@ check_tdomain(TDomain) ->
 	 ?transportDomainUdpIpv4,
 	 ?transportDomainUdpIpv6			 
 	],
-    AllTDomains = 
-	[
-	 ?transportDomainUdpIpv4, 
-	 ?transportDomainUdpIpv6, 
-	 ?transportDomainUdpIpv4z, 
-	 ?transportDomainUdpIpv6z, 
-	 ?transportDomainTcpIpv4, 
-	 ?transportDomainTcpIpv6, 
-	 ?transportDomainTcpIpv4z, 
-	 ?transportDomainTcpIpv6z, 
-	 ?transportDomainSctpIpv4, 
-	 ?transportDomainSctpIpv6, 
-	 ?transportDomainSctpIpv4z, 
-	 ?transportDomainSctpIpv6z, 
-	 ?transportDomainLocal, 
-	 ?transportDomainUdpDns, 
-	 ?transportDomainTcpDns,
-	 ?transportDomainSctpDns
-	],
+    AllTDomains = all_tdomains(), 
     case lists:member(TDomain, SupportedTDomains) of
 	true ->
 	    ok;
@@ -474,6 +477,26 @@ do_check_timer(WaitFor, Factor, Incr, Retry) ->
 
 %% ---------
 
+all_domains() ->
+    [
+     transportDomainUdpIpv4, 
+     transportDomainUdpIpv6, 
+     transportDomainUdpIpv4z, 
+     transportDomainUdpIpv6z, 
+     transportDomainTcpIpv4, 
+     transportDomainTcpIpv6, 
+     transportDomainTcpIpv4z, 
+     transportDomainTcpIpv6z, 
+     transportDomainSctpIpv4, 
+     transportDomainSctpIpv6, 
+     transportDomainSctpIpv4z, 
+     transportDomainSctpIpv6z, 
+     transportDomainLocal, 
+     transportDomainUdpDns, 
+     transportDomainTcpDns,
+     transportDomainSctpDns
+    ].
+
 check_domain(Domain) ->
     SupportedDomains = 
 	[
@@ -481,25 +504,7 @@ check_domain(Domain) ->
 	 transportDomainUdpIpv4,
 	 transportDomainUdpIpv6
 	],
-    AllDomains = 
-	[
-	 transportDomainUdpIpv4, 
-	 transportDomainUdpIpv6, 
-	 transportDomainUdpIpv4z, 
-	 transportDomainUdpIpv6z, 
-	 transportDomainTcpIpv4, 
-	 transportDomainTcpIpv6, 
-	 transportDomainTcpIpv4z, 
-	 transportDomainTcpIpv6z, 
-	 transportDomainSctpIpv4, 
-	 transportDomainSctpIpv6, 
-	 transportDomainSctpIpv4z, 
-	 transportDomainSctpIpv6z, 
-	 transportDomainLocal, 
-	 transportDomainUdpDns, 
-	 transportDomainTcpDns,
-	 transportDomainSctpDns
-	],
+    AllDomains = all_domains(), 
     case lists:member(Domain, SupportedDomains) of
 	true ->
 	    ok;