diff options
| author | Anthony Ramine <[email protected]> | 2013-11-21 21:34:18 +0100 |
|---|---|---|
| committer | Sverker Eriksson <[email protected]> | 2013-11-21 21:36:19 +0100 |
| commit | 5fec8527e925f4a6da02d560a9afbbf39912747c (patch) | |
| tree | 7f6bb31be89b5f549078bdfa35aa6a28d8077a7f | |
| parent | c01df2215ac3ddef82116abac5eaf236d3788f21 (diff) | |
| download | otp-5fec8527e925f4a6da02d560a9afbbf39912747c.tar.gz otp-5fec8527e925f4a6da02d560a9afbbf39912747c.tar.bz2 otp-5fec8527e925f4a6da02d560a9afbbf39912747c.zip | |
Fix some uninitialized pointers in crypto
crypto.c:2748:9: warning: variable 'bn_prime' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized]
if (!get_bn_from_bin(env, argv[0], &bn_verifier)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
crypto.c:2758:6: note: uninitialized use occurs here
if (bn_prime) BN_free(bn_prime);
^~~~~~~~
crypto.c:2748:9: note: remove the '||' if its condition is always false
if (!get_bn_from_bin(env, argv[0], &bn_verifier)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| -rw-r--r-- | lib/crypto/c_src/crypto.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/crypto/c_src/crypto.c b/lib/crypto/c_src/crypto.c index c28ff8136c..42fb172953 100644 --- a/lib/crypto/c_src/crypto.c +++ b/lib/crypto/c_src/crypto.c @@ -2658,8 +2658,9 @@ static ERL_NIF_TERM srp_user_secret_nif(ErlNifEnv* env, int argc, const ERL_NIF_ <premaster secret> = (B - (k * g^x)) ^ (a + (u * x)) % N */ BIGNUM *bn_exponent = NULL, *bn_a = NULL; - BIGNUM *bn_u, *bn_multiplier, *bn_exp2, *bn_base, - *bn_prime, *bn_generator, *bn_B, *bn_result; + BIGNUM *bn_u = NULL, *bn_multiplier = NULL, *bn_exp2, + *bn_base, *bn_prime = NULL, *bn_generator = NULL, + *bn_B = NULL, *bn_result; BN_CTX *bn_ctx; unsigned char* ptr; unsigned dlen; |