diff options
author | Björn Gustavsson <[email protected]> | 2011-11-23 15:59:28 +0100 |
---|---|---|
committer | Björn Gustavsson <[email protected]> | 2011-11-23 16:01:12 +0100 |
commit | 3996b68aaf957a00699494d62c64142ed98e967a (patch) | |
tree | 3240bad34871b126930db866076b84dce52e23df | |
parent | 10b4b4fc93339f85d1552100cbe6e0d7f4300ec4 (diff) | |
download | otp-3996b68aaf957a00699494d62c64142ed98e967a.tar.gz otp-3996b68aaf957a00699494d62c64142ed98e967a.tar.bz2 otp-3996b68aaf957a00699494d62c64142ed98e967a.zip |
tar_SUITE: Don't do symlink tests on Windows
-rw-r--r-- | lib/stdlib/test/tar_SUITE.erl | 27 |
1 files changed, 25 insertions, 2 deletions
diff --git a/lib/stdlib/test/tar_SUITE.erl b/lib/stdlib/test/tar_SUITE.erl index 9ad3936928..65ccdcb7a8 100644 --- a/lib/stdlib/test/tar_SUITE.erl +++ b/lib/stdlib/test/tar_SUITE.erl @@ -533,7 +533,7 @@ symlinks(Config) when is_list(Config) -> ?line ok = file:make_dir(Dir), ?line ABadSymlink = filename:join(Dir, "bad_symlink"), ?line PointsTo = "/a/definitely/non_existing/path", - ?line Res = case file:make_symlink("/a/definitely/non_existing/path", ABadSymlink) of + ?line Res = case make_symlink("/a/definitely/non_existing/path", ABadSymlink) of {error, enotsup} -> {skip, "Symbolic links not supported on this platform"}; ok -> @@ -544,7 +544,30 @@ symlinks(Config) when is_list(Config) -> %% Clean up. ?line delete_files([Dir]), Res. - + +make_symlink(Path, Link) -> + case os:type() of + {win32,_} -> + %% Symlinks on Windows have two problems: + %% 1) file:read_link_info/1 cannot read out the target + %% of the symlink if the target does not exist. + %% That is possible (but not easy) to fix in the + %% efile driver. + %% + %% 2) Symlinks to files and directories are different + %% creatures. If the target is not existing, the + %% symlink will be created to be of the file-pointing + %% type. That can be partially worked around in erl_tar + %% by creating all symlinks when the end of the tar + %% file has been reached. + %% + %% But for now, pretend that there are no symlinks on + %% Windows. + {error, enotsup}; + _ -> + file:make_symlink(Path, Link) + end. + symlinks(Dir, BadSymlink, PointsTo) -> ?line Tar = filename:join(Dir, "symlink.tar"), ?line DerefTar = filename:join(Dir, "dereference.tar"), |