Test suites: Add support for running Dialyzer on generated code

Running dialyzer on test suites is good for finding both bugs and
useless dialyzer warnings. Add a mechanism in asn1_test_lib for
turning on running of dialyzer on all generated code.

Turned off by default, because it is slow and because there are
still a few dialyzer warnings left.

4 files changed, 104 insertions, 58 deletions

diff --git a/lib/asn1/test/asn1_SUITE.erl b/lib/asn1/test/asn1_SUITE.erl
index b20380fec9..11d1b82fb4 100644
--- a/lib/asn1/test/asn1_SUITE.erl
+++ b/lib/asn1/test/asn1_SUITE.erl
@@ -50,13 +50,14 @@ all() ->
      {group, performance}].
 
 groups() ->
-    [{compile, parallel([]),
+    Parallel = asn1_test_lib:parallel(),
+    [{compile, Parallel,
       [c_syntax,
        c_string,
        c_implicit_before_choice,
        constraint_equivalence]},
 
-     {ber, parallel([]),
+     {ber, Parallel,
       [ber_choiceinseq,
        % Uses 'SOpttest'
        ber_optional]},
@@ -65,7 +66,7 @@ groups() ->
 
      {appup_test, [], [{asn1_appup_test, all}]},
 
-     {parallel, parallel([]),
+     {parallel, Parallel,
       [cover,
        xref,
        {group, ber},
@@ -173,13 +174,6 @@ groups() ->
        testTimer_per,
        testTimer_uper]}].
 
-parallel(Options) ->
-    case erlang:system_info(smp_support) andalso
-         erlang:system_info(schedulers) > 1 of
-        true  -> [parallel|Options];
-        false -> Options
-    end.
-
 %%------------------------------------------------------------------------------
 %% Init/end
 %%------------------------------------------------------------------------------
diff --git a/lib/asn1/test/asn1_test_lib.erl b/lib/asn1/test/asn1_test_lib.erl
index 417380159e..06e9b2c093 100644
--- a/lib/asn1/test/asn1_test_lib.erl
+++ b/lib/asn1/test/asn1_test_lib.erl
@@ -21,19 +21,72 @@
 
 -export([compile/3,compile_all/3,compile_erlang/3,
 	 hex_to_bin/1,
+	 parallel/0,
 	 roundtrip/3,roundtrip/4,roundtrip_enc/3,roundtrip_enc/4]).
 
 -include_lib("test_server/include/test_server.hrl").
 
+run_dialyzer() ->
+    false.
+
 compile(File, Config, Options) -> compile_all([File], Config, Options).
 
 compile_all(Files, Config, Options) ->
     DataDir = ?config(data_dir, Config),
     CaseDir = ?config(case_dir, Config),
-    [compile_file(filename:join(DataDir, F), [{outdir, CaseDir}|Options])
+    [compile_file(filename:join(DataDir, F), [{outdir, CaseDir},
+					      debug_info|Options])
          || F <- Files],
+    dialyze(Files, Options),
     ok.
 
+parallel() ->
+    case erlang:system_info(schedulers) > 1 andalso not run_dialyzer() of
+        true  -> [parallel];
+        false -> []
+    end.
+
+dialyze(Files, Options) ->
+    case not run_dialyzer() orelse lists:member(abs, Options) of
+	true -> ok;
+	false -> dialyze(Files)
+    end.
+
+dialyze(Files) ->
+    Beams0 = [code:which(module(F)) || F <- Files],
+    Beams = [code:which(asn1rt_nif)|Beams0],
+    case dialyzer:run([{files,Beams},
+		       {warnings,[no_improper_lists]},
+		       {get_warnings,true}]) of
+	[] ->
+	    ok;
+	[_|_]=Ws ->
+	    io:put_chars([[B,$\n] || B <- Beams]),
+	    io:put_chars([dialyzer:format_warning(W) || W <- Ws]),
+	    error(dialyzer_warnings)
+    end.
+
+module(F0) ->
+    F1 = filename:basename(F0),
+    F2 = case filename:extension(F1) of
+	     ".asn" ->
+		 filename:rootname(F1);
+	     ".asn1" ->
+		 filename:rootname(F1);
+	     ".py" ->
+		 filename:rootname(F1);
+	     "" ->
+		 F1
+	 end,
+    F = case filename:extension(F2) of
+	    ".set" ->
+		filename:rootname(F2);
+	    "" ->
+		F2
+	end,
+    list_to_atom(F).
+%%    filename:join(CaseDir, F ++ ".beam").
+
 compile_file(File, Options) ->
     try
         ok = asn1ct:compile(File, [warnings_as_errors|Options])
diff --git a/lib/asn1/test/testNBAPsystem.erl b/lib/asn1/test/testNBAPsystem.erl
index 57cb483374..e37e22163a 100644
--- a/lib/asn1/test/testNBAPsystem.erl
+++ b/lib/asn1/test/testNBAPsystem.erl
@@ -79,13 +79,14 @@ powerRaiseLimit, dLPowerAveragingWindowSize, 'iE-Extensions' = asn1_NOVALUE}).
 
 
 compile(Config, Options) ->
-    [asn1_test_lib:compile(filename:join([nbapsystem, M]), Config, Options)
-     || M <- ["NBAP-CommonDataTypes.asn",
-              "NBAP-IEs.asn",
-              "NBAP-PDU-Contents.asn",
-              "NBAP-PDU-Discriptions.asn",
-              "NBAP-Constants.asn",
-              "NBAP-Containers.asn"]],
+    Fs = [filename:join("nbapsystem", M) ||
+	     M <- ["NBAP-CommonDataTypes.asn",
+		   "NBAP-IEs.asn",
+		   "NBAP-PDU-Contents.asn",
+		   "NBAP-PDU-Discriptions.asn",
+		   "NBAP-Constants.asn",
+		   "NBAP-Containers.asn"]],
+    asn1_test_lib:compile_all(Fs, Config, Options),
     ok.
 
 
diff --git a/lib/asn1/test/testTcapsystem.erl b/lib/asn1/test/testTcapsystem.erl
index 4979a385b2..fcc9e084e0 100644
--- a/lib/asn1/test/testTcapsystem.erl
+++ b/lib/asn1/test/testTcapsystem.erl
@@ -21,44 +21,42 @@
 
 -export([compile/2]).
 
--include_lib("test_server/include/test_server.hrl").
-
 compile(Config, Options) ->
-    [asn1_test_lib:compile(filename:join([tcapsystem, M]), Config, Options)
-     || M <- ["DialoguePDUs.asn",
-              "MAP-ApplicationContexts.asn",
-              "MAP-BS-Code.asn",
-              "MAP-CallHandlingOperations.asn",
-              "MAP-CH-DataTypes.asn",
-              "MAP-CommonDataTypes.asn",
-              "MAP-DialogueInformation.asn",
-              "MAP-ER-DataTypes.asn",
-              "MAP-Errors.asn",
-              "MAP-ExtensionDataTypes.asn",
-              "MAP-GR-DataTypes.asn",
-              "MAP-Group-Call-Operations.asn",
-              "MAP-LCS-DataTypes.asn",
-              "MAP-LocationServiceOperations.asn",
-              "MAP-MobileServiceOperations.asn",
-              "MAP-MS-DataTypes.asn",
-              "MAP-OM-DataTypes.asn",
-              "MAP-OperationAndMaintenanceOperations.asn",
-              "MAP-Protocol.asn",
-              "MAP-SecureTransportOperations.asn",
-              "MAP-ShortMessageServiceOperations.asn",
-              "MAP-SM-DataTypes.asn",
-              "MAP-SS-Code.asn",
-              "MAP-SS-DataTypes.asn",
-              "MAP-ST-DataTypes.asn",
-              "MAP-SupplementaryServiceOperations.asn",
-              "MAP-TS-Code.asn",
-              "MobileDomainDefinitions.asn",
-              "Remote-Operations-Generic-ROS-PDUs.asn",
-              "Remote-Operations-Information-Objects.asn",
-              "Remote-Operations-Useful-Definitions.asn",
-              "TCAP-Examples.asn",
-              "TCAPMessages.asn",
-              "TCAP-Tools.asn",
-              "TC-Notation-Extensions.asn",
-              "UnidialoguePDUs.asn"]],
-    ok.
+    Fs = [filename:join("tcapsystem", M) ||
+	     M <- ["DialoguePDUs.asn",
+		   "MAP-ApplicationContexts.asn",
+		   "MAP-BS-Code.asn",
+		   "MAP-CallHandlingOperations.asn",
+		   "MAP-CH-DataTypes.asn",
+		   "MAP-CommonDataTypes.asn",
+		   "MAP-DialogueInformation.asn",
+		   "MAP-ER-DataTypes.asn",
+		   "MAP-Errors.asn",
+		   "MAP-ExtensionDataTypes.asn",
+		   "MAP-GR-DataTypes.asn",
+		   "MAP-Group-Call-Operations.asn",
+		   "MAP-LCS-DataTypes.asn",
+		   "MAP-LocationServiceOperations.asn",
+		   "MAP-MobileServiceOperations.asn",
+		   "MAP-MS-DataTypes.asn",
+		   "MAP-OM-DataTypes.asn",
+		   "MAP-OperationAndMaintenanceOperations.asn",
+		   "MAP-Protocol.asn",
+		   "MAP-SecureTransportOperations.asn",
+		   "MAP-ShortMessageServiceOperations.asn",
+		   "MAP-SM-DataTypes.asn",
+		   "MAP-SS-Code.asn",
+		   "MAP-SS-DataTypes.asn",
+		   "MAP-ST-DataTypes.asn",
+		   "MAP-SupplementaryServiceOperations.asn",
+		   "MAP-TS-Code.asn",
+		   "MobileDomainDefinitions.asn",
+		   "Remote-Operations-Generic-ROS-PDUs.asn",
+		   "Remote-Operations-Information-Objects.asn",
+		   "Remote-Operations-Useful-Definitions.asn",
+		   "TCAP-Examples.asn",
+		   "TCAPMessages.asn",
+		   "TCAP-Tools.asn",
+		   "TC-Notation-Extensions.asn",
+		   "UnidialoguePDUs.asn"]],
+    asn1_test_lib:compile_all(Fs, Config, Options).