diff options
| author | Björn Gustavsson <[email protected]> | 2013-02-10 09:07:49 +0100 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2013-02-10 09:20:17 +0100 |
| commit | 6b456e94d11ffe8a9f2e361fe8143902a2b99baf (patch) | |
| tree | b9079aae089a12015c9d753a3b085905cc8ce81d | |
| parent | f1e98d7c70457f85be52cefda73ec4f4d98f5822 (diff) | |
| download | otp-6b456e94d11ffe8a9f2e361fe8143902a2b99baf.tar.gz otp-6b456e94d11ffe8a9f2e361fe8143902a2b99baf.tar.bz2 otp-6b456e94d11ffe8a9f2e361fe8143902a2b99baf.zip | |
erl_eval: Don't allow evaluation of {M,F} in the shell
Tuples funs were removed in de7e01c958ff7c9e6da4034a53567a30a4ae5792,
but it was still possible to evaluate tuple funs in the shell.
| -rw-r--r-- | lib/stdlib/src/erl_eval.erl | 7 | ||||
| -rw-r--r-- | lib/stdlib/test/erl_eval_SUITE.erl | 4 |
2 files changed, 10 insertions, 1 deletions
diff --git a/lib/stdlib/src/erl_eval.erl b/lib/stdlib/src/erl_eval.erl index 1c3f91cbfc..0b57af1b6d 100644 --- a/lib/stdlib/src/erl_eval.erl +++ b/lib/stdlib/src/erl_eval.erl @@ -346,7 +346,12 @@ expr({call,_,{atom,_,Func},As0}, Bs0, Lf, Ef, RBs) -> expr({call,_,Func0,As0}, Bs0, Lf, Ef, RBs) -> % function or {Mod,Fun} {value,Func,Bs1} = expr(Func0, Bs0, Lf, Ef, none), {As,Bs2} = expr_list(As0, Bs1, Lf, Ef), - do_apply(Func, As, Bs2, Ef, RBs); + case Func of + {M,F} when is_atom(M), is_atom(F) -> + erlang:raise(error, {badfun,Func}, stacktrace()); + _ -> + do_apply(Func, As, Bs2, Ef, RBs) + end; expr({'catch',_,Expr}, Bs0, Lf, Ef, RBs) -> Ref = make_ref(), case catch {Ref,expr(Expr, Bs0, Lf, Ef, none)} of diff --git a/lib/stdlib/test/erl_eval_SUITE.erl b/lib/stdlib/test/erl_eval_SUITE.erl index d3c91c7326..7ff4c81ea6 100644 --- a/lib/stdlib/test/erl_eval_SUITE.erl +++ b/lib/stdlib/test/erl_eval_SUITE.erl @@ -1086,6 +1086,10 @@ funs(Config) when is_list(Config) -> "begin M = lists, F = fun M:reverse/1," " [1,2] = F([2,1]), ok end.", ok), + + %% Test that {M,F} is not accepted as a fun. + error_check("{" ?MODULE_STRING ",module_info}().", + {badfun,{?MODULE,module_info}}), ok. run_many_args({S, As}) -> |