[snmp/agent] Make the mib-server test (sub-) suite use new mib-storage

1 files changed, 102 insertions, 35 deletions

diff --git a/lib/snmp/test/snmp_agent_mibs_test.erl b/lib/snmp/test/snmp_agent_mibs_test.erl
index 3e48130fac..4569be0b5a 100644
--- a/lib/snmp/test/snmp_agent_mibs_test.erl
+++ b/lib/snmp/test/snmp_agent_mibs_test.erl
@@ -19,13 +19,16 @@
 
 %%
 %%----------------------------------------------------------------------
-%% Purpose:
+%% Purpose: Test suite of the agent mib-server.
 %%----------------------------------------------------------------------
+
 -module(snmp_agent_mibs_test).
 
+
 %%----------------------------------------------------------------------
 %% Include files
 %%----------------------------------------------------------------------
+
 -include_lib("test_server/include/test_server.hrl").
 -include("snmp_test_lib.hrl").
 -include_lib("snmp/include/snmp_types.hrl").
@@ -39,13 +42,23 @@
 %% External exports
 %%----------------------------------------------------------------------
 -export([
-	all/0,groups/0,init_per_group/2,end_per_group/2, 
-         init_per_testcase/2, end_per_testcase/2,
-	 init_per_suite/1, end_per_suite/1, 
+	 all/0,
+	 groups/0,
+
+	 init_per_suite/1, 
+	 end_per_suite/1, 
+
+	 init_per_group/2,
+	 end_per_group/2, 
+
+         init_per_testcase/2, 
+	 end_per_testcase/2,
 
 	 start_and_stop/1,
 	
-	 size_check_ets/1,
+	 size_check_ets1/1,
+	 size_check_ets2/1,
+	 size_check_ets3/1,
 	 size_check_dets/1,
 	 size_check_mnesia/1,
 	 load_unload/1,
@@ -55,6 +68,7 @@
 
 	]).
 
+
 %%----------------------------------------------------------------------
 %% Internal exports
 %%----------------------------------------------------------------------
@@ -71,6 +85,16 @@
 %% External functions
 %%======================================================================
 
+init_per_testcase(size_check_ets2, Config) when is_list(Config) ->
+    Dir = ?config(priv_dir, Config),
+    EtsDir = join(Dir, "ets_dir2/"),
+    ?line ok = file:make_dir(EtsDir),
+    [{ets_dir, EtsDir}|Config];
+init_per_testcase(size_check_ets3, Config) when is_list(Config) ->
+    Dir = ?config(priv_dir, Config),
+    EtsDir = join(Dir, "ets_dir3/"),
+    ?line ok = file:make_dir(EtsDir),
+    [{ets_dir, EtsDir}|Config];
 init_per_testcase(size_check_dets, Config) when is_list(Config) ->
     Dir = ?config(priv_dir, Config),
     DetsDir = join(Dir, "dets_dir/"),
@@ -98,6 +122,13 @@ init_per_testcase(cache_test, Config) when is_list(Config) ->
 init_per_testcase(_Case, Config) when is_list(Config) ->
     Config.
 
+end_per_testcase(EtsCase, Config) 
+  when (is_list(Config) andalso 
+	((EtsCase =:= size_check_ets2) orelse 
+	 (EtsCase =:= size_check_ets3))) ->
+    Dir = ?config(ets_dir, Config),
+    ?line ok = ?DEL_DIR(Dir),
+    lists:keydelete(ets_dir, 1, Config);
 end_per_testcase(size_check_dets, Config) when is_list(Config) ->
     Dir = ?config(dets_dir, Config),
     ?line ok = ?DEL_DIR(Dir),
@@ -124,18 +155,31 @@ cases().
 
 groups() -> 
     [{size_check, [],
-  [size_check_ets, size_check_dets, size_check_mnesia]}].
+      [
+       size_check_ets1,   % Plain ets
+       size_check_ets2,   % ets with a file
+       size_check_ets3,   % ets with a checksummed file
+       size_check_dets,   % Plain dets
+       size_check_mnesia  % Plain mnesia
+      ]
+     }].
 
 init_per_group(_GroupName, Config) ->
-	Config.
+    Config.
 
 end_per_group(_GroupName, Config) ->
-	Config.
+    Config.
 
 
 cases() -> 
-[start_and_stop, load_unload, {group, size_check},
- me_lookup, which_mib, cache_test].
+    [
+     start_and_stop, 
+     load_unload, 
+     {group, size_check},
+     me_lookup, 
+     which_mib, 
+     cache_test
+    ].
 
 init_per_suite(Config) when is_list(Config) ->
     %% Data dir points wrong
@@ -175,7 +219,6 @@ load_unload(suite) -> [];
 load_unload(Config) when is_list(Config) ->
     Prio       = normal,
     Verbosity  = log,
-    %% MibStorage = ets,
     MibDir     = ?config(snmp_data_dir, Config),
 
     ?DBG("load_unload -> start symbolic store", []),
@@ -221,21 +264,42 @@ load_unload(Config) when is_list(Config) ->
 %% ---------------------------------------------------------------------
 
 
-size_check_ets(suite) ->
+size_check_ets1(suite) ->
+    [];
+size_check_ets1(Config) when is_list(Config) ->
+    MibStorage = [{module, snmpa_mib_storage_ets}], 
+    do_size_check([{mib_storage, MibStorage}|Config]).
+
+size_check_ets2(suite) ->
+    [];
+size_check_ets2(Config) when is_list(Config) ->
+    Dir = ?config(ets_dir, Config),    
+    MibStorage = [{module, snmpa_mib_storage_ets}, 
+		  {options, [{dir, Dir}]}], 
+    do_size_check([{mib_storage, MibStorage}|Config]).
+
+size_check_ets3(suite) ->
     [];
-size_check_ets(Config) when is_list(Config) ->
-    do_size_check([{mib_storage, ets}|Config]).
+size_check_ets3(Config) when is_list(Config) ->
+    Dir = ?config(ets_dir, Config),    
+    MibStorage = [{module, snmpa_mib_storage_ets}, 
+		  {options, [{dir, Dir}, {checksum, true}]}], 
+    do_size_check([{mib_storage, MibStorage}|Config]).
 
 size_check_dets(suite) ->
     [];
 size_check_dets(Config) when is_list(Config) ->
     Dir = ?config(dets_dir, Config),
-    do_size_check([{mib_storage, {dets, Dir}}|Config]).
+    MibStorage = [{module, snmpa_mib_storage_dets}, 
+		  {options, [{dir, Dir}]}], 
+    do_size_check([{mib_storage, MibStorage}|Config]).
 
 size_check_mnesia(suite) ->
     [];
 size_check_mnesia(Config) when is_list(Config) ->
-    do_size_check([{mib_storage, {mnesia, [node()]}}|Config]).
+    MibStorage = [{module, snmpa_mib_storage_mnesia}, 
+		  {options, [{nodes, [node()]}]}], 
+    do_size_check([{mib_storage, MibStorage}|Config]).
 
 do_size_check(Config) ->
     ?DBG("do_size_check -> start", []),
@@ -294,7 +358,6 @@ me_lookup(suite) -> [];
 me_lookup(Config) when is_list(Config) ->
     Prio       = normal,
     Verbosity  = trace,
-    %% MibStorage = ets,
     MibDir     = ?config(snmp_data_dir, Config),
     StdMibDir  = filename:join(code:priv_dir(snmp), "mibs") ++ "/",
     Mibs    = ["Test2", "TestTrap", "TestTrapv2"],
@@ -348,7 +411,6 @@ which_mib(suite) -> [];
 which_mib(Config) when is_list(Config) ->
     Prio       = normal,
     Verbosity  = trace,
-    %% MibStorage = ets,
     MibDir     = ?config(snmp_data_dir, Config),
     StdMibDir  = filename:join(code:priv_dir(snmp), "mibs") ++ "/",
     Mibs    = ["Test2", "TestTrap", "TestTrapv2"],
@@ -406,28 +468,28 @@ cache_test(Config) when is_list(Config) ->
     ?DBG("cache_test -> start", []),
     Prio       = normal,
     Verbosity  = trace,
-    MibStorage = ets,
+    MibStorage = [{module, snmpa_mib_storage_ets}],
     MibDir     = ?config(snmp_data_dir, Config),
     StdMibDir  = filename:join(code:priv_dir(snmp), "mibs") ++ "/",
-    Mibs    = ["Test2", "TestTrap", "TestTrapv2"],
-    StdMibs = ["OTP-SNMPEA-MIB",
-	       "SNMP-COMMUNITY-MIB",
-	       "SNMP-FRAMEWORK-MIB",
-	       "SNMP-MPD-MIB",
-	       "SNMP-NOTIFICATION-MIB",
-	       "SNMP-TARGET-MIB",
-	       %% "SNMP-USER-BASED-SM-MIB",
-	       "SNMP-VIEW-BASED-ACM-MIB",
-	       "SNMPv2-MIB",
-	       "SNMPv2-TC",
-	       "SNMPv2-TM"],
+    Mibs       = ["Test2", "TestTrap", "TestTrapv2"],
+    StdMibs    = ["OTP-SNMPEA-MIB",
+		  "SNMP-COMMUNITY-MIB",
+		  "SNMP-FRAMEWORK-MIB",
+		  "SNMP-MPD-MIB",
+		  "SNMP-NOTIFICATION-MIB",
+		  "SNMP-TARGET-MIB",
+		  %% "SNMP-USER-BASED-SM-MIB",
+		  "SNMP-VIEW-BASED-ACM-MIB",
+		  "SNMPv2-MIB",
+		  "SNMPv2-TC",
+		  "SNMPv2-TM"],
 
     ?DBG("cache_test -> start symbolic store", []),
     ?line sym_start(Prio, MibStorage, Verbosity),
 
     ?DBG("cache_test -> start mib server", []),
-    GcLimit = 2, 
-    Age     = timer:seconds(10), 
+    GcLimit   = 2, 
+    Age       = timer:seconds(10), 
     CacheOpts = [{autogc, false}, {age, Age}, {gclimit, GcLimit}],
     ?line MibsPid = mibs_start(Prio, MibStorage, [], Verbosity, CacheOpts), 
     
@@ -537,7 +599,7 @@ mnesia_stop() ->
 %% - Symbolic Store mini interface
 
 sym_start(Prio, Verbosity) ->
-    sym_start(Prio, ets, Verbosity).
+    sym_start(Prio, mib_storage(), Verbosity).
 
 sym_start(Prio, MibStorage, Verbosity) ->
     Opts = [{mib_storage, MibStorage}, {verbosity,Verbosity}],
@@ -554,7 +616,7 @@ sym_info() ->
 %% -- MIB server mini interface 
 		   
 mibs_start(Prio, Verbosity) when is_atom(Prio) andalso is_atom(Verbosity) ->
-    mibs_start(Prio, ets, [], Verbosity).
+    mibs_start(Prio, mib_storage(), [], Verbosity).
 
 mibs_start(Prio, MibStorage, Verbosity) 
   when is_atom(Prio) andalso is_atom(Verbosity) ->
@@ -671,6 +733,11 @@ which_mib(M1, M2) ->
     {error, {invalid_mib, M1, M2}}.
 
 
+%% Default mib-storage
+mib_storage() ->
+    [{module, snmpa_mib_storage_ets}].
+
+
 %% -- 
 
 display_memory_usage(MibsPid) ->