diff options
| author | Richard Carlsson <[email protected]> | 2016-11-21 12:15:06 +0100 |
|---|---|---|
| committer | Richard Carlsson <[email protected]> | 2016-11-29 08:34:17 +0100 |
| commit | 9755ab551e94ecb2d87c6035fa818768d1c53b82 (patch) | |
| tree | 0349988f26de09d27ad8815bf352b02d5feb2f58 | |
| parent | 6cd29742be8c11c250d3c07ef180e15c04347c91 (diff) | |
| download | otp-9755ab551e94ecb2d87c6035fa818768d1c53b82.tar.gz otp-9755ab551e94ecb2d87c6035fa818768d1c53b82.tar.bz2 otp-9755ab551e94ecb2d87c6035fa818768d1c53b82.zip | |
Write node info before log message body, not after
Make error_logger_tty_h insert node information for nonlocal messages before
the message itself instead of after, both for readability and so as not to
change the line termination property at the end of the message.
| -rw-r--r-- | lib/stdlib/src/error_logger_file_h.erl | 2 | ||||
| -rw-r--r-- | lib/stdlib/src/error_logger_tty_h.erl | 2 | ||||
| -rw-r--r-- | lib/stdlib/test/error_logger_h_SUITE.erl | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/lib/stdlib/src/error_logger_file_h.erl b/lib/stdlib/src/error_logger_file_h.erl index 51ad61e26d..0b262de3ab 100644 --- a/lib/stdlib/src/error_logger_file_h.erl +++ b/lib/stdlib/src/error_logger_file_h.erl @@ -125,7 +125,7 @@ write_event(#st{fd=Fd}=State, Event) -> true -> [] end, - io:put_chars(Fd, [Header,Body,AtNode]) + io:put_chars(Fd, [Header,AtNode,Body]) end. format_body(State, [{Format,Args}|T]) -> diff --git a/lib/stdlib/src/error_logger_tty_h.erl b/lib/stdlib/src/error_logger_tty_h.erl index c320e8200d..2f2fd65252 100644 --- a/lib/stdlib/src/error_logger_tty_h.erl +++ b/lib/stdlib/src/error_logger_tty_h.erl @@ -141,7 +141,7 @@ do_write_event(State, {Time, Event}) -> true -> [] end, - Str = [Header,Body,AtNode], + Str = [Header,AtNode,Body], case State#st.io_mod of io_lib -> Str; diff --git a/lib/stdlib/test/error_logger_h_SUITE.erl b/lib/stdlib/test/error_logger_h_SUITE.erl index 2a34c7764f..30f96e0522 100644 --- a/lib/stdlib/test/error_logger_h_SUITE.erl +++ b/lib/stdlib/test/error_logger_h_SUITE.erl @@ -297,13 +297,13 @@ match_format(Tag, [Format,Args], [Head|Lines], AtNode, Depth) -> iolist_to_binary(S) end, Expected0 = binary:split(Bin, <<"\n">>, [global,trim]), - Expected = Expected0 ++ AtNode, + Expected = AtNode ++ Expected0, match_term_lines(Expected, Lines). match_term(Tag, [Arg], [Head|Lines], AtNode, Depth) -> match_head(Tag, Head), Expected0 = match_term_get_expected(Arg, Depth), - Expected = Expected0 ++ AtNode, + Expected = AtNode ++ Expected0, match_term_lines(Expected, Lines). match_term_get_expected(List, Depth) when is_list(List) -> |