Merge branch 'maint'

4 files changed, 62 insertions, 33 deletions

diff --git a/lib/kernel/doc/src/kernel_app.xml b/lib/kernel/doc/src/kernel_app.xml
index 49a93d2c70..00c6bc33d6 100644
--- a/lib/kernel/doc/src/kernel_app.xml
+++ b/lib/kernel/doc/src/kernel_app.xml
@@ -4,7 +4,7 @@
 <appref>
   <header>
     <copyright>
-      <year>1996</year><year>2013</year>
+      <year>1996</year><year>2014</year>
       <holder>Ericsson AB. All Rights Reserved.</holder>
     </copyright>
     <legalnotice>
@@ -35,7 +35,7 @@
       Erlang/OTP consists of Kernel and STDLIB. The Kernel application
       contains the following services:</p>
     <list type="bulleted">
-      <item>application controller, see <c>application(3)</c></item>
+      <item>application controller, see <seealso marker="application">application(3)</seealso></item>
       <item><c>code</c></item>
       <item><c>disk_log</c></item>
       <item><c>dist_ac</c>, distributed application controller</item>
@@ -66,8 +66,8 @@
   <section>
     <title>Configuration</title>
     <p>The following configuration parameters are defined for the Kernel
-      application. See <c>app(3)</c> for more information about
-      configuration parameters.</p>
+      application. See <seealso marker="app">app(4)</seealso> for more
+      information about configuration parameters.</p>
     <taglist>
       <tag><c>browser_cmd = string() | {M,F,A}</c></tag>
       <item>
@@ -93,7 +93,8 @@
           <item><c>Time = integer()>0</c></item>
           <item><c>Nodes = [node() | {node(),...,node()}]</c></item>
         </list>
-        <p>The parameter is described in <c>application(3)</c>, function
+        <p>The parameter is described in
+	  <seealso marker="application">application(3)</seealso>, function
           <c>load/2</c>.</p>
       </item>
       <tag><c>dist_auto_connect = Value</c></tag>
@@ -105,11 +106,13 @@
         <taglist>
           <tag><c>never</c></tag>
           <item>Connections are never automatically established, they
-           must be explicitly connected. See <c>net_kernel(3)</c>.</item>
+           must be explicitly connected. See
+	   <seealso marker="net_kernel">net_kernel(3)</seealso>.</item>
           <tag><c>once</c></tag>
           <item>Connections will be established automatically, but only
            once per node. If a node goes down, it must thereafter be
-           explicitly connected. See <c>net_kernel(3)</c>.</item>
+           explicitly connected. See
+	   <seealso marker="net_kernel">net_kernel(3)</seealso>.</item>
         </taglist>
       </item>
       <tag><c>permissions = [Perm]</c></tag>
@@ -121,7 +124,8 @@
           <item><c>ApplName = atom()</c></item>
           <item><c>Bool = boolean()</c></item>
         </list>
-        <p>Permissions are described in <c>application(3)</c>, function
+        <p>Permissions are described in
+	  <seealso marker="application">application(3)</seealso>, function
           <c>permit/2</c>.</p>
       </item>
       <tag><c>error_logger = Value</c></tag>
@@ -149,7 +153,8 @@
       </item>
       <tag><c>global_groups = [GroupTuple]</c></tag>
       <item>
-        <p>Defines global groups, see <c>global_group(3)</c>.</p>
+        <p>Defines global groups, see
+	  <seealso marker="global_group">global_group(3)</seealso>.</p>
         <list type="bulleted">
           <item><c>GroupTuple = {GroupName, [Node]} | {GroupName, PublishType, [Node]}</c></item>
           <item><c>GroupName = atom()</c></item>
@@ -160,18 +165,19 @@
       <tag><c>inet_default_connect_options = [{Opt, Val}]</c></tag>
       <item>
         <p>Specifies default options for <c>connect</c> sockets,
-          see <c>inet(3)</c>.</p>
+          see <seealso marker="inet">inet(3)</seealso>.</p>
       </item>
       <tag><c>inet_default_listen_options = [{Opt, Val}]</c></tag>
       <item>
         <p>Specifies default options for <c>listen</c> (and
-          <c>accept</c>) sockets, see <c>inet(3)</c>.</p>
+          <c>accept</c>) sockets, see <seealso marker="inet">inet(3)</seealso>.</p>
       </item>
       <tag><c>{inet_dist_use_interface, ip_address()}</c></tag>
       <item>
         <p>If the host of an Erlang node has several network interfaces,
           this parameter specifies which one to listen on. See
-          <c>inet(3)</c> for the type definition of <c>ip_address()</c>.</p>
+          <seealso marker="inet">inet(3)</seealso> for the type definition
+	  of <c>ip_address()</c>.</p>
       </item>
       <tag><c>{inet_dist_listen_min, First}</c></tag>
       <item>
@@ -276,7 +282,8 @@ MaxT = TickTime + TickTime / 4</code>
       <tag><c>start_boot_server = true | false</c></tag>
       <item>
         <p>Starts the <c>boot_server</c> if the parameter is <c>true</c>
-          (see <c>erl_boot_server(3)</c>).  This parameter should be
+          (see <seealso marker="erl_boot_server">erl_boot_server(3)</seealso>).
+	  This parameter should be
           set to <c>true</c> in an embedded system which uses this
           service.</p>
         <p>The default value is <c>false</c>.</p>
@@ -296,13 +303,15 @@ MaxT = TickTime + TickTime / 4</code>
       <tag><c>start_disk_log = true | false</c></tag>
       <item>
         <p>Starts the <c>disk_log_server</c> if the parameter is
-          <c>true</c> (see <c>disk_log(3)</c>). This parameter should be
+          <c>true</c> (see <seealso marker="disk_log">disk_log(3)</seealso>).
+	  This parameter should be
           set to true in an embedded system which uses this service.</p>
         <p>The default value is <c>false</c>.</p>
       </item>
       <tag><c>start_pg2 = true | false</c></tag>
       <item>
-        <p>Starts the <c>pg2</c> server (see <c>pg2(3)</c>) if
+        <p>Starts the <c>pg2</c> server (see
+	  <seealso marker="pg2">pg2(3)</seealso>) if
           the parameter is <c>true</c>. This parameter should be set to
           <c>true</c> in an embedded system which uses this service.</p>
         <p>The default value is <c>false</c>.</p>
@@ -310,7 +319,8 @@ MaxT = TickTime + TickTime / 4</code>
       <tag><c>start_timer = true | false</c></tag>
       <item>
         <p>Starts the <c>timer_server</c> if the parameter is
-          <c>true</c> (see <c>timer(3)</c>). This parameter should be
+          <c>true</c> (see <seealso marker="stdlib:timer">timer(3)</seealso>).
+	  This parameter should be
           set to <c>true</c> in an embedded system which uses this
           service.</p>
         <p>The default value is <c>false</c>.</p>
@@ -351,6 +361,7 @@ MaxT = TickTime + TickTime / 4</code>
       <seealso marker="pg2">pg2(3)</seealso>, 
       <seealso marker="rpc">rpc(3)</seealso>, 
       <seealso marker="seq_trace">seq_trace(3)</seealso>, 
+      <seealso marker="stdlib:timer">timer(3)</seealso>,
       <seealso marker="user">user(3)</seealso></p>
   </section>
 </appref>
diff --git a/lib/kernel/src/application_controller.erl b/lib/kernel/src/application_controller.erl
index ed13035104..daad45b6c2 100644
--- a/lib/kernel/src/application_controller.erl
+++ b/lib/kernel/src/application_controller.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1996-2013. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2014. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -829,12 +829,12 @@ handle_call({change_application_data, Applications, Config}, _From, S) ->
 	    {reply, Error, S};
 	{'EXIT', R} ->
 	    {reply, {error, R}, S};
-	NewAppls ->
+	{NewAppls, NewConfig} ->
 	    lists:foreach(fun(Appl) ->
 				  ets:insert(ac_tab, {{loaded, Appl#appl.name},
 						      Appl})
 			  end, NewAppls),
-	    {reply, ok, S#state{conf_data = Config}}
+	    {reply, ok, S#state{conf_data = NewConfig}}
     end;
 
 handle_call(prep_config_change, _From, S) ->
@@ -1550,18 +1550,19 @@ do_change_apps(Applications, Config, OldAppls) ->
 		  end,
 		  Errors),
 
-    map(fun(Appl) ->
-		AppName = Appl#appl.name,
-		case is_loaded_app(AppName, Applications) of
-		    {true, Application} ->
-			do_change_appl(make_appl(Application),
-				       Appl, SysConfig);
-
-		    %% ignored removed apps - handled elsewhere
-		    false ->
-			Appl
-		end
-	end, OldAppls).
+    {map(fun(Appl) ->
+		 AppName = Appl#appl.name,
+		 case is_loaded_app(AppName, Applications) of
+		     {true, Application} ->
+			 do_change_appl(make_appl(Application),
+					Appl, SysConfig);
+
+		     %% ignored removed apps - handled elsewhere
+		     false ->
+			 Appl
+		 end
+	 end, OldAppls),
+     SysConfig}.
 
 is_loaded_app(AppName, [{application, AppName, App} | _]) ->
     {true, {application, AppName, App}};
diff --git a/lib/kernel/test/application_SUITE.erl b/lib/kernel/test/application_SUITE.erl
index c6cbd1a0ef..036e238c85 100644
--- a/lib/kernel/test/application_SUITE.erl
+++ b/lib/kernel/test/application_SUITE.erl
@@ -1949,14 +1949,22 @@ config_change(Conf) when is_list(Conf) ->
     %% Find out application data from boot script
     Boot = filename:join([code:root_dir(), "bin", "start.boot"]),
     {ok, Bin} = file:read_file(Boot),
-    Appls = get_appls(binary_to_term(Bin)),
+    Appls0 = get_appls(binary_to_term(Bin)),
+
+    %% And add app1 in order to test OTP-11864 - included config files
+    %% not read for new (not already loaded) applications
+    Appls = [app1() | Appls0],
 
     %% Simulate contents of "sys.config"
     Config = [{stdlib, [{par1,sys},{par2,sys}]},
 		    "t1",
 		    "t2.config",
 		    filename:join([DataDir, "subdir", "t3"]),
-		    {stdlib, [{par6,sys}]}],
+		    {stdlib, [{par6,sys}]},
+	            "t4.config"],
+
+    %% Check that app1 is not loaded
+    false = lists:keymember(app1,1,application:loaded_applications()),
 
     %% Order application_controller to update configuration
     ok = application_controller:change_application_data(Appls,
@@ -1971,6 +1979,13 @@ config_change(Conf) when is_list(Conf) ->
     {value, {par5,t3}}  = lists:keysearch(par5, 1, Env),
     {value, {par6,sys}} = lists:keysearch(par6, 1, Env),
 
+    %% Check that app1 parameters are correctly set after loading
+    [] = application:get_all_env(app1),
+    application:load(app1()),
+    App1Env = application:get_all_env(app1),
+    {value, {par1,t4}} = lists:keysearch(par1, 1, App1Env),
+    application:unload(app1),
+
     ok = file:set_cwd(CWD).
 
 %% This function is stolen from SASL module release_handler, OTP R10B
@@ -1989,6 +2004,7 @@ get_appls([_ | T], Res) ->
 get_appls([], Res) ->
     Res.
 
+
 persistent_env(suite) ->
     [];
 persistent_env(doc) ->
diff --git a/lib/kernel/test/application_SUITE_data/t4.config b/lib/kernel/test/application_SUITE_data/t4.config
new file mode 100644
index 0000000000..8b2bc52c01
--- /dev/null
+++ b/lib/kernel/test/application_SUITE_data/t4.config
@@ -0,0 +1 @@
+[{app1, [{par1,t4}]}].
\ No newline at end of file