Improve ct_snmp test cases

4 files changed, 42 insertions, 11 deletions

diff --git a/lib/common_test/test/ct_snmp_SUITE_data/snmp.cfg b/lib/common_test/test/ct_snmp_SUITE_data/snmp.cfg
index 895e097de6..7ff356e49a 100644
--- a/lib/common_test/test/ct_snmp_SUITE_data/snmp.cfg
+++ b/lib/common_test/test/ct_snmp_SUITE_data/snmp.cfg
@@ -22,23 +22,23 @@
 	 {agent_target_param_def,{data_dir_file,"target_params.conf"}},
 	 {agent_vacm,{data_dir_file,"vacm.conf"}}]}.
 {snmp_app1,[{manager, [{config, [{verbosity, silence}]},
-		       {server,[{verbosity,silence}]},
-		       {net_if,[{verbosity,silence}]},
+		       {server,[{verbosity,log}]},
+		       {net_if,[{verbosity,log}]},
 		       {versions,[v2]}
 		      ]},
 	    {agent, [{config, [{verbosity, silence}]},
-		     {net_if,[{verbosity,silence}]},
+		     {net_if,[{verbosity,log}]},
 		     {mib_server,[{verbosity,silence}]},
 		     {local_db,[{verbosity,silence}]},
-		     {agent_verbosity,silence}
+		     {agent_verbosity,log}
 		    ]}]}.
 {snmp_app2,[{manager, [{config, [{verbosity, silence}]},
-		       {server,[{verbosity,silence}]},
-		       {net_if,[{verbosity,silence}]}
+		       {server,[{verbosity,log}]},
+		       {net_if,[{verbosity,log}]}
 		      ]},
 	    {agent, [{config, [{verbosity, silence}]},
-		     {net_if,[{verbosity,silence}]},
+		     {net_if,[{verbosity,log}]},
 		     {mib_server,[{verbosity,silence}]},
 		     {local_db,[{verbosity,silence}]},
-		     {agent_verbosity,silence}
+		     {agent_verbosity,log}
 		    ]}]}.
diff --git a/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE.erl b/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE.erl
index 16b2b5690c..e20832e1e7 100644
--- a/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE.erl
+++ b/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE.erl
@@ -1,7 +1,7 @@
 %%--------------------------------------------------------------------
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2012. All Rights Reserved.
+%% Copyright Ericsson AB 2012-2014. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -288,6 +288,9 @@ override_usm(Config) ->
     %% Check that usm.conf is overwritten
     {ok,MyUsm} = snmpa_conf:read_usm_config(DataDir),
     {ok,UsedUsm} = snmpa_conf:read_usm_config(ConfDir),
+    ct:pal(
+      "MyUsm = ~p~nUsedUsm = ~p",
+      [MyUsm, UsedUsm]),
     true = (MyUsm == UsedUsm),
 
     %% Check that the usm user is actually configured...
@@ -304,6 +307,9 @@ override_standard(Config) ->
     %% Check that standard.conf is overwritten
     {ok,MyStandard} = snmpa_conf:read_standard_config(DataDir),
     {ok,UsedStandard} = snmpa_conf:read_standard_config(ConfDir),
+    ct:pal(
+      "MyStandard = ~p~nUsedStandard = ~p",
+      [MyStandard, UsedStandard]),
     true = (MyStandard == UsedStandard),
 
     %% Check that the values from standard.conf is actually configured...
@@ -319,6 +325,9 @@ override_context(Config) ->
     %% Check that context.conf is overwritten
     {ok,MyContext} = snmpa_conf:read_context_config(DataDir),
     {ok,UsedContext} = snmpa_conf:read_context_config(ConfDir),
+    ct:pal(
+      "MyContext = ~p~nUsedContext = ~p",
+      [MyContext, UsedContext]),
     true = (MyContext == UsedContext),
     ok.
 
@@ -330,6 +339,9 @@ override_community(Config) ->
     %% Check that community.conf is overwritten
     {ok,MyCommunity} = snmpa_conf:read_community_config(DataDir),
     {ok,UsedCommunity} = snmpa_conf:read_community_config(ConfDir),
+    ct:pal(
+      "MyCommunity = ~p~nUsedCommunity = ~p",
+      [MyCommunity, UsedCommunity]),
     true = (MyCommunity == UsedCommunity),
     ok.
 
@@ -341,6 +353,9 @@ override_notify(Config) ->
     %% Check that notify.conf is overwritten
     {ok,MyNotify} = snmpa_conf:read_notify_config(DataDir),
     {ok,UsedNotify} = snmpa_conf:read_notify_config(ConfDir),
+    ct:pal(
+      "MyNotify = ~p~nUsedNotify = ~p",
+      [MyNotify, UsedNotify]),
     true = (MyNotify == UsedNotify),
     ok.
 
@@ -352,6 +367,9 @@ override_target_addr(Config) ->
     %% Check that target_addr.conf is overwritten
     {ok,MyTargetAddr} = snmpa_conf:read_target_addr_config(DataDir),
     {ok,UsedTargetAddr} = snmpa_conf:read_target_addr_config(ConfDir),
+    ct:pal(
+      "MyTargetAddr = ~p~nUsedTargetAddr = ~p",
+      [MyTargetAddr, UsedTargetAddr]),
     true = (MyTargetAddr == UsedTargetAddr),
     ok.
 
@@ -363,6 +381,9 @@ override_target_params(Config) ->
     %% Check that target_params.conf is overwritten
     {ok,MyTargetParams} = snmpa_conf:read_target_params_config(DataDir),
     {ok,UsedTargetParams} = snmpa_conf:read_target_params_config(ConfDir),
+    ct:pal(
+      "MyTargetParams = ~p~nUsedTargetParams = ~p",
+      [MyTargetParams, UsedTargetParams]),
     true = (MyTargetParams == UsedTargetParams),
     ok.
 
@@ -374,6 +395,9 @@ override_vacm(Config) ->
     %% Check that vacm.conf is overwritten
     {ok,MyVacm} = snmpa_conf:read_vacm_config(DataDir),
     {ok,UsedVacm} = snmpa_conf:read_vacm_config(ConfDir),
+    ct:pal(
+      "MyVacm = ~p~nUsedVacm = ~p",
+      [MyVacm, UsedVacm]),
     true = (MyVacm == UsedVacm),
     ok.
 
diff --git a/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE_data/target_addr.conf b/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE_data/target_addr.conf
index d02672a074..d3ce2fa60e 100644
--- a/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE_data/target_addr.conf
+++ b/lib/common_test/test/ct_snmp_SUITE_data/snmp_SUITE_data/target_addr.conf
@@ -1,2 +1,2 @@
-{"target1", snmpUDPDomain, [147,214,122,73], 5000, 1500, 3, "std_trap", "target_v3", "", [], 2048}.
-{"target2", snmpUDPDomain, [147,214,122,73], 5000, 1500, 3, "std_inform", "target_v3", "", [], 2048}.
+{"target1", snmpUDPDomain, {[147,214,122,73], 5000}, 1500, 3, "std_trap", "target_v3", "", [], 2048}.
+{"target2", snmpUDPDomain, {[147,214,122,73], 5000}, 1500, 3, "std_inform", "target_v3", "", [], 2048}.
diff --git a/lib/snmp/src/agent/snmp_community_mib.erl b/lib/snmp/src/agent/snmp_community_mib.erl
index 12a0ec97c2..4546c343b7 100644
--- a/lib/snmp/src/agent/snmp_community_mib.erl
+++ b/lib/snmp/src/agent/snmp_community_mib.erl
@@ -246,6 +246,10 @@ gc_tabs() ->
 %%-----------------------------------------------------------------
 community2vacm(Community, Addr) ->
     Idxs = ets:lookup(snmp_community_cache, Community),
+    ?vtrace("community2vacm ->~n"
+	    "  Community: ~p~n"
+	    "  Addr:      ~p~n"
+	    "  Idxs:      ~p", [Community, Addr, Idxs]),
     loop_c2v_rows(lists:keysort(2, Idxs), Addr).
 
 loop_c2v_rows([{_, CommunityIndex} | T], Addr) ->
@@ -253,6 +257,9 @@ loop_c2v_rows([{_, CommunityIndex} | T], Addr) ->
 	    "~n   CommunityIndex: ~p", [CommunityIndex]),
     case get_row(CommunityIndex) of
 	{_Community, VacmParams, Tag} ->
+	    ?vtrace("loop_c2v_rows ->~n"
+		    "  VacmParams: ~p~n"
+		    "  Tag:        ~p", [VacmParams, Tag]),
 	    {TDomain, TAddr} = Addr,
 	    case snmp_target_mib:is_valid_tag(Tag, TDomain, TAddr) of
 		true ->