diff options
| author | Ingela Anderton Andin <[email protected]> | 2017-10-10 18:19:23 +0200 |
|---|---|---|
| committer | Ingela Anderton Andin <[email protected]> | 2017-11-01 10:54:20 +0100 |
| commit | 425b826e7fefe3bd4b174adfb8ead5953dd5dadf (patch) | |
| tree | 9be47243b1e1c2b7707f5ec9ef567daadaac1789 | |
| parent | 2cc5ba70cbbc6b3ace81a2a0324417c3b65265bb (diff) | |
| download | otp-425b826e7fefe3bd4b174adfb8ead5953dd5dadf.tar.gz otp-425b826e7fefe3bd4b174adfb8ead5953dd5dadf.tar.bz2 otp-425b826e7fefe3bd4b174adfb8ead5953dd5dadf.zip | |
inets: Make sure httpd:stop_service is synchronous
| -rw-r--r-- | lib/inets/src/http_server/httpd.erl | 9 | ||||
| -rw-r--r-- | lib/inets/test/inets_SUITE.erl | 2 |
2 files changed, 8 insertions, 3 deletions
diff --git a/lib/inets/src/http_server/httpd.erl b/lib/inets/src/http_server/httpd.erl index 0b632d24e3..540e68e749 100644 --- a/lib/inets/src/http_server/httpd.erl +++ b/lib/inets/src/http_server/httpd.erl @@ -99,7 +99,14 @@ start_service(Conf) -> stop_service({Address, Port}) -> stop_service({Address, Port, ?DEFAULT_PROFILE}); stop_service({Address, Port, Profile}) -> - httpd_sup:stop_child(Address, Port, Profile); + Name = httpd_util:make_name("httpd_instance_sup", Address, Port, Profile), + Pid = whereis(Name), + MonitorRef = erlang:monitor(process, Pid), + Result = httpd_sup:stop_child(Address, Port, Profile), + receive + {'DOWN', MonitorRef, _, _, _} -> + Result + end; stop_service(Pid) when is_pid(Pid) -> case service_info(Pid) of {ok, Info} -> diff --git a/lib/inets/test/inets_SUITE.erl b/lib/inets/test/inets_SUITE.erl index 38b8229389..1abd96a228 100644 --- a/lib/inets/test/inets_SUITE.erl +++ b/lib/inets/test/inets_SUITE.erl @@ -213,7 +213,6 @@ start_httpd(Config) when is_list(Config) -> true = lists:member(Pid0, Pids0), [_|_] = inets:services_info(), inets:stop(httpd, Pid0), - ct:sleep(500), Pids1 = [ServicePid || {_, ServicePid} <- inets:services()], false = lists:member(Pid0, Pids1), {ok, Pid0b} = @@ -222,7 +221,6 @@ start_httpd(Config) when is_list(Config) -> true = lists:member(Pid0b, Pids0b), [_|_] = inets:services_info(), inets:stop(httpd, Pid0b), - ct:sleep(500), Pids1 = [ServicePid || {_, ServicePid} <- inets:services()], false = lists:member(Pid0b, Pids1), {ok, Pid1} = |