diff options
author | Björn Gustavsson <[email protected]> | 2016-01-22 16:10:34 +0100 |
---|---|---|
committer | Björn Gustavsson <[email protected]> | 2016-01-22 16:44:32 +0100 |
commit | b219b9c52ec30d13b2e8eaf246247edb965aac6e (patch) | |
tree | e17b33c05b192cefee14352991933ade39ece6eb | |
parent | 168b7456a249b7f6ea2955059786619968829e4f (diff) | |
download | otp-b219b9c52ec30d13b2e8eaf246247edb965aac6e.tar.gz otp-b219b9c52ec30d13b2e8eaf246247edb965aac6e.tar.bz2 otp-b219b9c52ec30d13b2e8eaf246247edb965aac6e.zip |
Remove redundant test that hipe_unified_loader is loaded
For some reason, there is a test in code_server that
hipe_unified_loader is loaded before trying to call it. The test was
added in R9B, but it is not clear why. Before starting the code
server, the 'code' module would always load hipe_unified_loader;
thus there is now way that the test can ever fail.
-rw-r--r-- | lib/kernel/src/code_server.erl | 25 |
1 files changed, 3 insertions, 22 deletions
diff --git a/lib/kernel/src/code_server.erl b/lib/kernel/src/code_server.erl index ceb3507f17..3fbbb98b94 100644 --- a/lib/kernel/src/code_server.erl +++ b/lib/kernel/src/code_server.erl @@ -1113,9 +1113,10 @@ try_load_module_2(File, Mod, Bin, Caller, undefined, St) -> try_load_module_3(File, Mod, Bin, Caller, undefined, St); try_load_module_2(File, Mod, Bin, Caller, Architecture, #state{moddb=Db}=St) -> - case catch load_native_code(Mod, Bin, Architecture) of + case catch hipe_unified_loader:load_native_code(Mod, Bin, Architecture) of {module,Mod} = Module -> - ets:insert(Db, {Mod,File}), + put(?ANY_NATIVE_CODE_LOADED, true), + ets:insert(Db, {Mod,File}), {reply,Module,St}; no_native -> try_load_module_3(File, Mod, Bin, Caller, Architecture, St); @@ -1138,26 +1139,6 @@ try_load_module_3(File, Mod, Bin, Caller, Architecture, {reply,Error,St} end. -load_native_code(Mod, Bin, Architecture) -> - %% During bootstrapping of Open Source Erlang, we don't have any hipe - %% loader modules, but the Erlang emulator might be hipe enabled. - %% Therefore we must test for that the loader modules are available - %% before trying to to load native code. - case erlang:module_loaded(hipe_unified_loader) of - false -> - no_native; - true -> - Result = hipe_unified_loader:load_native_code(Mod, Bin, - Architecture), - case Result of - {module,_} -> - put(?ANY_NATIVE_CODE_LOADED, true); - _ -> - ok - end, - Result - end. - hipe_result_to_status(Result) -> case Result of {module,_} -> |