Clean up some config warts

6 files changed, 103 insertions, 39 deletions

diff --git a/lib/snmp/src/agent/snmp_framework_mib.erl b/lib/snmp/src/agent/snmp_framework_mib.erl
index 9d3f7ef5e7..6ff9224d34 100644
--- a/lib/snmp/src/agent/snmp_framework_mib.erl
+++ b/lib/snmp/src/agent/snmp_framework_mib.erl
@@ -207,22 +207,28 @@ check_agent({intAgentIpAddress = Tag, Ip} = Entry, {Domain, Port} = State) ->
 	     [{Tag, FixedIp},
 	      {intAgentTransports, [{Domain, {FixedIp, Port}}]}]
      end, State};
-check_agent({intAgentTransports = Tag, Transports}, {_, Port} = State) ->
+check_agent({intAgentTransports = Tag, Transports}, {_, Port} = State)
+  when is_list(Transports) ->
     CheckedTransports =
-	[case
-	     case Port of
-		 undefined ->
-		     snmp_conf:check_address(Domain, Address);
-		 _ ->
-		     snmp_conf:check_address(Domain, Address, Port)
-	     end
-	 of
-	     ok ->
-		 Transport;
-	     {ok, FixedAddress} ->
-		 {Domain, FixedAddress}
+	[case Transport of
+	     {Domain, Address} ->
+		 case
+		     case Port of
+			 undefined ->
+			     snmp_conf:check_address(Domain, Address);
+			 _ ->
+			     snmp_conf:check_address(Domain, Address, Port)
+		     end
+		 of
+		     ok ->
+			 Transport;
+		     {ok, FixedAddress} ->
+			 {Domain, FixedAddress}
+		 end;
+	     _ ->
+		 error({bad_transport, Transport})
 	 end
-	 || {Domain, Address} = Transport <- Transports],
+	 || Transport <- Transports],
     {{ok, {Tag, CheckedTransports}}, State};
 check_agent(Entry, State) ->
     {check_agent(Entry), State}.
diff --git a/lib/snmp/src/agent/snmp_target_mib.erl b/lib/snmp/src/agent/snmp_target_mib.erl
index df694ed16b..ef9503cda8 100644
--- a/lib/snmp/src/agent/snmp_target_mib.erl
+++ b/lib/snmp/src/agent/snmp_target_mib.erl
@@ -306,7 +306,7 @@ check_engine_id(EngineId) ->
     snmp_conf:check_string(EngineId).
 
 check_address(Domain, Address) ->
-    case snmp_conf:check_address(Domain, Address) of
+    case snmp_conf:check_address(Domain, Address, 162) of
 	ok ->
 	    Address;
 	{ok, NAddress} ->
@@ -316,7 +316,11 @@ check_address(Domain, Address) ->
 check_mask(_Domain, [] = Mask) ->
     Mask;
 check_mask(Domain, Mask) ->
-    try check_address(Domain, Mask)
+    try snmp_conf:check_address(Domain, Mask) of
+	ok ->
+	    Mask;
+	{ok, NMask} ->
+	    NMask
     catch
 	{error, {bad_address, Info}} ->
 	    error({bad_mask, Info})
@@ -380,16 +384,21 @@ table_del_row(Tab, Key) ->
     snmpa_mib_lib:table_del_row(db(Tab), Key).
 
 
-add_addr(Name, Ip, Port, Timeout, Retry, TagList, 
-	 Params, EngineId, TMask, MMS) ->
-    Domain = default_domain(), 
-    add_addr(Name, Domain, Ip, Port, Timeout, Retry, TagList, 
-	     Params, EngineId, TMask, MMS).
-
-add_addr(Name, Domain, Ip, Port, Timeout, Retry, TagList, 
-	 Params, EngineId, TMask, MMS) ->
-    Addr = {Name, Domain, Ip, Port, Timeout, Retry, TagList, 
-	    Params, EngineId, TMask, MMS},
+add_addr(
+  Name, Domain_or_Ip, Addr_or_Port, Timeout, Retry, TagList, Params,
+  EngineId, TMask, MMS) ->
+    add_addr(
+      {Name, Domain_or_Ip, Addr_or_Port, Timeout, Retry, TagList, Params,
+       EngineId, TMask, MMS}).
+%%
+add_addr(
+  Name, Domain, Ip, Port, Timeout, Retry, TagList, Params,
+  EngineId, TMask, MMS) ->
+    add_addr(
+      {Name, Domain, Ip, Port, Timeout, Retry, TagList, Params,
+       EngineId, TMask, MMS}).
+%%
+add_addr(Addr) ->
     case (catch check_target_addr(Addr)) of
 	{ok, Row} ->
 	    Key = element(1, Row),
diff --git a/lib/snmp/src/agent/snmpa_conf.erl b/lib/snmp/src/agent/snmpa_conf.erl
index fe3f63c4ca..534d0e447b 100644
--- a/lib/snmp/src/agent/snmpa_conf.erl
+++ b/lib/snmp/src/agent/snmpa_conf.erl
@@ -47,7 +47,7 @@
 	 read_standard_config/1, 
 
 	 %% target_addr.conf
-	 target_addr_entry/5, target_addr_entry/6, 
+	 target_addr_entry/5, target_addr_entry/6,  target_addr_entry/7,
 	 target_addr_entry/8, target_addr_entry/10, target_addr_entry/11, 
 	 write_target_addr_config/2, write_target_addr_config/3, 
 	 append_target_addr_config/2, 
@@ -386,6 +386,12 @@ target_addr_entry(
     target_addr_entry(Name, Ip, TagList, ParamsName, EngineId, []).
 
 target_addr_entry(
+  Name, Domain, Addr, TagList,
+  ParamsName, EngineId) when is_atom(Domain) ->
+    target_addr_entry(
+      Name, Domain, Addr, TagList,
+      ParamsName, EngineId, []);
+target_addr_entry(
   Name, Ip, TagList, ParamsName,
   EngineId, TMask) ->
     target_addr_entry(
@@ -394,6 +400,13 @@ target_addr_entry(
 
 target_addr_entry(
   Name, Domain_or_Ip, Addr_or_Port, TagList,
+  ParamsName, EngineId, TMask) ->
+    target_addr_entry(
+      Name, Domain_or_Ip, Addr_or_Port, TagList,
+      ParamsName, EngineId, TMask, 2048).
+
+target_addr_entry(
+  Name, Domain_or_Ip, Addr_or_Port, TagList,
   ParamsName, EngineId, TMask, MaxMessageSize) ->
     target_addr_entry(
       Name, Domain_or_Ip, Addr_or_Port, 1500, 3, TagList,
diff --git a/lib/snmp/src/manager/snmpm_conf.erl b/lib/snmp/src/manager/snmpm_conf.erl
index e03d28a3e4..087ef6c6ea 100644
--- a/lib/snmp/src/manager/snmpm_conf.erl
+++ b/lib/snmp/src/manager/snmpm_conf.erl
@@ -200,9 +200,10 @@ do_write_users_conf(_Fd, Crap) ->
 %% ------ agents.conf ------
 %% 
 
-agents_entry(UserId, TargetName, Comm, Ip, Port, EngineID, Timeout, 
-	     MaxMessageSize, Version, SecModel, SecName, SecLevel) ->
-    {UserId, TargetName, Comm, Ip, Port, EngineID, Timeout, 
+agents_entry(
+  UserId, TargetName, Comm, Domain_or_Ip, Addr_or_Port, EngineID, Timeout,
+  MaxMessageSize, Version, SecModel, SecName, SecLevel) ->
+    {UserId, TargetName, Comm, Domain_or_Ip, Addr_or_Port, EngineID, Timeout,
      MaxMessageSize, Version, SecModel, SecName, SecLevel}.
 
 
diff --git a/lib/snmp/src/manager/snmpm_config.erl b/lib/snmp/src/manager/snmpm_config.erl
index 05d5ce72b1..940800fed4 100644
--- a/lib/snmp/src/manager/snmpm_config.erl
+++ b/lib/snmp/src/manager/snmpm_config.erl
@@ -1816,7 +1816,11 @@ verify_agent_config(
 		{TD, VerifiedConf};
 	    _ ->
 		%% Insert tdomain since it is missing
-		TD = default_transport_domain(),
+		%% Note: not default_transport_domain() since
+		%% taddress is the new format hence the application
+		%% should be tdomain aware and therefore addresses
+		%% on the Domain, Addr format should be used and understood.
+		TD = transportDomainUdpIpv4,
 		{TD, [{tdomain, TD}|VerifiedConf]}
 	end,
     case snmp_conf:check_address(TDomain, Address, 0) of
@@ -2269,15 +2273,37 @@ check_manager_config({address = Tag, Ip} = Entry, {Domain, Port} = State) ->
 	     [{Tag, FixedIp},
 	      {transports, [{Domain, {FixedIp, Port}}]}]
      end, State};
-check_manager_config({transports = Tag, Transports}, State) ->
+check_manager_config({transports = Tag, Transports}, {_, Port} = State)
+  when is_list(Transports) ->
     CheckedTransports =
-	[case snmp_conf:check_address(Domain, Address) of
-	     ok ->
-		 Transport;
-	     {ok, FixedAddress} ->
-		 {Domain, FixedAddress}
+	[case Transport of
+	     {Domain, Address} ->
+		 case
+		     case Port of
+			 undefined ->
+			     snmp_conf:check_address(Domain, Address);
+			 _ ->
+			     snmp_conf:check_address(Domain, Address, Port)
+		     end
+		 of
+		     ok ->
+			 Transport;
+		     {ok, FixedAddress} ->
+			 {Domain, FixedAddress}
+		 end;
+	     _Domain when Port =:= undefined->
+		 error({missing_mandatory, port});
+	     Domain ->
+		 Family = snmp_conf:tdomain_to_family(Domain),
+		 {ok, Hostname} = inet:gethostname(),
+		 case inet:getaddr(Hostname, Family) of
+		     {ok, IpAddr} ->
+			 {Domain, {IpAddr, Port}};
+		     {error, _} ->
+			 error({bad_address, {Domain, Hostname}})
+		 end
 	 end
-	 || {Domain, Address} = Transport <- Transports],
+	 || Transport <- Transports],
     {{ok, {Tag, CheckedTransports}}, State};
 check_manager_config(Entry, State) ->
     {check_manager_config(Entry), State}.
diff --git a/lib/snmp/src/manager/snmpm_server.erl b/lib/snmp/src/manager/snmpm_server.erl
index ece5dad082..a75122d0bb 100644
--- a/lib/snmp/src/manager/snmpm_server.erl
+++ b/lib/snmp/src/manager/snmpm_server.erl
@@ -2079,7 +2079,16 @@ do_handle_agent(DefUserId, DefMod,
 		SnmpInfo, DefData, State) ->
     ?vdebug("do_handle_agent -> entry when"
 	    "~n   DefUserId: ~p", [DefUserId]),
-    try DefMod:handle_agent(Domain, Addr, Type, SnmpInfo, DefData) of
+    {Domain_or_Ip, Addr_or_Port} =
+	case Domain of
+	    snmpUDPDomain ->
+		Addr;
+	    _ ->
+		{Domain, Addr}
+	end,
+    try DefMod:handle_agent(
+	  Domain_or_Ip, Addr_or_Port, Type, SnmpInfo, DefData)
+    of
 	{register, UserId2, TargetName, Config} ->  
 	    ?vtrace("do_handle_agent -> register: "
 		    "~n   UserId2:    ~p"