aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnders Svensson <[email protected]>2017-09-15 15:46:57 +0200
committerAnders Svensson <[email protected]>2017-09-15 16:04:52 +0200
commit8133161bc0e6c05471cfc34ba904afcc7baeac10 (patch)
treed8f54c174fb918ad31f01753916f5d44faa1159e
parent97d9651c856960cf1ff62bded434efcc384a1f77 (diff)
downloadotp-8133161bc0e6c05471cfc34ba904afcc7baeac10.tar.gz
otp-8133161bc0e6c05471cfc34ba904afcc7baeac10.tar.bz2
otp-8133161bc0e6c05471cfc34ba904afcc7baeac10.zip
Fix append of Route-Record AVPs
Commit b3d9e0c0 did away with the reordering of diameter_avp lists, so prepending the AVP to the list means prepending it in the message, which is not what the RFC requires. Appending to a list isn't ideal, but right now there's no better way.
-rw-r--r--lib/diameter/src/base/diameter_traffic.erl2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/diameter/src/base/diameter_traffic.erl b/lib/diameter/src/base/diameter_traffic.erl
index 27a41d6eb0..bb8bd84faf 100644
--- a/lib/diameter/src/base/diameter_traffic.erl
+++ b/lib/diameter/src/base/diameter_traffic.erl
@@ -679,7 +679,7 @@ resend(false,
Route = #diameter_avp{data = {Dict0, 'Route-Record', OH}},
Seq = diameter_session:sequence(Mask),
Hdr = Hdr0#diameter_header{hop_by_hop_id = Seq},
- Msg = [Hdr, Route | Avps], %% reordered at encode
+ Msg = [Hdr | Avps ++ [Route]],
case send_request(SvcName, App, Msg, Opts) of
#diameter_packet{} = Ans ->
Ans;