beam_validator: Clean up updating of types for y register

set_type_y/3 is far too complicated. Note that we don't need to check
the #st.numy field, because we will detect the error anyway because
the information for the y register will be missing in the #st.y
gb_tree.

There is also a clause that would never match because of a spelling
error (the first "n" was missing in "uninitialized"). That clause
is not needed because the default clause will do fine.

Furthermore, we can break out the special case for handling catch_end
and similar instructions into a new function.

3 files changed, 45 insertions, 57 deletions

diff --git a/lib/compiler/src/beam_validator.erl b/lib/compiler/src/beam_validator.erl
index c758a6095a..ce6cd60ab1 100644
--- a/lib/compiler/src/beam_validator.erl
+++ b/lib/compiler/src/beam_validator.erl
@@ -411,37 +411,33 @@ valfun_1({'try',Dst,{f,Fail}}, Vst0) ->
     Vst = #vst{current=#st{ct=Fails}=St} = 
 	set_type_y({trytag,[Fail]}, Dst, Vst0),
     Vst#vst{current=St#st{ct=[[Fail]|Fails]}};
-valfun_1({catch_end,Reg}, #vst{current=#st{ct=[Fail|Fails]}=St0}=Vst0) ->
+valfun_1({catch_end,Reg}, #vst{current=#st{ct=[Fail|Fails]}}=Vst0) ->
     case get_special_y_type(Reg, Vst0) of
 	{catchtag,Fail} ->
-	    Vst = #vst{current=St} = 
-		set_type_y(initialized_ct, Reg, 
-			   Vst0#vst{current=St0#st{ct=Fails}}),
+	    Vst = #vst{current=St} = set_catch_end(Reg, Vst0),
 	    Xs = gb_trees_from_list([{0,term}]),
-	    Vst#vst{current=St#st{x=Xs,fls=undefined}};
+	    Vst#vst{current=St#st{x=Xs,ct=Fails,fls=undefined}};
 	Type ->
 	    error({bad_type,Type})
     end;
-valfun_1({try_end,Reg}, #vst{current=#st{ct=[Fail|Fails]}=St}=Vst0) ->
+valfun_1({try_end,Reg}, #vst{current=#st{ct=[Fail|Fails]}=St0}=Vst0) ->
     case get_special_y_type(Reg, Vst0) of
 	{trytag,Fail} ->
 	    Vst = case Fail of
 		      [FailLabel] -> branch_state(FailLabel, Vst0);
 		      _ -> Vst0
 		  end,
-	    set_type_reg(initialized_ct, Reg, 
-			 Vst#vst{current=St#st{ct=Fails,fls=undefined}});
+	    St = St0#st{ct=Fails,fls=undefined},
+	    set_catch_end(Reg, Vst#vst{current=St});
 	Type ->
 	    error({bad_type,Type})
     end;
-valfun_1({try_case,Reg}, #vst{current=#st{ct=[Fail|Fails]}=St0}=Vst0) ->
+valfun_1({try_case,Reg}, #vst{current=#st{ct=[Fail|Fails]}}=Vst0) ->
     case get_special_y_type(Reg, Vst0) of
 	{trytag,Fail} ->
-	    Vst = #vst{current=St} = 
-		set_type_y(initialized_ct, Reg, 
-			   Vst0#vst{current=St0#st{ct=Fails}}),
-	    Xs = gb_trees_from_list([{0,{atom,[]}},{1,term},{2,term}]), %XXX
-	    Vst#vst{current=St#st{x=Xs,fls=undefined}};
+	    Vst = #vst{current=St} = set_catch_end(Reg, Vst0),
+	    Xs = gb_trees_from_list([{0,{atom,[]}},{1,term},{2,term}]),
+	    Vst#vst{current=St#st{x=Xs,ct=Fails,fls=undefined}};
 	Type ->
 	    error({bad_type,Type})
     end;
@@ -1135,35 +1131,26 @@ set_type_reg(Type, {x,X}, #vst{current=#st{x=Xs}=St}=Vst)
 set_type_reg(Type, Reg, Vst) ->
     set_type_y(Type, Reg, Vst).
 
-set_type_y(Type, {y,Y}=Reg, #vst{current=#st{y=Ys0,numy=NumY}=St}=Vst) 
+set_type_y(Type, {y,Y}=Reg, #vst{current=#st{y=Ys0}=St}=Vst)
   when is_integer(Y), 0 =< Y ->
     limit_check(Y),
-    case {Y,NumY} of
-	{_,none} ->
-	    error({no_stack_frame,Reg});
-	{_,_} when Y > NumY ->
-	    error({y_reg_out_of_range,Reg,NumY});
-	{_,_} ->
-	    Ys = if  Type =:= initialized_ct ->
-			 gb_trees:enter(Y, initialized, Ys0);
-		     true ->
-			 case gb_trees:lookup(Y, Ys0) of
-			     none -> 
-				 gb_trees:insert(Y, Type, Ys0);
-			     {value,uinitialized} ->
-				 gb_trees:insert(Y, Type, Ys0);
-			     {value,{catchtag,_}=Tag} ->
-				 error(Tag);
-			     {value,{trytag,_}=Tag} ->
-				 error(Tag);
-			     {value,_} ->
-				 gb_trees:update(Y, Type, Ys0)
-			 end
-		 end,
-	    Vst#vst{current=St#st{y=Ys}}
-    end;
+    Ys = case gb_trees:lookup(Y, Ys0) of
+	     none ->
+		 error({invalid_store,Reg,Type});
+	     {value,{catchtag,_}=Tag} ->
+		 error(Tag);
+	     {value,{trytag,_}=Tag} ->
+		 error(Tag);
+	     {value,_} ->
+		 gb_trees:update(Y, Type, Ys0)
+	 end,
+    Vst#vst{current=St#st{y=Ys}};
 set_type_y(Type, Reg, #vst{}) -> error({invalid_store,Reg,Type}).
 
+set_catch_end({y,Y}, #vst{current=#st{y=Ys0}=St}=Vst) ->
+    Ys = gb_trees:update(Y, initialized, Ys0),
+    Vst#vst{current=St#st{y=Ys}}.
+
 assert_term(Src, Vst) ->
     get_term_type(Src, Vst),
     ok.
diff --git a/lib/compiler/test/beam_validator_SUITE.erl b/lib/compiler/test/beam_validator_SUITE.erl
index 551cf7661b..6779a2cfec 100644
--- a/lib/compiler/test/beam_validator_SUITE.erl
+++ b/lib/compiler/test/beam_validator_SUITE.erl
@@ -211,20 +211,21 @@ accessing_tags(Config) when is_list(Config) ->
 
 bad_catch_try(Config) when is_list(Config) ->
     Errors = do_val(bad_catch_try, Config),
-    ?line [{{bad_catch_try,bad_1,1},
-	    {{'catch',{x,0},{f,3}},
-	     5,{invalid_store,{x,0},{catchtag,[3]}}}},
-	   {{bad_catch_try,bad_2,1},
-	    {{catch_end,{x,9}},
-	     8,{source_not_y_reg,{x,9}}}},
-	   {{bad_catch_try,bad_3,1},
-	    {{catch_end,{y,1}},9,{bad_type,{atom,kalle}}}},
-	   {{bad_catch_try,bad_4,1},
-	    {{'try',{x,0},{f,15}},5,{invalid_store,{x,0},{trytag,[15]}}}},
-	   {{bad_catch_try,bad_5,1},
-	    {{try_case,{y,1}},12,{bad_type,term}}},
-	   {{bad_catch_try,bad_6,1},
-	    {{try_end,{y,1}},8,{bad_type,{integer,1}}}}] = Errors,
+    [{{bad_catch_try,bad_1,1},
+      {{'catch',{x,0},{f,3}},
+       5,{invalid_store,{x,0},{catchtag,[3]}}}},
+     {{bad_catch_try,bad_2,1},
+      {{catch_end,{x,9}},
+       8,{source_not_y_reg,{x,9}}}},
+     {{bad_catch_try,bad_3,1},
+      {{catch_end,{y,1}},9,{bad_type,{atom,kalle}}}},
+     {{bad_catch_try,bad_4,1},
+      {{'try',{x,0},{f,15}},5,{invalid_store,{x,0},{trytag,[15]}}}},
+     {{bad_catch_try,bad_5,1},
+      {{try_case,{y,1}},12,{bad_type,term}}},
+     {{bad_catch_try,bad_6,1},
+      {{move,{integer,1},{y,1}},7,
+       {invalid_store,{y,1},{integer,1}}}}] = Errors,
     ok.
 
 cons_guard(Config) when is_list(Config) ->
diff --git a/lib/compiler/test/beam_validator_SUITE_data/bad_catch_try.S b/lib/compiler/test/beam_validator_SUITE_data/bad_catch_try.S
index 2a53f0dd93..6035f23506 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/bad_catch_try.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/bad_catch_try.S
@@ -63,11 +63,11 @@
   {label,9}.
     {func_info,{atom,bad_catch_try},{atom,bad_3},1}.
   {label,10}.
-    {allocate,1,1}.
+    {allocate,2,1}.
+    {move,{atom,kalle},{y,1}}.
     {'catch',{y,0},{f,11}}.
     {call,1,{f,26}}.
   {label,11}.
-    {move,{atom,kalle},{y,1}}.
     {catch_end,{y,1}}.
     {test,is_tuple,{f,12},[{x,0}]}.
     {test,test_arity,{f,12},[{x,0},2]}.
@@ -106,7 +106,7 @@
   {label,17}.
     {func_info,{atom,bad_catch_try},{atom,bad_5},1}.
   {label,18}.
-    {allocate_zero,1,1}.
+    {allocate_zero,2,1}.
     {'try',{y,0},{f,19}}.
     {call,1,{f,26}}.
     {try_end,{y,0}}.
@@ -131,7 +131,7 @@
     {'try',{y,0},{f,23}}.
     {call,1,{f,26}}.
     {move,{integer,1},{y,1}}.
-    {try_end,{y,1}}.
+    {try_end,{y,0}}.
     {move,{atom,ok},{x,0}}.
     {jump,{f,24}}.
   {label,23}.