Map less in traffic suite

By just decoding to map in the client, instead of to record first. The
record decode is exercised enough in the server and in other suites.

1 files changed, 36 insertions, 61 deletions

diff --git a/lib/diameter/test/diameter_traffic_SUITE.erl b/lib/diameter/test/diameter_traffic_SUITE.erl
index 559ec14c2b..b4656562c4 100644
--- a/lib/diameter/test/diameter_traffic_SUITE.erl
+++ b/lib/diameter/test/diameter_traffic_SUITE.erl
@@ -498,6 +498,7 @@ start_services(Config) ->
                                      | ?SERVICE(SN, Grp)]),
     ok = diameter:start_service(CN, [{traffic_counters, bool()},
                                      {sequence, ?CLIENT_MASK},
+                                     {decode_format, map},
                                      {strict_arities, decode}
                                      | ?SERVICE(CN, Grp)]).
 
@@ -683,9 +684,9 @@ send_proxy_info(Config) ->
     Req = ['ASR', {'Proxy-Info', #{'Proxy-Host'  => H0,
                                    'Proxy-State' => S0}}],
     ['answer-message' | #{'Result-Code' := 3999,
-                          'Proxy-Info' := [Rec]}]
+                          'Proxy-Info' := [#{'Proxy-Host' := H,
+                                             'Proxy-State' := S}]}]
         = call(Config, Req),
-    {H, S, []} = proxy_info(Rec, Config),
     [H0, S0] = [?B(X) || X <- [H,S]].
 
 %% Send an unknown AVP (to some client) and check that it comes back.
@@ -711,12 +712,12 @@ send_unknown_short(Config, M, RC) ->
                                          data = <<17>>}]}],
     ['ASA' | #{'Session-Id' := _,
                'Result-Code' := RC,
-               'Failed-AVP' := Avps}]
+               'Failed-AVP' := [#{'AVP' := [Avp]}]}]
         = call(Config, Req),
-    [[#diameter_avp{code = 999,
-                    is_mandatory = M,
-                    data = <<17, _/binary>>}]] %% extra bits from padding
-        = failed_avps(Avps, Config).
+    #diameter_avp{code = 999,
+                  is_mandatory = M,
+                  data = <<17, _/binary>>} %% extra bits from padding
+        = Avp.
 
 %% Ditto but set the M flag.
 send_unknown_mandatory(Config) ->
@@ -725,12 +726,12 @@ send_unknown_mandatory(Config) ->
                                          data = <<17>>}]}],
     ['ASA' | #{'Session-Id' := _,
                'Result-Code' := ?AVP_UNSUPPORTED,
-               'Failed-AVP' := Avps}]
+               'Failed-AVP' := [#{'AVP' := [Avp]}]}]
         = call(Config, Req),
-    [[#diameter_avp{code = 999,
-                    is_mandatory = true,
-                    data = <<17>>}]]
-        = failed_avps(Avps, Config).
+    #diameter_avp{code = 999,
+                  is_mandatory = true,
+                  data = <<17>>}
+        = Avp.
 
 %% Ditto, and point the AVP length past the end of the message. Expect
 %% 5014 instead of 5001.
@@ -745,13 +746,13 @@ send_unexpected_mandatory_decode(Config) ->
                                          data = <<12:32>>}]}],
     ['ASA' | #{'Session-Id' := _,
                'Result-Code' := ?AVP_UNSUPPORTED,
-               'Failed-AVP' := Avps}]
+               'Failed-AVP' := [#{'AVP' := [Avp]}]}]
         = call(Config, Req),
-    [[#diameter_avp{code = 27,
-                    is_mandatory = true,
-                    value = 12,
-                    data = <<12:32>>}]]
-        = failed_avps(Avps, Config).
+    #diameter_avp{code = 27,
+                  is_mandatory = true,
+                  value = 12,
+                  data = <<12:32>>}
+        = Avp.
 
 %% Try to two Auth-Application-Id in ASR expect 5009.
 send_too_many(Config) ->
@@ -759,11 +760,11 @@ send_too_many(Config) ->
 
     ['ASA' | #{'Session-Id' := _,
                'Result-Code' := ?TOO_MANY,
-               'Failed-AVP' := Avps}]
+               'Failed-AVP' := [#{'AVP' := [Avp]}]}]
         = call(Config, Req),
-    [[#diameter_avp{name = 'Auth-Application-Id',
-                    value = 44}]]
-        = failed_avps(Avps, Config).
+    #diameter_avp{name = 'Auth-Application-Id',
+                  value = 44}
+        = Avp.
 
 %% Send an containing a faulty Grouped AVP (empty Proxy-Host in
 %% Proxy-Info) and expect that only the faulty AVP is sent in
@@ -775,12 +776,11 @@ send_grouped_error(Config) ->
                                    {'Proxy-State', ""}]]}],
     ['ASA' | #{'Session-Id' := _,
                'Result-Code' := ?INVALID_AVP_LENGTH,
-               'Failed-AVP' := Avps}]
+               'Failed-AVP' := [#{'AVP' := [Avp]}]}]
         = call(Config, Req),
-    [[#diameter_avp{name = 'Proxy-Info', value = V}]]
-        = failed_avps(Avps, Config),
-    {Empty, undefined, []} = proxy_info(V, Config),
-    <<0>> = ?B(Empty).
+    #diameter_avp{name = 'Proxy-Info', value = #{'Proxy-Host' := H}}
+        = Avp,
+    <<0>> = ?B(H).
 
 %% Send an STR that the server ignores.
 send_noreply(Config) ->
@@ -833,9 +833,8 @@ send_invalid_avp_length(Config) ->
                'Result-Code' := ?INVALID_AVP_LENGTH,
                'Origin-Host' := _,
                'Origin-Realm' := _,
-               'Failed-AVP' := Avps}]
-        = call(Config, Req),
-    [[_]] = failed_avps(Avps, Config).
+               'Failed-AVP' := [#{'AVP' := [_]}]}]
+        = call(Config, Req).
 
 %% Send a request containing 5xxx errors that the server rejects with
 %% 3xxx.
@@ -1046,29 +1045,6 @@ send_anything(Config) ->
 
 %% ===========================================================================
 
-failed_avps(Avps, Config) ->
-    #group{client_dict = D} = proplists:get_value(group, Config),
-    [failed_avp(D, T) || T <- Avps].
-
-failed_avp(nas4005, {'nas_Failed-AVP', As}) ->
-    As;
-failed_avp(_, #'diameter_base_Failed-AVP'{'AVP' = As}) ->
-    As.
-
-proxy_info(Rec, Config) ->
-    #group{client_dict = D} = proplists:get_value(group, Config),
-    if D == nas4005 ->
-            {'nas_Proxy-Info', H, S, As}
-                = Rec,
-            {H,S,As};
-       true ->
-            #'diameter_base_Proxy-Info'{'Proxy-Host' = H,
-                                        'Proxy-State' = S,
-                                        'AVP' = As}
-                = Rec,
-            {H,S,As}
-    end.
-
 group(Config) ->
     #group{} = proplists:get_value(group, Config).
 
@@ -1539,24 +1515,23 @@ answer(Pkt, Req, _Peer, Name, #group{client_dict = Dict0}) ->
     #diameter_packet{header = H, msg = Ans, errors = Es} = Pkt,
     ApplId = app(Req, Name, Dict0),
     #diameter_header{application_id = ApplId} = H,  %% assert
-    Dict = dict(Ans, Dict0),
-    rec_to_map(answer(Ans, Es, Name), Dict).
+    answer(Ans, Es, Name).
 
 %% Missing Result-Code and inappropriate Experimental-Result-Code.
-answer(Rec, Es, send_experimental_result) ->
+answer(Ans, Es, send_experimental_result) ->
     [{5004, #diameter_avp{name = 'Experimental-Result'}},
      {5005, #diameter_avp{name = 'Result-Code'}}]
         =  Es,
-    Rec;
+    Ans;
 
 %% An inappropriate E-bit results in a decode error ...
-answer(Rec, Es, send_bad_answer) ->
+answer(Ans, Es, send_bad_answer) ->
     [{5004, #diameter_avp{name = 'Result-Code'}} | _] = Es,
-    Rec;
+    Ans;
 
 %% ... while other errors are reflected in Failed-AVP.
-answer(Rec, [], _) ->
-    Rec.
+answer(Ans, [], _) ->
+    Ans.
 
 app(_, send_unsupported_app, _) ->
     ?BAD_APP;