diff options
| author | Ingela Anderton Andin <[email protected]> | 2018-07-17 11:54:43 +0200 |
|---|---|---|
| committer | Ingela Anderton Andin <[email protected]> | 2018-07-17 11:59:43 +0200 |
| commit | eebfa937b9c08a25b195909581274c7753bc77ef (patch) | |
| tree | 6a125435d1ecaea67afab7aa61f45e2267ab17da | |
| parent | 857156bcadae45fe112911bd7ca735ac6f3ca9d2 (diff) | |
| download | otp-eebfa937b9c08a25b195909581274c7753bc77ef.tar.gz otp-eebfa937b9c08a25b195909581274c7753bc77ef.tar.bz2 otp-eebfa937b9c08a25b195909581274c7753bc77ef.zip | |
inets: Improve error handling
| -rw-r--r-- | lib/inets/src/http_server/httpd_file.erl | 3 | ||||
| -rw-r--r-- | lib/inets/test/httpd_SUITE.erl | 15 |
2 files changed, 16 insertions, 2 deletions
diff --git a/lib/inets/src/http_server/httpd_file.erl b/lib/inets/src/http_server/httpd_file.erl index 4d419172d0..fb71834e95 100644 --- a/lib/inets/src/http_server/httpd_file.erl +++ b/lib/inets/src/http_server/httpd_file.erl @@ -33,6 +33,9 @@ handle_error(enoent, Op, ModData, Path) -> handle_error(enotdir, Op, ModData, Path) -> handle_error(404, Op, ModData, Path, ": A component of the file name is not a directory"); +handle_error(eisdir, Op, ModData, Path) -> + handle_error(403, Op, ModData, Path, + ":Ilegal operation expected a file not a directory"); handle_error(emfile, Op, _ModData, Path) -> handle_error(500, Op, none, Path, ": Too many open files"); handle_error({enfile,_}, Op, _ModData, Path) -> diff --git a/lib/inets/test/httpd_SUITE.erl b/lib/inets/test/httpd_SUITE.erl index 9a85c51d24..6981dc901a 100644 --- a/lib/inets/test/httpd_SUITE.erl +++ b/lib/inets/test/httpd_SUITE.erl @@ -441,8 +441,19 @@ get(Config) when is_list(Config) -> {header, "Content-Type", "text/html"}, {header, "Date"}, {header, "Server"}, + {version, Version}]), + + ok = httpd_test_lib:verify_request(proplists:get_value(type, Config), Host, + proplists:get_value(port, Config), + transport_opts(Type, Config), + proplists:get_value(node, Config), + http_request("GET /open/ ", Version, Host), + [{statuscode, 403}, + {header, "Content-Type", "text/html"}, + {header, "Date"}, + {header, "Server"}, {version, Version}]). - + basic_auth_1_1(Config) when is_list(Config) -> basic_auth([{http_version, "HTTP/1.1"} | Config]). @@ -1930,7 +1941,7 @@ head_status(_) -> basic_conf() -> [{modules, [mod_alias, mod_range, mod_responsecontrol, - mod_trace, mod_esi, mod_cgi, mod_dir, mod_get, mod_head]}]. + mod_trace, mod_esi, mod_cgi, mod_get, mod_head]}]. auth_access_conf() -> [{modules, [mod_alias, mod_htaccess, mod_dir, mod_get, mod_head]}, |