diff options
author | Hans Nilsson <[email protected]> | 2017-05-15 13:58:27 +0200 |
---|---|---|
committer | Hans Nilsson <[email protected]> | 2017-05-15 19:16:53 +0200 |
commit | 77371ab686d408e13dc8549085c0fdb9a5b30733 (patch) | |
tree | 4ec94f9ac8128256aa7f5997449ebdce3e90fdf4 | |
parent | 773c4d4f0416f25e3c0c6939f8d0871dc4486bab (diff) | |
download | otp-77371ab686d408e13dc8549085c0fdb9a5b30733.tar.gz otp-77371ab686d408e13dc8549085c0fdb9a5b30733.tar.bz2 otp-77371ab686d408e13dc8549085c0fdb9a5b30733.zip |
ssh: ssh_file:user_key/2 checks ec keytype
-rw-r--r-- | lib/ssh/src/ssh_file.erl | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/lib/ssh/src/ssh_file.erl b/lib/ssh/src/ssh_file.erl index 6692432fcf..33792da38f 100644 --- a/lib/ssh/src/ssh_file.erl +++ b/lib/ssh/src/ssh_file.erl @@ -75,10 +75,7 @@ host_key(Algorithm, Opts) -> Password = proplists:get_value(identity_pass_phrase(Algorithm), Opts, ignore), case decode(File, Password) of {ok,Key} -> - case ssh_transport:valid_key_sha_alg(Key,Algorithm) of - true -> {ok,Key}; - false -> {error,bad_keytype_in_file} - end; + check_key_type(Key, Algorithm); {error,DecodeError} -> {error,DecodeError} end. @@ -104,10 +101,20 @@ is_host_key(Key, PeerName, Algorithm, Opts) -> user_key(Algorithm, Opts) -> File = file_name(user, identity_key_filename(Algorithm), Opts), Password = proplists:get_value(identity_pass_phrase(Algorithm), Opts, ignore), - decode(File, Password). + case decode(File, Password) of + {ok, Key} -> + check_key_type(Key, Algorithm); + Error -> + Error + end. %% Internal functions %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% +check_key_type(Key, Algorithm) -> + case ssh_transport:valid_key_sha_alg(Key,Algorithm) of + true -> {ok,Key}; + false -> {error,bad_keytype_in_file} + end. file_base_name('ssh-rsa' ) -> "ssh_host_rsa_key"; file_base_name('rsa-sha2-256' ) -> "ssh_host_rsa_key"; |