diff options
author | Dan Gudmundsson <[email protected]> | 2018-01-22 12:04:26 +0100 |
---|---|---|
committer | Dan Gudmundsson <[email protected]> | 2018-01-22 12:04:26 +0100 |
commit | d51c21fca9a4af46b9322b1425ed0a29ed50fd77 (patch) | |
tree | 5a92bb052bc81289b9c86d0804299df50f09d05f | |
parent | 68a0f569410f7375c44a9d806930b1172c1d92a8 (diff) | |
download | otp-d51c21fca9a4af46b9322b1425ed0a29ed50fd77.tar.gz otp-d51c21fca9a4af46b9322b1425ed0a29ed50fd77.tar.bz2 otp-d51c21fca9a4af46b9322b1425ed0a29ed50fd77.zip |
wx: open_port doesn't allow 0 terminated strings anymore
Fix getenv usage.
And remove set path it is automagically done by driver interface.
-rw-r--r-- | lib/wx/c_src/wxe_ps_init.c | 13 | ||||
-rw-r--r-- | lib/wx/src/wxe_master.erl | 13 |
2 files changed, 13 insertions, 13 deletions
diff --git a/lib/wx/c_src/wxe_ps_init.c b/lib/wx/c_src/wxe_ps_init.c index e6b677d469..277f3ac25f 100644 --- a/lib/wx/c_src/wxe_ps_init.c +++ b/lib/wx/c_src/wxe_ps_init.c @@ -61,13 +61,20 @@ int is_packaged_app() { void * wxe_ps_init2() { NSAutoreleasePool *pool; ProcessSerialNumber psn; - + size_t app_len = 127; + char app_title_buf[128]; + char * app_title; // Setup and enable gui pool = [[NSAutoreleasePool alloc] init]; - + if( !is_packaged_app() ) { // Undocumented function (but no documented way of doing this exists) - char *app_title = getenv("WX_APP_TITLE"); + int res = erl_drv_getenv("WX_APP_TITLE", app_title_buf, &app_len); + if (res >= 0) { + app_title = app_title_buf; + } else { + app_title = NULL; + } if(!GetCurrentProcess(&psn)) { CPSSetProcessName(&psn, app_title?app_title:"Erlang"); } diff --git a/lib/wx/src/wxe_master.erl b/lib/wx/src/wxe_master.erl index ce859b3eb3..a55917f0aa 100644 --- a/lib/wx/src/wxe_master.erl +++ b/lib/wx/src/wxe_master.erl @@ -122,16 +122,9 @@ init([SilentStart]) -> erlang:error(not_smp) end, - case os:type() of - {win32,_} -> %% Needed for mingwm10.dll - Path = os:getenv("PATH"), - os:putenv("PATH", PrivDir ++ ";" ++ Path); - _ -> ok - end, - case erl_ddll:load_driver(PrivDir,DriverName) of ok -> ok; - {error, What} -> + {error, What} -> wxe_util:opt_error_log(SilentStart, "WX Failed loading ~p@~p ~n", [DriverName,PrivDir]), @@ -139,8 +132,8 @@ init([SilentStart]) -> erlang:error({load_driver,Str}) end, process_flag(trap_exit, true), - DriverWithArgs = DriverName ++ " " ++ code:priv_dir(wx) ++ [0], - + DriverWithArgs = DriverName ++ " " ++ code:priv_dir(wx), + try Port = open_port({spawn, DriverWithArgs},[binary]), wx_debug_info = ets:new(wx_debug_info, [named_table]), |