diff options
| author | Siri Hansen <[email protected]> | 2017-10-17 15:26:49 +0200 |
|---|---|---|
| committer | Siri Hansen <[email protected]> | 2017-10-17 15:40:02 +0200 |
| commit | 6c92cd8360fcacd85a8edd1cdb3fbfa307a1743f (patch) | |
| tree | 9470a755abc5d7b8ab29439ac255f7042a8d30fe | |
| parent | addb7f717be0d93eb1d8ed3942763af37fe50af9 (diff) | |
| download | otp-6c92cd8360fcacd85a8edd1cdb3fbfa307a1743f.tar.gz otp-6c92cd8360fcacd85a8edd1cdb3fbfa307a1743f.tar.bz2 otp-6c92cd8360fcacd85a8edd1cdb3fbfa307a1743f.zip | |
[rb] Don't fail for unexpected type of report
rb would fail to show an error_logger report which was not a
list. This is now corrected and any term is allowed (as specified in
the error_logger reference manual).
| -rw-r--r-- | lib/sasl/src/format_lib_supp.erl | 6 | ||||
| -rw-r--r-- | lib/sasl/test/rb_SUITE.erl | 18 |
2 files changed, 22 insertions, 2 deletions
diff --git a/lib/sasl/src/format_lib_supp.erl b/lib/sasl/src/format_lib_supp.erl index 80dcdc91da..00ce1b4e33 100644 --- a/lib/sasl/src/format_lib_supp.erl +++ b/lib/sasl/src/format_lib_supp.erl @@ -86,8 +86,10 @@ print_data(Device, Line, [{Key, Value}|T]) -> print_data(Device, Line, [Value|T]) -> Modifier = misc_supp:modifier(Device), io:format(Device, "~"++Modifier++"p~n", [Value]), - print_data(Device, Line, T). - + print_data(Device, Line, T); +print_data(Device, _Line, Value) -> + Modifier = misc_supp:modifier(Device), + io:format(Device, "~"++Modifier++"p~n", [Value]). print_items(Device, Line, {Name, Items}) -> print_items(Device, Line, Name, Items). diff --git a/lib/sasl/test/rb_SUITE.erl b/lib/sasl/test/rb_SUITE.erl index 426dedbab5..4ba2540545 100644 --- a/lib/sasl/test/rb_SUITE.erl +++ b/lib/sasl/test/rb_SUITE.erl @@ -36,6 +36,7 @@ no_group_cases() -> groups() -> [{running_error_logger,[shuffle],[show, + show_other, list, rescan, start_stop_log, @@ -165,6 +166,23 @@ show(Config) -> ok. +show_other(Config) -> + PrivDir = ?config(priv_dir,Config), + OutFile = filename:join(PrivDir,"rb_SUITE_log.txt"), + + %% Insert some reports in the error log and start rb + error_logger:info_report([rb_test_term_in_list]), + error_logger:info_report(rb_test_term_no_list), + ok = start_rb(OutFile), + + %% Show by type and check content + [{_,I1},{_,I2}] = check_report(fun() -> rb:show(info_report) end,OutFile), + + true = contains(I1,"rb_test_term_no_list"), + true = contains(I2,"rb_test_term_in_list"), + + ok. + list(Config) -> PrivDir = ?config(priv_dir,Config), OutFile = filename:join(PrivDir,"rb_SUITE_log.txt"), |