Merge branch 'sa/dialyzer-bug-fixes' into dev

* sa/dialyzer-bug-fixes:
  Fix typer's crash for nonexisting files
  Remove unused macro
  Decrease tuple arity limit
  Fix bug in dataflow

OTP-9597

3 files changed, 23 insertions, 14 deletions

diff --git a/lib/dialyzer/src/dialyzer_dataflow.erl b/lib/dialyzer/src/dialyzer_dataflow.erl
index 659297f993..d74c04385b 100644
--- a/lib/dialyzer/src/dialyzer_dataflow.erl
+++ b/lib/dialyzer/src/dialyzer_dataflow.erl
@@ -1399,10 +1399,14 @@ do_clause(C, Arg, ArgType0, OrigArgType, Map,
 		    true -> Any = t_any(), [Any || _ <- Pats];
 		    false -> t_to_tlist(OrigArgType)
 		  end,
-		case bind_pat_vars(Pats, OrigArgTypes, [], Map1, State1) of
-		  {error, bind, _, _, _} -> {{pattern_match, PatTypes}, false};
-		  {_, _} -> {{pattern_match_cov, PatTypes}, false}
-		end;
+		Tag =
+		  case bind_pat_vars(Pats, OrigArgTypes, [], Map1, State1) of
+		    {error,   bind, _, _, _} -> pattern_match;
+		    {error, record, _, _, _} -> record_match;
+		    {error, opaque, _, _, _} -> opaque_match;
+		    {_, _} -> pattern_match_cov
+		  end,
+		{{Tag, PatTypes}, false};
 	      false ->
 		%% Try to find out if this is a default clause in a list
 		%% comprehension and supress this. A real Hack(tm)
@@ -1442,12 +1446,12 @@ do_clause(C, Arg, ArgType0, OrigArgType, Map,
 			     opaque -> [PatString, format_type(Type, State1),
 					format_type(OpaqueTerm, State1)]
 			   end,
-		FailedMsg = case ErrorType of
-			      bind  -> {pattern_match, PatTypes};
-			      record -> {record_match, PatTypes};
-			      opaque -> {opaque_match, PatTypes}
+		FailedTag = case ErrorType of
+			      bind  -> pattern_match;
+			      record -> record_match;
+			      opaque -> opaque_match
 			    end,
-		{FailedMsg, Force0}
+		{{FailedTag, PatTypes}, Force0}
 	    end,
 	  WarnType = case Msg of
 		       {opaque_match, _} -> ?WARN_OPAQUE;
diff --git a/lib/hipe/cerl/erl_types.erl b/lib/hipe/cerl/erl_types.erl
index 7ff170776e..0ff827ac37 100644
--- a/lib/hipe/cerl/erl_types.erl
+++ b/lib/hipe/cerl/erl_types.erl
@@ -243,12 +243,11 @@
 -define(REC_TYPE_LIMIT, 2).
 
 -define(TUPLE_TAG_LIMIT, 5).
--define(TUPLE_ARITY_LIMIT, 10).
+-define(TUPLE_ARITY_LIMIT, 8).
 -define(SET_LIMIT, 13).
 -define(MAX_BYTE, 255).
 -define(MAX_CHAR, 16#10ffff).
 
--define(WIDENING_LIMIT, 7).
 -define(UNIT_MULTIPLIER, 8).
 
 -define(TAG_IMMED1_SIZE, 4).
diff --git a/lib/typer/src/typer.erl b/lib/typer/src/typer.erl
index fd906c8c46..f2a70f49b7 100644
--- a/lib/typer/src/typer.erl
+++ b/lib/typer/src/typer.erl
@@ -466,14 +466,20 @@ write_typed_file(File, Info) ->
   case file:make_dir(TyperAnnDir) of
     {error, Reason} ->
       case Reason of
-	eexist -> %% TypEr dir exists; remove old typer files
-	  ok = file:delete(NewFileName),
+	eexist -> %% TypEr dir exists; remove old typer files if they exist
+	  case file:delete(NewFileName) of
+	    ok -> ok;
+	    {error, enoent} -> ok;
+	    {error, _} ->
+	      Msg = io_lib:format("Error in deleting file ~s\n", [NewFileName]),
+	      fatal_error(Msg)
+	  end,
 	  write_typed_file(File, Info, NewFileName);
 	enospc ->
 	  Msg = io_lib:format("Not enough space in ~p\n", [Dir]),
 	  fatal_error(Msg);
 	eacces ->
-	  Msg = io:format("No write permission in ~p\n", [Dir]),
+	  Msg = io_lib:format("No write permission in ~p\n", [Dir]),
 	  fatal_error(Msg);
 	_ ->
 	  Msg = io_lib:format("Unhandled error ~s when writing ~p\n",