Add legacy test of sasl_report_file_h and size limiting

1 files changed, 70 insertions, 11 deletions

diff --git a/lib/sasl/test/sasl_report_SUITE.erl b/lib/sasl/test/sasl_report_SUITE.erl
index 863b765645..a03932133e 100644
--- a/lib/sasl/test/sasl_report_SUITE.erl
+++ b/lib/sasl/test/sasl_report_SUITE.erl
@@ -21,6 +21,7 @@
 -export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1,
 	 init_per_group/2,end_per_group/2]).
 -export([gen_server_crash/1, gen_server_crash_unicode/1]).
+-export([legacy_gen_server_crash/1, legacy_gen_server_crash_unicode/1]).
 
 -export([crash_me/0,start_link/0,init/1,handle_cast/2,terminate/2]).
 
@@ -29,7 +30,10 @@
 suite() -> [{ct_hooks,[ts_install_cth]}].
 
 all() ->
-    [gen_server_crash, gen_server_crash_unicode].
+    [gen_server_crash,
+     gen_server_crash_unicode,
+     legacy_gen_server_crash,
+     legacy_gen_server_crash_unicode].
 
 groups() ->
     [].
@@ -52,17 +56,77 @@ gen_server_crash(Config) ->
 gen_server_crash_unicode(Config) ->
     gen_server_crash(Config, unicode).
 
+legacy_gen_server_crash(Config) ->
+    legacy_gen_server_crash(Config,latin1).
+
+legacy_gen_server_crash_unicode(Config) ->
+    legacy_gen_server_crash(Config,unicode).
+
 gen_server_crash(Config, Encoding) ->
+    TC = list_to_atom(lists:concat([?FUNCTION_NAME,"_",Encoding])),
+    PrivDir = filename:join(?config(priv_dir,Config),?MODULE),
+    ConfigFileName = filename:join(PrivDir,TC),
+    KernelLog = filename:join(PrivDir,lists:concat([TC,"_kernel.log"])),
+    SaslLog = filename:join(PrivDir,lists:concat([TC,"_sasl.log"])),
+    KernelConfig = [{logger,[{handler,default,logger_std_h,
+                              #{config=>#{type=>{file,KernelLog}}}}]},
+                    {logger_sasl_compatible,true}],
+    Modes = [write, {encoding, Encoding}],
+    SaslConfig = [{sasl_error_logger,{file,SaslLog,Modes}}],
+    ok = filelib:ensure_dir(SaslLog),
+
+    ok = file:write_file(ConfigFileName ++ ".config",
+                         io_lib:format("[{kernel, ~p},~n{sasl, ~p}].",
+                                       [KernelConfig,SaslConfig])),
+    {ok,Node} =
+        test_server:start_node(
+          TC, peer,
+          [{args, ["-pa ",filename:dirname(code:which(?MODULE)),
+                   " -boot start_sasl -kernel start_timer true "
+                   "-config ",ConfigFileName]}]),
+
+    %% Set depth
+    ok = rpc:call(Node,logger,update_formatter_config,[default,depth,30]),
+    ok = rpc:call(Node,logger,update_formatter_config,[sasl,depth,30]),
+
+    %% Make sure remote node logs it's own logs, and current node does
+    %% not log them.
+    ok = rpc:call(Node,logger,remove_handler_filter,[default,remote_gl]),
+    ok = rpc:call(Node,logger,remove_handler_filter,[sasl,remote_gl]),
+    ok = logger:add_primary_filter(no_remote,{fun(#{meta:=#{pid:=Pid}},_)
+                                                 when node(Pid)=/=node() -> stop;
+                                              (_,_) -> ignore
+                                           end,[]}),
+    ct:log("Local node Logger config:~n~p",
+           [rpc:call(Node,logger,get_config,[])]),
+    ct:log("Remote node Logger config:~n~p",
+           [rpc:call(Node,logger,get_config,[])]),
+    ct:log("Remote node error_logger handlers: ~p",
+           [rpc:call(Node,error_logger,which_report_handlers,[])]),
+
+    ok = rpc:call(Node,?MODULE,crash_me,[]),
+
+    test_server:stop_node(Node),
+    ok = logger:remove_primary_filter(no_remote),
+
+    check_file(KernelLog, utf8, 70000, 150000),
+    check_file(SaslLog, Encoding, 70000, 150000),
+
+    ok = file:delete(KernelLog),
+    ok = file:delete(SaslLog),
+
+    ok.
+
+legacy_gen_server_crash(Config, Encoding) ->
     StopFilter = {fun(_,_) -> stop end, ok},
     logger:add_handler_filter(default,stop_all,StopFilter),
+    logger:add_handler_filter(sasl,stop_all,StopFilter),
     logger:add_handler_filter(cth_log_redirect,stop_all,StopFilter),
     try
 	do_gen_server_crash(Config, Encoding)
     after
-        ok = application:unset_env(kernel, logger_sasl_compatible),
-	ok = application:unset_env(sasl, sasl_error_logger),
-	ok = application:unset_env(kernel, error_logger_format_depth),
         logger:remove_handler_filter(default,stop_all),
+        logger:remove_handler_filter(sasl,stop_all),
         logger:remove_handler_filter(cth_log_redirect,stop_all)
     end,
     ok.
@@ -74,22 +138,17 @@ do_gen_server_crash(Config, Encoding) ->
     SaslLog = filename:join(LogDir, "sasl.log"),
     ok = filelib:ensure_dir(SaslLog),
 
-    application:stop(sasl),
     Modes = [write, {encoding, Encoding}],
-    ok = application:set_env(kernel, logger_sasl_compatible, true),
-    ok = application:set_env(sasl, sasl_error_logger, {file,SaslLog,Modes},
-			     [{persistent,true}]),
     application:set_env(kernel, error_logger_format_depth, 30),
     error_logger:logfile({open,KernelLog}),
-    application:start(sasl),
+    error_logger:add_report_handler(sasl_report_file_h,{SaslLog,Modes,all}),
     ct:log("Logger config:~n~p",[logger:get_config()]),
     ct:log("error_logger handlers: ~p",[error_logger:which_report_handlers()]),
 
     crash_me(),
 
-
     error_logger:logfile(close),
-    application:stop(sasl),
+    error_logger:delete_report_handler(sasl_report_file_h),
 
     check_file(KernelLog, utf8, 70000, 150000),
     check_file(SaslLog, Encoding, 70000, 150000),