Merge branch 'siri/upgrade_SUITE/stop-inets-before-start-ftp'

* siri/upgrade_SUITE/stop-inets-before-start-ftp:
  Add correction of relup when upgrading from 20-21 with inets and ftp/tftp

1 files changed, 42 insertions, 2 deletions

diff --git a/erts/test/upgrade_SUITE.erl b/erts/test/upgrade_SUITE.erl
index 31ceb06314..73d221cfab 100644
--- a/erts/test/upgrade_SUITE.erl
+++ b/erts/test/upgrade_SUITE.erl
@@ -132,7 +132,7 @@ upgrade_test1(FromVsn,ToVsn,Config) ->
 
     {FromRel,FromApps} = target_system(FromRelName, FromVsn,
 				       CreateDir, InstallDir,Config),
-    {ToRel,ToApps} = upgrade_system(FromRel, ToRelName, ToVsn,
+    {ToRel,ToApps} = upgrade_system(FromVsn, FromRel, ToRelName, ToVsn,
 				    CreateDir, InstallDir),
     do_upgrade(FromVsn, FromApps, ToRel, ToApps, InstallDir).
 
@@ -216,7 +216,7 @@ target_system(RelName0,RelVsn,CreateDir,InstallDir,Config) ->
 %%% Create a release containing the current (the test node) OTP
 %%% release, including relup to allow upgrade from an earlier OTP
 %%% release.
-upgrade_system(FromRel, ToRelName0, ToVsn,
+upgrade_system(FromVsn, FromRel, ToRelName0, ToVsn,
 	       CreateDir, InstallDir) ->
 
     {RelName,Apps,_} = create_relfile(node(),CreateDir,ToRelName0,ToVsn),
@@ -226,6 +226,11 @@ upgrade_system(FromRel, ToRelName0, ToVsn,
     ok = systools:make_relup(RelName,[FromRel],[FromRel],
 			     [{path,[FromPath]},
 			      {outdir,CreateDir}]),
+    case {FromVsn,ToVsn} of
+        {"20"++_,"21"++_} -> fix_relup_inets_ftp(filename:dirname(RelName));
+        _ -> ok
+    end,
+
     SysConfig = filename:join([CreateDir, "sys.config"]),
     write_file(SysConfig, "[]."),
 
@@ -233,6 +238,41 @@ upgrade_system(FromRel, ToRelName0, ToVsn,
 
     {RelName,Apps}.
 
+%% In OTP-21, ftp and tftp were split out from inets and formed two
+%% new separate applications. When creating the relup, systools
+%% automatically adds new applications first, before upgrading
+%% existing applications. Since ftp and tftp have processes with the
+%% same name as in the old version of inets, the upgrade failed with
+%% trying to start the new applications (already exist).
+%%
+%% To go around this problem, this function adds an instruction to
+%% stop inets before the new applications are started. This is a very
+%% specific adjustment, and it will be needed for any upgrade which
+%% involves conversion from inets to ftp/tftp.
+fix_relup_inets_ftp(Dir) ->
+    Filename = filename:join(Dir,"relup"),
+    {ok,[{ToVsn,Up,Down}]} = file:consult(Filename),
+    [{FromVsn,UpDescr,UpInstr}] = Up,
+    [{FromVsn,DownDescr,DownInstr}] = Down,
+
+    Fun = fun(point_of_no_return) -> false;
+             (_) -> true
+          end,
+    {UpBefore,[point_of_no_return|UpAfter]} = lists:splitwith(Fun,UpInstr),
+    {DownBefore,[point_of_no_return|DownAfter]} = lists:splitwith(Fun,DownInstr),
+    NewRelup =
+        {ToVsn,
+         [{FromVsn,UpDescr,UpBefore++[point_of_no_return,
+                                      {apply,{application,stop,[inets]}} |
+                                      UpAfter]}],
+         [{FromVsn,DownDescr,DownBefore++[point_of_no_return,
+                                          {apply,{application,stop,[inets]}} |
+                                          DownAfter]}]},
+    {ok, Fd} = file:open(Filename, [write,{encoding,utf8}]),
+    io:format(Fd, "%% ~s~n~tp.~n", [epp:encoding_to_string(utf8),NewRelup]),
+    ok = file:close(Fd).
+
+
 %%%-----------------------------------------------------------------
 %%% Start a new node running the release from target_system/5
 %%% above. Then upgrade to the system from upgrade_system/5.