aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2016-02-25 15:51:39 +0100
committerBjörn Gustavsson <[email protected]>2016-02-25 15:53:34 +0100
commit9d8efc5acc50ae1c76b00a67d06ed284fbcce0aa (patch)
tree75dff506bb429942f600d6c6bdb84ef2262001fd
parentb180108aed3f44654aae70e3b59a8e6fb02df995 (diff)
downloadotp-9d8efc5acc50ae1c76b00a67d06ed284fbcce0aa.tar.gz
otp-9d8efc5acc50ae1c76b00a67d06ed284fbcce0aa.tar.bz2
otp-9d8efc5acc50ae1c76b00a67d06ed284fbcce0aa.zip
Eliminate use of doc and suite clauses
Those clause are obsolete and never used by common_test.
-rw-r--r--lib/compiler/test/beam_disasm_SUITE.erl3
-rw-r--r--lib/compiler/test/compilation_SUITE.erl22
-rw-r--r--lib/compiler/test/fun_SUITE.erl1
-rw-r--r--lib/compiler/test/guard_SUITE.erl3
-rw-r--r--lib/compiler/test/misc_SUITE.erl7
5 files changed, 10 insertions, 26 deletions
diff --git a/lib/compiler/test/beam_disasm_SUITE.erl b/lib/compiler/test/beam_disasm_SUITE.erl
index 75bc720596..2452b771ff 100644
--- a/lib/compiler/test/beam_disasm_SUITE.erl
+++ b/lib/compiler/test/beam_disasm_SUITE.erl
@@ -46,8 +46,7 @@ init_per_group(_GroupName, Config) ->
end_per_group(_GroupName, Config) ->
Config.
-stripped(doc) ->
- ["Check that stripped beam files can be disassembled"];
+%% Check that stripped beam files can be disassembled.
stripped(Config) when is_list(Config) ->
PrivDir = proplists:get_value(priv_dir, Config),
?line SrcName = filename:join(PrivDir, "tmp.erl"),
diff --git a/lib/compiler/test/compilation_SUITE.erl b/lib/compiler/test/compilation_SUITE.erl
index 72ceb87bf1..6c90a38f5a 100644
--- a/lib/compiler/test/compilation_SUITE.erl
+++ b/lib/compiler/test/compilation_SUITE.erl
@@ -166,9 +166,7 @@ split({int, N}, <<N:16,B:N/binary,T/binary>>) ->
?comp(on_load).
?comp(on_load_inline).
-beam_compiler_7(doc) ->
- "Code snippet submitted from Ulf Wiger which fails in R3 Beam.";
-beam_compiler_7(suite) -> [];
+%% Code snippet submitted from Ulf Wiger which fails in R3 Beam.
beam_compiler_7(Config) when is_list(Config) ->
?line done = empty(2, false).
@@ -339,9 +337,7 @@ from(H, [_ | T]) -> from(H, T);
from(_, []) -> [].
-vsn_1(doc) ->
- "Test generation of 'vsn' attribute";
-vsn_1(suite) -> [];
+%% Test generation of 'vsn' attribute.
vsn_1(Conf) when is_list(Conf) ->
?line M = vsn_1,
@@ -364,9 +360,7 @@ vsn_1(Conf) when is_list(Conf) ->
end,
ok.
-vsn_2(doc) ->
- "Test overriding of generation of 'vsn' attribute";
-vsn_2(suite) -> [];
+%% Test overriding of generation of 'vsn' attribute.
vsn_2(Conf) when is_list(Conf) ->
?line M = vsn_2,
@@ -380,9 +374,7 @@ vsn_2(Conf) when is_list(Conf) ->
end,
ok.
-vsn_3(doc) ->
- "Test that different code yields different generated 'vsn'";
-vsn_3(suite) -> [];
+%% Test that different code yields different generated 'vsn'.
vsn_3(Conf) when is_list(Conf) ->
?line M = vsn_3,
@@ -463,9 +455,9 @@ self_compile_node(CompilerDir, OutDir, Version, Opts) ->
%% node. Use a shielded node to prevent the cover server from
%% being started.
test_server:run_on_shielded_node(
- fun() ->
- compile_compiler(Files, OutDir, Version, Opts)
- end, Pa),
+ fun() ->
+ compile_compiler(Files, OutDir, Version, Opts)
+ end, Pa),
ok.
diff --git a/lib/compiler/test/fun_SUITE.erl b/lib/compiler/test/fun_SUITE.erl
index 9b6e14217d..e2eaef8b6f 100644
--- a/lib/compiler/test/fun_SUITE.erl
+++ b/lib/compiler/test/fun_SUITE.erl
@@ -60,7 +60,6 @@ l1() ->
?T((begin G = fun(1=0) -> ok end, {'EXIT',_} = (catch G(2)), ok end), ok)
].
-test1(suite) -> [];
test1(Config) when is_list(Config) ->
?line lists:foreach(fun one_test/1, eval_list(l1(), [])),
ok.
diff --git a/lib/compiler/test/guard_SUITE.erl b/lib/compiler/test/guard_SUITE.erl
index eb3feb6307..33d2c89d90 100644
--- a/lib/compiler/test/guard_SUITE.erl
+++ b/lib/compiler/test/guard_SUITE.erl
@@ -1647,8 +1647,7 @@ mask_error({'EXIT',{Err,_}}) ->
mask_error(Else) ->
Else.
-binary_part(doc) ->
- ["Tests the binary_part/2,3 guard (GC) bif's"];
+%% Test the binary_part/2,3 guard (GC) BIFs.
binary_part(Config) when is_list(Config) ->
%% This is more or less a copy of what the guard_SUITE in emulator
%% does to cover the guard bif's
diff --git a/lib/compiler/test/misc_SUITE.erl b/lib/compiler/test/misc_SUITE.erl
index d60141a10a..244d486753 100644
--- a/lib/compiler/test/misc_SUITE.erl
+++ b/lib/compiler/test/misc_SUITE.erl
@@ -91,12 +91,7 @@ abs(_N) ->
binary_part(_,_,_) ->
dummy_bp.
-% Make sure that auto-imported BIF's are overridden correctly
-
-override_bif(suite) ->
- [];
-override_bif(doc) ->
- ["Test dat local functions and imports override auto-imported BIFs."];
+%% Test that local functions and imports override auto-imported BIFs.
override_bif(Config) when is_list(Config) ->
?line dummy_abs = abs(1),
?line dummy_bp = binary_part(<<"hello">>,1,1),