Merge branch 'anders/diameter/info/OTP-12069' into maint

* anders/diameter/info/OTP-12069:
  Map binary process info to a reference/byte count
  Add info item for diameter:service_info/2
  Add (process) info tuple to diameter:service_info/2
  Add diameter_dbg:sizes/0
  Tweak comments

2 files changed, 82 insertions, 21 deletions

diff --git a/lib/diameter/src/base/diameter_service.erl b/lib/diameter/src/base/diameter_service.erl
index b7cd311e02..ab56ca9cef 100644
--- a/lib/diameter/src/base/diameter_service.erl
+++ b/lib/diameter/src/base/diameter_service.erl
@@ -1573,7 +1573,8 @@ transports(#state{watchdogT = WatchdogT}) ->
 -define(OTHER_INFO, [connections,
                      name,
                      peers,
-                     statistics]).
+                     statistics,
+                     info]).
 
 service_info(Item, S)
   when is_atom(Item) ->
@@ -1663,6 +1664,7 @@ complete_info(Item, #state{service = Svc} = S) ->
         keys         -> ?ALL_INFO ++ ?CAP_INFO ++ ?OTHER_INFO;
         all          -> service_info(?ALL_INFO, S);
         statistics   -> info_stats(S);
+        info         -> info_info(S);
         connections  -> info_connections(S);
         peers        -> info_peers(S)
     end.
@@ -1745,12 +1747,11 @@ peer_acc(PeerT, Acc, #watchdog{pid = Pid,
                                state = WS,
                                started = At,
                                peer = TPid}) ->
-    dict:append(Ref,
-                [{type, Type},
-                 {options, Opts},
-                 {watchdog, {Pid, At, WS}}
-                 | info_peer(PeerT, TPid, WS)],
-                Acc).
+    Info = [{type, Type},
+            {options, Opts},
+            {watchdog, {Pid, At, WS}}
+            | info_peer(PeerT, TPid, WS)],
+    dict:append(Ref, Info ++ [{info, info_process_info(Info)}], Acc).
 
 info_peer(PeerT, TPid, WS)
   when is_pid(TPid), WS /= ?WD_DOWN ->
@@ -1762,6 +1763,49 @@ info_peer(PeerT, TPid, WS)
 info_peer(_, _, _) ->
     [].
 
+info_process_info(Info) ->
+    lists:flatmap(fun ipi/1, Info).
+
+ipi({watchdog, {Pid, _, _}}) ->
+    info_pid(Pid);
+
+ipi({peer, {Pid, _}}) ->
+    info_pid(Pid);
+
+ipi({port, [{owner, Pid} | _]}) ->
+    info_pid(Pid);
+
+ipi(_) ->
+    [].
+
+info_pid(Pid) ->
+    case process_info(Pid, [message_queue_len, memory, binary]) of
+        undefined ->
+            [];
+        L ->
+            [{Pid, lists:map(fun({K,V}) -> {K, map_info(K,V)} end, L)}]
+    end.
+
+%% The binary list consists of 3-tuples {Ptr, Size, Count}, where Ptr
+%% is a C pointer value, Size is the size of a referenced binary in
+%% bytes, and Count is a global reference count. The same Ptr can
+%% occur multiple times, once for each reference on the process heap.
+%% In this case, the corresponding tuples will have Size in common but
+%% Count may differ just because no global lock is taken when the
+%% value is retrieved.
+%%
+%% The list can be quite large, and we aren't often interested in the
+%% pointers or counts, so whittle this down to the number of binaries
+%% referenced and their total byte count.
+map_info(binary, L) ->
+    SzD = lists:foldl(fun({P,S,_}, D) -> dict:store(P,S,D) end,
+                      dict:new(),
+                      L),
+    {dict:size(SzD), dict:fold(fun(_,S,N) -> S + N end, 0, SzD)};
+
+map_info(_, T) ->
+    T.
+
 %% The point of extracting the config here is so that 'transport' info
 %% has one entry for each transport ref, the peer table only
 %% containing entries that have a living watchdog.
@@ -1819,6 +1863,13 @@ mk_app(#diameter_app{} = A) ->
 info_pending(#state{} = S) ->
     diameter_traffic:pending(transports(S)).
 
+%% info_info/1
+%%
+%% Extract process_info from connections info.
+
+info_info(S) ->
+    [I || L <- conn_list(S), {info, I} <- L].
+
 %% info_connections/1
 %%
 %% One entry per transport connection. Statistics for each entry are
diff --git a/lib/diameter/src/info/diameter_dbg.erl b/lib/diameter/src/info/diameter_dbg.erl
index b5b3983afa..b536e5e80b 100644
--- a/lib/diameter/src/info/diameter_dbg.erl
+++ b/lib/diameter/src/info/diameter_dbg.erl
@@ -32,7 +32,8 @@
          compiled/0,
          procs/0,
          latest/0,
-         nl/0]).
+         nl/0,
+         sizes/0]).
 
 -export([diameter_config/0,
          diameter_peer/0,
@@ -69,7 +70,16 @@
 -define(VALUES(Rec), tl(tuple_to_list(Rec))).
 
 %% ----------------------------------------------------------
-%% # table(TableName)
+%% # sizes/0
+%%
+%% Return sizes of named tables.
+%% ----------------------------------------------------------
+
+sizes() ->
+    [{T, ets:info(T, size)} || T <- ?LOCAL, T /= diameter_peer].
+
+%% ----------------------------------------------------------
+%% # table/1
 %%
 %% Pretty-print a diameter table. Returns the number of records
 %% printed, or undefined.
@@ -97,7 +107,7 @@ split([F|Fs], [V|Vs]) ->
     {F, Fs, V, Vs}.
 
 %% ----------------------------------------------------------
-%% # TableName()
+%% # TableName/0
 %% ----------------------------------------------------------
 
 -define(TABLE(Name), Name() -> table(Name)).
@@ -111,7 +121,7 @@ split([F|Fs], [V|Vs]) ->
 ?TABLE(diameter_stats).
 
 %% ----------------------------------------------------------
-%% # tables()
+%% # tables/0
 %%
 %% Pretty-print diameter tables from all nodes. Returns the number of
 %% records printed.
@@ -127,7 +137,7 @@ split(_, Fs, Vs) ->
     split(Fs, Vs).
 
 %% ----------------------------------------------------------
-%% # modules()
+%% # modules/0
 %% ----------------------------------------------------------
 
 modules() ->
@@ -140,49 +150,49 @@ appdir() ->
     [_|_] = code:lib_dir(?APP, ebin).
 
 %% ----------------------------------------------------------
-%% # versions()
+%% # versions/0
 %% ----------------------------------------------------------
 
 versions() ->
     ?I:versions(modules()).
 
 %% ----------------------------------------------------------
-%% # versions()
+%% # version_info/0
 %% ----------------------------------------------------------
 
 version_info() ->
     ?I:version_info(modules()).
 
 %% ----------------------------------------------------------
-%% # compiled()
+%% # compiled/0
 %% ----------------------------------------------------------
 
 compiled() ->
     ?I:compiled(modules()).
 
 %% ----------------------------------------------------------
-%% procs()
+%% # procs/0
 %% ----------------------------------------------------------
 
 procs() ->
     ?I:procs(?APP).
 
 %% ----------------------------------------------------------
-%% # latest()
+%% # latest/0
 %% ----------------------------------------------------------
 
 latest() ->
     ?I:latest(modules()).
 
 %% ----------------------------------------------------------
-%% # nl()
+%% # nl/0
 %% ----------------------------------------------------------
 
 nl() ->
     lists:foreach(fun(M) -> abcast = c:nl(M) end, modules()).
 
 %% ----------------------------------------------------------
-%% # pp(Bin)
+%% # pp/1
 %%
 %% Description: Pretty-print a message binary.
 %% ----------------------------------------------------------
@@ -317,7 +327,7 @@ ppp({Field, Value}) ->
     io:format(": ~-22s : ~p~n", [Field, Value]).
 
 %% ----------------------------------------------------------
-%% # subscriptions()
+%% # subscriptions/0
 %%
 %% Returns a list of {SvcName, Pid}.
 %% ----------------------------------------------------------
@@ -326,7 +336,7 @@ subscriptions() ->
     diameter_service:subscriptions().
 
 %% ----------------------------------------------------------
-%% # children()
+%% # children/0
 %% ----------------------------------------------------------
 
 children() ->