Merge branch 'egil/fix-compiler-beam_bool/OTP-12844'

* egil/fix-compiler-beam_bool/OTP-12844:
  compiler: Add regressions_SUITE
  compiler: Fix beam_bool pass for get_map_elements

3 files changed, 109 insertions, 9 deletions

diff --git a/lib/compiler/src/beam_jump.erl b/lib/compiler/src/beam_jump.erl
index 80b2998ddc..5bfaa41b7d 100644
--- a/lib/compiler/src/beam_jump.erl
+++ b/lib/compiler/src/beam_jump.erl
@@ -490,16 +490,17 @@ is_label_used_in_1([], _, _) -> false.
 
 is_label_used_in_block({set,_,_,Info}, Lbl) ->
     case Info of
-	{bif,_,{f,F}} -> F =:= Lbl;
-	{alloc,_,{gc_bif,_,{f,F}}} -> F =:= Lbl;
+        {bif,_,{f,F}} -> F =:= Lbl;
+        {alloc,_,{gc_bif,_,{f,F}}} -> F =:= Lbl;
         {alloc,_,{put_map,_,{f,F}}} -> F =:= Lbl;
-	{'catch',{f,F}} -> F =:= Lbl;
-	{alloc,_,_} -> false;
-	{put_tuple,_} -> false;
-	{get_tuple_element,_} -> false;
-	{set_tuple_element,_} -> false;
-	{line,_} -> false;
-	_ when is_atom(Info) -> false
+        {get_map_elements,{f,F}} -> F =:= Lbl;
+        {'catch',{f,F}} -> F =:= Lbl;
+        {alloc,_,_} -> false;
+        {put_tuple,_} -> false;
+        {get_tuple_element,_} -> false;
+        {set_tuple_element,_} -> false;
+        {line,_} -> false;
+        _ when is_atom(Info) -> false
     end.
 
 %% remove_unused_labels(Instructions0) -> Instructions
diff --git a/lib/compiler/test/Makefile b/lib/compiler/test/Makefile
index 98125fc84e..6553d10077 100644
--- a/lib/compiler/test/Makefile
+++ b/lib/compiler/test/Makefile
@@ -33,6 +33,7 @@ MODULES= \
 	num_bif_SUITE \
 	receive_SUITE \
 	record_SUITE \
+	regressions_SUITE \
 	trycatch_SUITE \
 	warnings_SUITE \
 	z_SUITE \
diff --git a/lib/compiler/test/regressions_SUITE.erl b/lib/compiler/test/regressions_SUITE.erl
new file mode 100644
index 0000000000..51bcc5737f
--- /dev/null
+++ b/lib/compiler/test/regressions_SUITE.erl
@@ -0,0 +1,98 @@
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2015. All Rights Reserved.
+%%
+%% The contents of this file are subject to the Erlang Public License,
+%% Version 1.1, (the "License"); you may not use this file except in
+%% compliance with the License. You should have received a copy of the
+%% Erlang Public License along with this software. If not, it can be
+%% retrieved online at http://www.erlang.org/.
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and limitations
+%% under the License.
+%%
+%% %CopyrightEnd%
+%%
+
+%% Test specific code snippets that has crashed the compiler in the past.
+-module(regressions_SUITE).
+-include_lib("test_server/include/test_server.hrl").
+
+-export([all/0, groups/0, init_per_testcase/2,end_per_testcase/2]).
+
+-export([maps/1]).
+
+groups() -> 
+    [{p,test_lib:parallel(),
+      [maps]}].
+
+% Default timetrap timeout (set in init_per_testcase).
+-define(default_timeout, ?t:minutes(2)).
+
+init_per_testcase(_Case, Config) ->
+    ?line Dog = ?t:timetrap(?default_timeout),
+    [{watchdog, Dog} | Config].
+
+end_per_testcase(_Case, Config) ->
+    Dog = ?config(watchdog, Config),
+    test_server:timetrap_cancel(Dog),
+    ok.
+
+all() -> 
+    test_lib:recompile(?MODULE),
+    [{group,p}].
+
+%%% test cases
+
+maps(Config) when is_list(Config) ->
+    Ts = [{beam_bool_get_elements,
+           <<"century(#{ron := operator}, _century) ->
+                  if 0.0; _century, _century, _century -> _century end.
+           ">>}],
+    ok = run(Config, Ts),
+    ok.
+
+%% aux
+
+run(Config, Tests) ->
+    F = fun({N,P}) ->
+                io:format("Compiling test for: ~w~n", [N]),
+                case catch run_test(Config, P) of
+                    {'EXIT', Reason} -> 
+                        ?t:format("~nTest ~p failed.~nReason: ~p~n", [N, Reason]),
+                        fail();
+                    _ -> ok
+                end
+        end,
+    lists:foreach(F, Tests).
+
+
+run_test(Conf, Test0) ->
+    Module = "regressions_"++test_lib:uniq(),
+    Filename = Module ++ ".erl",
+    DataDir = ?config(priv_dir, Conf),
+    Test = ["-module(", Module, "). ", Test0],
+    File = filename:join(DataDir, Filename),
+    Def = [binary,export_all,return],
+    Opts = [ Opt ++ Def ||
+             Opt <- [ [no_postopt],
+                      [no_copt],
+                      [no_postopt,no_copt],
+                      [inline],
+                      [inline,no_postopt],
+                      []
+                    ]],
+    ok = file:write_file(File, Test),
+    lists:foreach(fun(Opt) ->
+                          io:format("  - compiling with ~p~n", [Opt]),
+                          {ok,_M,_Bin,_} = compile:file(File,Opt)
+                  end, Opts),
+    file:delete(File),
+    ok.
+
+fail() ->
+    io:format("failed~n"),
+    ?t:fail().