diff options
| author | Björn Gustavsson <[email protected]> | 2012-11-30 15:48:17 +0100 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2012-12-01 08:23:19 +0100 |
| commit | 53ec991d193d5115b356d5850b6b1fae0ad71df6 (patch) | |
| tree | 024e4529d7391a8e67484932bfcd8e0dcbad7792 | |
| parent | c4d680549e11e116dcdd95ac29101ef3e54aba5f (diff) | |
| download | otp-53ec991d193d5115b356d5850b6b1fae0ad71df6.tar.gz otp-53ec991d193d5115b356d5850b6b1fae0ad71df6.tar.bz2 otp-53ec991d193d5115b356d5850b6b1fae0ad71df6.zip | |
Teach is_function/2 that tuples are not funs
| -rw-r--r-- | erts/doc/src/erlang.xml | 7 | ||||
| -rw-r--r-- | erts/emulator/beam/erl_bif_op.c | 5 | ||||
| -rw-r--r-- | erts/emulator/test/fun_SUITE.erl | 4 |
3 files changed, 2 insertions, 14 deletions
diff --git a/erts/doc/src/erlang.xml b/erts/doc/src/erlang.xml index ef0e6fea84..5002c48ca1 100644 --- a/erts/doc/src/erlang.xml +++ b/erts/doc/src/erlang.xml @@ -1497,13 +1497,6 @@ os_prompt% </pre> applied with <c><anno>Arity</anno></c> number of arguments; otherwise returns <c>false</c>.</p> <p>Allowed in guard tests.</p> - <warning> - <p>Currently, <c>is_function/2</c> will also return - <c>true</c> if the first argument is a tuple fun (a tuple - containing two atoms). In a future release, tuple funs will - no longer be supported and <c>is_function/2</c> will return - <c>false</c> if given a tuple fun.</p> - </warning> </desc> </func> <func> diff --git a/erts/emulator/beam/erl_bif_op.c b/erts/emulator/beam/erl_bif_op.c index 13f8b1f63c..d4cd9c89b3 100644 --- a/erts/emulator/beam/erl_bif_op.c +++ b/erts/emulator/beam/erl_bif_op.c @@ -261,11 +261,6 @@ Eterm erl_is_function(Process* p, Eterm arg1, Eterm arg2) if (exp->code[2] == (Uint) arity) { BIF_RET(am_true); } - } else if (is_tuple(arg1)) { - Eterm* tp = tuple_val(arg1); - if (tp[0] == make_arityval(2) && is_atom(tp[1]) && is_atom(tp[2])) { - BIF_RET(am_true); - } } BIF_RET(am_false); } diff --git a/erts/emulator/test/fun_SUITE.erl b/erts/emulator/test/fun_SUITE.erl index ef06845cf2..36ba4e0f48 100644 --- a/erts/emulator/test/fun_SUITE.erl +++ b/erts/emulator/test/fun_SUITE.erl @@ -726,8 +726,8 @@ t_arity(Config) when is_list(Config) -> ok. t_is_function2(Config) when is_list(Config) -> - ?line true = is_function({a,b}, 0), - ?line true = is_function({a,b}, 234343434333433433), + false = is_function(id({a,b}), 0), + false = is_function(id({a,b}), 234343434333433433), ?line true = is_function(fun() -> ok end, 0), ?line true = is_function(fun(_) -> ok end, 1), ?line false = is_function(fun(_) -> ok end, 0), |