Merge branch 'ia/inets/httpd/tftpd/fd/OTP-12875/OTP-12898' into maint

* ia/inets/httpd/tftpd/fd/OTP-12875/OTP-12898:
  inets: Add test suite for socket_wrap feature
  inets: Ctify inets_SUITE
  inets: tftpd - Mend broken fd option
  inets: httpd - Mend broken fd option

9 files changed, 523 insertions, 158 deletions

diff --git a/lib/inets/src/http_lib/http_transport.erl b/lib/inets/src/http_lib/http_transport.erl
index bbe3ec9e4c..719dc4c425 100644
--- a/lib/inets/src/http_lib/http_transport.erl
+++ b/lib/inets/src/http_lib/http_transport.erl
@@ -269,7 +269,7 @@ get_socket_info(Addr, Port, Fd) ->
 	undefined ->
 	    {Port, sock_opts(Addr, BaseOpts)};
 	Fd -> 
-	    {0, sock_opts(Addr, [{fd, Fd} | BaseOpts])}
+	    {0, sock_opts([{fd, Fd} | BaseOpts])}
     end.
 	    
 %%-------------------------------------------------------------------------
diff --git a/lib/inets/src/http_server/httpd_sup.erl b/lib/inets/src/http_server/httpd_sup.erl
index de08624d44..f0b1942e2f 100644
--- a/lib/inets/src/http_server/httpd_sup.erl
+++ b/lib/inets/src/http_server/httpd_sup.erl
@@ -185,12 +185,16 @@ httpd_child_spec(ConfigFile, AcceptTimeoutDef, DebugDef) ->
     end.
 
 httpd_child_spec(Config, AcceptTimeout, Debug, Addr, Port, Profile) ->
-    Fd  = proplists:get_value(fd, Config, undefined),
-    case Port == 0 orelse Fd =/= undefined of
-	true ->
-	    httpd_child_spec_listen(Config, AcceptTimeout, Debug, Addr, Port, Profile);
-	false ->
-	    httpd_child_spec_nolisten(Config, AcceptTimeout, Debug, Addr, Port, Profile)
+    case get_fd(Port) of
+	{ok, Fd} ->
+	    case Port == 0 orelse Fd =/= undefined of
+		true ->
+		    httpd_child_spec_listen(Config, AcceptTimeout, Debug, Addr, Port, Profile);
+		false ->
+		    httpd_child_spec_nolisten(Config, AcceptTimeout, Debug, Addr, Port, Profile)
+	    end;
+	Error ->
+	    Error
     end.
 
 httpd_child_spec_listen(Config, AcceptTimeout, Debug, Addr, Port, Profile) ->
@@ -236,7 +240,7 @@ listen(Address, Port, Config)  ->
 	SocketType ->
 	    case http_transport:start(SocketType) of
 		ok ->
-		    Fd = proplists:get_value(fd, Config),
+		    {ok, Fd} = get_fd(Port),
 		    IpFamily =  proplists:get_value(ipfamily, Config, inet6fb4),
 		    case http_transport:listen(SocketType, Address, Port, Fd, IpFamily) of
 			{ok, ListenSocket} ->
@@ -355,3 +359,19 @@ ssl_ca_certificate_file(Config) ->
 	File ->
 	    [{cacertfile, File}]
     end.
+
+get_fd(0) ->
+    {ok, undefined};
+get_fd(Port) ->
+    FdKey = list_to_atom("httpd_" ++ integer_to_list(Port)),
+    case init:get_argument(FdKey) of
+	{ok, [[Value]]} ->
+	    case (catch list_to_integer(Value)) of
+		N when is_integer(N) ->
+		    {ok, N};
+		_ ->
+		    {error, {bad_descriptor, Value}}
+	    end;
+	_ ->
+	    {ok, undefined}
+    end.
diff --git a/lib/inets/src/tftp/tftp_engine.erl b/lib/inets/src/tftp/tftp_engine.erl
index fa44cd61ce..d0510e795b 100644
--- a/lib/inets/src/tftp/tftp_engine.erl
+++ b/lib/inets/src/tftp/tftp_engine.erl
@@ -128,8 +128,8 @@ daemon_start(Options) when is_list(Options) ->
 daemon_init(Config) when is_record(Config, config), 
                          is_pid(Config#config.parent_pid) ->
     process_flag(trap_exit, true),
-    UdpOptions = prepare_daemon_udp(Config),
-    case catch gen_udp:open(Config#config.udp_port, UdpOptions) of
+    {Port, UdpOptions} = prepare_daemon_udp(Config),
+    case catch gen_udp:open(Port, UdpOptions) of
         {ok, Socket} ->
             {ok, ActualPort} = inet:port(Socket),
             proc_lib:init_ack({ok, self()}),
@@ -157,7 +157,7 @@ prepare_daemon_udp(#config{udp_port = Port, udp_options = UdpOptions} = Config)
     case lists:keymember(fd, 1, UdpOptions) of
         true ->
             %% Use explicit fd
-            UdpOptions;
+            {Port, UdpOptions};
         false ->
             %% Use fd from setuid_socket_wrap, such as -tftpd_69
             InitArg = list_to_atom("tftpd_" ++ integer_to_list(Port)),
@@ -165,7 +165,7 @@ prepare_daemon_udp(#config{udp_port = Port, udp_options = UdpOptions} = Config)
                 {ok, [[FdStr]] = Badarg} when is_list(FdStr) ->
                     case catch list_to_integer(FdStr) of
                         Fd when is_integer(Fd) ->
-                            [{fd, Fd} | UdpOptions];
+                            {0, [{fd, Fd} | lists:keydelete(ip, 1, UdpOptions)]};
                         {'EXIT', _} ->
                             Text = lists:flatten(io_lib:format("Illegal prebound fd ~p: ~p", [InitArg, Badarg])),
                             print_debug_info(Config, daemon, open, ?ERROR(open, undef, Text, "")),
@@ -176,7 +176,7 @@ prepare_daemon_udp(#config{udp_port = Port, udp_options = UdpOptions} = Config)
                     print_debug_info(Config, daemon, open, ?ERROR(open, undef, Text, "")),
                     exit({badarg, {prebound_fd, InitArg, Badarg}});
                 error ->
-                    UdpOptions
+                    {Port, UdpOptions}
             end
     end.
 
diff --git a/lib/inets/test/Makefile b/lib/inets/test/Makefile
index cae77a05f3..607ec7c182 100644
--- a/lib/inets/test/Makefile
+++ b/lib/inets/test/Makefile
@@ -174,7 +174,8 @@ MODULES =                 		\
         inets_appup_test  		\
         tftp_test_lib			\
         tftp_SUITE                      \
-	uri_SUITE
+	uri_SUITE                       \
+	inets_socketwrap_SUITE
 
 
 EBIN = .
@@ -203,7 +204,7 @@ INETS_FILES = inets.config $(INETS_SPECS)
 # 	inets_ftp_suite \
 # 	inets_tftp_suite
 
-INETS_DATADIRS = inets_SUITE_data inets_sup_SUITE_data 
+INETS_DATADIRS = inets_SUITE_data inets_socketwrap_SUITE_data
 HTTPD_DATADIRS = httpd_test_data httpd_SUITE_data httpd_basic_SUITE_data old_httpd_SUITE_data
 HTTPC_DATADIRS = httpc_SUITE_data httpc_proxy_SUITE_data
 FTP_DATADIRS   = ftp_SUITE_data  
@@ -250,7 +251,7 @@ ERL_COMPILE_FLAGS += \
 # 1) INETS_PRIV_DIR must be created
 # ----------------------------------------------------
 
-tests debug opt: $(BUILDTARGET)
+tests debug opt: $(BUILDTARGET) 
 
 targets: $(TARGET_FILES)
 
diff --git a/lib/inets/test/inets_SUITE.erl b/lib/inets/test/inets_SUITE.erl
index c3586f09e3..928d9dc391 100644
--- a/lib/inets/test/inets_SUITE.erl
+++ b/lib/inets/test/inets_SUITE.erl
@@ -21,7 +21,6 @@
 -module(inets_SUITE).
 
 -include_lib("common_test/include/ct.hrl").
--include("test_server_line.hrl").
 -include("inets_test_lib.hrl").
 
 %% Note: This directive should only be used in test suites.
@@ -37,8 +36,12 @@ all() ->
 
 groups() -> 
     [{services_test, [],
-      [start_inets, start_httpc, start_httpd, start_ftpc,
-       start_tftpd]},
+      [start_inets, 
+       start_httpc, 
+       start_httpd, 
+       start_ftpc,
+       start_tftpd
+      ]},
      {app_test, [], [{inets_app_test, all}]},
      {appup_test, [], [{inets_appup_test, all}]}].
 
@@ -48,9 +51,6 @@ init_per_group(_GroupName, Config) ->
 end_per_group(_GroupName, Config) ->
     Config.
 
-
-
-
 %%--------------------------------------------------------------------
 %% Function: init_per_suite(Config) -> Config
 %% Config - [tuple()]
@@ -103,14 +103,8 @@ end_per_testcase(_, Config) ->
 %% Test cases starts here.
 %%-------------------------------------------------------------------------
 
-
-
-%%-------------------------------------------------------------------------
-
-start_inets(doc) ->
-    ["Test inets API functions"];
-start_inets(suite) ->
-    [];
+start_inets() ->
+    [{doc, "Test inets API functions"}].
 start_inets(Config) when is_list(Config) ->
     [_|_] = inets:service_names(),
 
@@ -134,134 +128,85 @@ start_inets(Config) when is_list(Config) ->
     ok = inets:start(permanent),
     ok = inets:stop().
 
-
 %%-------------------------------------------------------------------------
 
-start_httpc(doc) ->
-    ["Start/stop of httpc service"];
-start_httpc(suite) ->
-    [];
+start_httpc() ->
+    [{doc, "Start/stop of httpc service"}].
 start_httpc(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
-    tsp("start_httpc -> entry with"
-	"~n   Config: ~p", [Config]),
-
     PrivDir = ?config(priv_dir, Config),
 
-    tsp("start_httpc -> start (empty) inets"),
     ok = inets:start(),
-
-    tsp("start_httpc -> start httpc (as inets service) with profile foo"),
     {ok, Pid0} = inets:start(httpc, [{profile, foo}]),
 
-    tsp("start_httpc -> check running services"),
     Pids0 =  [ServicePid || {_, ServicePid} <- inets:services()],  
     true = lists:member(Pid0, Pids0),
     [_|_] = inets:services_info(),	
 
-    tsp("start_httpc -> stop httpc"),
     inets:stop(httpc, Pid0),
 
-    tsp("start_httpc -> sleep some"),
     test_server:sleep(100),
 
-    tsp("start_httpc -> check running services"),
     Pids1 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid0, Pids1),        
 
-    tsp("start_httpc -> start httpc (stand-alone) with profile bar"),
     {ok, Pid1} = inets:start(httpc, [{profile, bar}], stand_alone),
 
-    tsp("start_httpc -> check running services"),
     Pids2 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid1, Pids2),   
 
-    tsp("start_httpc -> stop httpc"),
     ok = inets:stop(stand_alone, Pid1),
     receive 
 	{'EXIT', Pid1, shutdown} ->
 	    ok
     after 100 ->
-	    tsf(stand_alone_not_shutdown)
+	    ct:fail(stand_alone_not_shutdown)
     end,
 
-    tsp("start_httpc -> stop inets"),
     ok = inets:stop(),
 
-    tsp("start_httpc -> unload inets"),
     application:load(inets),
-
-    tsp("start_httpc -> set inets environment (httpc profile foo)"),
     application:set_env(inets, services, [{httpc,[{profile, foo}, 
 						  {data_dir, PrivDir}]}]),
-
-    tsp("start_httpc -> start inets"),
     ok = inets:start(),
 
-    tsp("start_httpc -> check running services"),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
 
-    tsp("start_httpc -> unset inets env"),
     application:unset_env(inets, services),
-
-    tsp("start_httpc -> stop inets"),
     ok = inets:stop(),
-
-    tsp("start_httpc -> start (empty) inets"),
     ok = inets:start(),
 
-    tsp("start_httpc -> start inets httpc service with profile foo"),
     {ok, Pid3} = inets:start(httpc, [{profile, foo}]),
-
-    tsp("start_httpc -> stop inets service httpc with profile foo"),
     ok = inets:stop(httpc, foo),
-
-    tsp("start_httpc -> check running services"),
     Pids3 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid3, Pids3),      
-
-    tsp("start_httpc -> stop inets"),
-    ok = inets:stop(),
-
-    tsp("start_httpc -> done"),    
-    ok.
-
+    ok = inets:stop().
 
 %%-------------------------------------------------------------------------
 
-start_httpd(doc) ->
-    ["Start/stop of httpd service"];
-start_httpd(suite) ->
-    [];
+start_httpd() ->
+    [{doc, "Start/stop of httpd service"}].
 start_httpd(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
-    i("start_httpd -> entry with"
-      "~n   Config: ~p", [Config]),
     PrivDir = ?config(priv_dir, Config),
     HttpdConf = [{server_name, "httpd_test"}, {server_root, PrivDir},
-		 {document_root, PrivDir}, {bind_address, "localhost"}],
+		 {document_root, PrivDir}, {bind_address, any}],
     
-    i("start_httpd -> start inets"),
     ok = inets:start(),
-
-    i("start_httpd -> start httpd service"),
     {ok, Pid0} = inets:start(httpd, [{port, 0}, {ipfamily, inet} | HttpdConf]),
     Pids0 =  [ServicePid || {_, ServicePid} <- inets:services()],  
     true = lists:member(Pid0, Pids0),
     [_|_] = inets:services_info(),	
 
-    i("start_httpd -> stop httpd service"),
     inets:stop(httpd, Pid0),
     test_server:sleep(500),
     Pids1 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid0, Pids1),        
-    i("start_httpd -> start (stand-alone) httpd service"),
     {ok, Pid1} = 
 	inets:start(httpd, [{port, 0}, {ipfamily, inet} | HttpdConf], 
 		    stand_alone),
     Pids2 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid1, Pids2),   
-    i("start_httpd -> stop (stand-alone) httpd service"),
     ok = inets:stop(stand_alone, Pid1),
     receive 
 	{'EXIT', Pid1, shutdown} ->
@@ -269,7 +214,6 @@ start_httpd(Config) when is_list(Config) ->
     after 100 ->
 	    test_server:fail(stand_alone_not_shutdown)
     end,
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
     File0 = filename:join(PrivDir, "httpd.conf"),
     {ok, Fd0} =  file:open(File0, [write]),
@@ -277,17 +221,12 @@ start_httpd(Config) when is_list(Config) ->
     ok = file:write(Fd0, Str),
     file:close(Fd0),
 
-    i("start_httpd -> [application] load inets"),
     application:load(inets),
-    i("start_httpd -> [application] set httpd services env with proplist-file"),
     application:set_env(inets, 
 			services, [{httpd, [{proplist_file, File0}]}]),
-    i("start_httpd -> start inets"),
     ok = inets:start(),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
-    i("start_httpd -> [application] unset services env"),
     application:unset_env(inets, services),
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
     
     File1 = filename:join(PrivDir, "httpd_apache.conf"),
@@ -300,68 +239,46 @@ start_httpd(Config) when is_list(Config) ->
     file:write(Fd1, "Port 0\r\n"),
     file:close(Fd1),
 
-    i("start_httpd -> [application] load inets"),
     application:load(inets),
-    i("start_httpd -> [application] set httpd services env with file"),
     application:set_env(inets, 
 			services, [{httpd, [{file, File1}]}]),
-    i("start_httpd -> start inets"),
     ok = inets:start(),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
-    i("start_httpd -> [application] unset services env"),
     application:unset_env(inets, services),
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
     
     %% OLD format
-    i("start_httpd -> [application] load inets"),
     application:load(inets),
-    i("start_httpd -> [application] set httpd services OLD env"),
     application:set_env(inets, 
 			services, [{httpd, File1}]),
-    i("start_httpd -> start inets"),
     ok = inets:start(),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
-    i("start_httpd -> [application] unset services enc"),
     application:unset_env(inets, services),
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
-
-    i("start_httpd -> start inets"),
     ok = inets:start(),
-    i("start_httpd -> try (and fail) start httpd service - server_name"),
     {error, {missing_property, server_name}} = 
 	inets:start(httpd, [{port, 0},
 			    {server_root, PrivDir},
 			    {document_root, PrivDir}, 
 			    {bind_address, "localhost"}]),
-    i("start_httpd -> try (and fail) start httpd service - missing document_root"),
     {error, {missing_property, document_root}} = 
 	inets:start(httpd, [{port, 0},
 			    {server_name, "httpd_test"}, 
 			    {server_root, PrivDir},
 			    {bind_address, "localhost"}]),
-    i("start_httpd -> try (and fail) start httpd service - missing server_root"),
     {error, {missing_property, server_root}} = 
 	inets:start(httpd, [{port, 0},
 			    {server_name, "httpd_test"}, 
 			    {document_root, PrivDir},
 			    {bind_address, "localhost"}]),
-    i("start_httpd -> try (and fail) start httpd service - missing port"),
     {error, {missing_property, port}} = 
 	inets:start(httpd, HttpdConf),
-    i("start_httpd -> stop inets"),
-    ok = inets:stop(),
-    i("start_httpd -> done"),
-    ok.
-    
+    ok = inets:stop().
 
 %%-------------------------------------------------------------------------
 
 start_ftpc(doc) ->
-    ["Start/stop of ftpc service"];
-start_ftpc(suite) ->
-    [];
+    [{doc, "Start/stop of ftpc service"}];
 start_ftpc(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
     ok = inets:start(),
@@ -389,7 +306,7 @@ start_ftpc(Config) when is_list(Config) ->
 			{'EXIT', Pid1, shutdown} ->
 			    ok
 		    after 100 ->
-			    tsf(stand_alone_not_shutdown)
+			    ct:fail(stand_alone_not_shutdown)
 		    end,
 		    ok = inets:stop(),
 		    ok;
@@ -401,15 +318,11 @@ start_ftpc(Config) when is_list(Config) ->
 	throw:{error, not_found} ->
 	    {skip, "No available FTP servers"}
     end.
-	    
-
 
 %%-------------------------------------------------------------------------
 
-start_tftpd(doc) ->
-    ["Start/stop of tfpd service"];
-start_tftpd(suite) ->
-    [];
+start_tftpd() ->
+    [{doc, "Start/stop of tfpd service"}].
 start_tftpd(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
     ok = inets:start(),
@@ -441,16 +354,12 @@ start_tftpd(Config) when is_list(Config) ->
     application:unset_env(inets, services),
     ok = inets:stop().
 
-
 %%-------------------------------------------------------------------------
 
-httpd_reload(doc) ->
-    ["Reload httpd configuration without restarting service"];
-httpd_reload(suite) ->
-    [];
+httpd_reload() ->
+    [{doc, "Reload httpd configuration without restarting service"}].
 httpd_reload(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
-    i("httpd_reload -> starting"),
     PrivDir = ?config(priv_dir, Config),
     DataDir =  ?config(data_dir, Config),
     HttpdConf = [{server_name,   "httpd_test"}, 
@@ -458,23 +367,18 @@ httpd_reload(Config) when is_list(Config) ->
 		 {document_root, PrivDir}, 
 		 {bind_address,  "localhost"}],
 
-    i("httpd_reload -> start inets"),
-
     ok = inets:start(),
     test_server:sleep(5000),
-    i("httpd_reload -> inets started - start httpd service"),
 
-    {ok, Pid0} = inets:start(httpd, [{port, 0}, {ipfamily, inet} | HttpdConf]),
+    {ok, Pid0} = inets:start(httpd, [{port, 0}, 
+				     {ipfamily, inet} | HttpdConf]),
     test_server:sleep(5000),
-    i("httpd_reload -> httpd service started (~p) - get port", [Pid0]),
 
     [{port, Port0}] = httpd:info(Pid0, [port]),         
     test_server:sleep(5000),
-    i("httpd_reload -> Port: ~p - get document root", [Port0]),
 
     [{document_root, PrivDir}] =  httpd:info(Pid0, [document_root]),
     test_server:sleep(5000),
-    i("httpd_reload -> document root: ~p - reload config", [PrivDir]),
 
     ok = httpd:reload_config([{port, Port0}, {ipfamily, inet},
 			      {server_name, "httpd_test"}, 
@@ -482,11 +386,8 @@ httpd_reload(Config) when is_list(Config) ->
 			      {document_root, DataDir}, 
 			      {bind_address, "localhost"}], non_disturbing),
     test_server:sleep(5000),    
-    io:format("~w:~w:httpd_reload - reloaded - get document root~n", [?MODULE, ?LINE]),
-
     [{document_root, DataDir}] =  httpd:info(Pid0, [document_root]),
     test_server:sleep(5000),    
-    i("httpd_reload -> document root: ~p - reload config", [DataDir]),
 
     ok = httpd:reload_config([{port, Port0}, {ipfamily, inet},
 			      {server_name, "httpd_test"}, 
@@ -539,23 +440,5 @@ httpd_reload(Config) when is_list(Config) ->
     
     ok = inets:stop(httpd, Pid1),
     application:unset_env(inets, services),
-    ok = inets:stop(),
-    i("httpd_reload -> starting"),
-    ok.
-    
-
-tsf(Reason) ->
-    test_server:fail(Reason).
-
-tsp(F) ->
-    tsp(F, []).
-tsp(F, A) ->
-    Timestamp = inets_lib:formated_timestamp(),
-    test_server:format("** ~s ** ~p ~p:" ++ F ++ "~n", [Timestamp, self(), ?MODULE | A]).
-
-i(F) ->
-    i(F, []).
+    ok = inets:stop().
 
-i(F, A) ->
-    Timestamp = inets_lib:formated_timestamp(),
-    io:format("*** ~s ~w:" ++ F ++ "~n", [Timestamp, ?MODULE | A]).
diff --git a/lib/inets/test/inets_socketwrap_SUITE.erl b/lib/inets/test/inets_socketwrap_SUITE.erl
new file mode 100644
index 0000000000..cfbda3ccf5
--- /dev/null
+++ b/lib/inets/test/inets_socketwrap_SUITE.erl
@@ -0,0 +1,154 @@
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 1997-2015. All Rights Reserved.
+%%
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
+%%
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
+%%
+%% %CopyrightEnd%
+%%
+%%
+-module(inets_socketwrap_SUITE).
+
+-include_lib("common_test/include/ct.hrl").
+-include("inets_test_lib.hrl").
+
+%% Note: This directive should only be used in test suites.
+-compile(export_all).
+
+suite() -> 
+    [{ct_hooks,[ts_install_cth]}].
+
+all() -> 
+    [start_httpd_fd, start_tftpd_fd].
+
+init_per_suite(Config) ->
+    case os:type() of
+	{unix, linux} ->
+	    Config;
+	_ ->
+	    {skip, linux_feature}
+    end.
+
+end_per_suite(_Config) ->
+    ok.
+
+init_per_group(_GroupName, Config) ->
+    Config.
+
+end_per_group(_GroupName, Config) ->
+    Config.
+
+init_per_testcase(Case, Config) ->
+    end_per_testcase(Case, Config),
+    Config.
+
+end_per_testcase(_, Config) ->
+    inets:stop(),
+    Config.
+
+%%-------------------------------------------------------------------------
+start_httpd_fd() ->
+    [{doc, "Start/stop of httpd service with socket wrapper"}].
+start_httpd_fd(Config) when is_list(Config) ->
+    PrivDir = ?config(priv_dir, Config),
+    DataDir = ?config(data_dir, Config),
+    HttpdConf = [{port, 80}, {ipfamily, inet},
+		 {server_name, "httpd_fd_test"}, {server_root, PrivDir},
+		 {document_root, PrivDir}, {bind_address, any}],
+    case setup_node_info(node()) of
+	{skip, _}  = Skip ->
+	    Skip;
+	{Node, NodeArg} ->
+	    InetPort = inets_test_lib:inet_port(node()),
+	    ct:pal("Node: ~p  Port ~p~n", [Node, InetPort]),
+      	    Wrapper = filename:join(DataDir, "setuid_socket_wrap"),
+	    Cmd = Wrapper ++  
+		" -s -httpd_80,0:" ++ integer_to_list(InetPort) 
+		++ " -p " ++ os:find_executable("erl") ++
+		" -- " ++ NodeArg, 
+	    ct:pal("cmd: ~p~n", [Cmd]),
+	    case open_port({spawn, Cmd}, [stderr_to_stdout]) of 
+	    	Port when is_port(Port) ->
+		    wait_node_up(Node, 10),
+		    ct:pal("~p", [rpc:call(Node, init, get_argument, [httpd_80])]),
+		    ok  = rpc:call(Node, inets, start, []),
+		    {ok, Pid} = rpc:call(Node, inets, start, [httpd, HttpdConf]),
+		    [{port, InetPort}] = rpc:call(Node, httpd, info, [Pid, [port]]),
+		    rpc:call(Node, erlang, halt, []);
+		_  ->
+		    ct:fail(open_port_failed)
+	    end
+    end.
+%%-------------------------------------------------------------------------
+start_tftpd_fd() ->
+    [{doc, "Start/stop of tfpd service with socket wrapper"}].
+start_tftpd_fd(Config) when is_list(Config) ->
+    DataDir = ?config(data_dir, Config),
+    case setup_node_info(node()) of
+	{skip, _}  = Skip ->
+	    Skip;
+	{Node, NodeArg} ->
+	    InetPort = inets_test_lib:inet_port(node()),
+	    ct:pal("Node: ~p~n", [Node]),
+      	    Wrapper = filename:join(DataDir, "setuid_socket_wrap"),
+	    Cmd = Wrapper ++  
+		" -s -tftpd_69,0:" ++ integer_to_list(InetPort)
+		++ " -p " ++ os:find_executable("erl") ++
+		" -- " ++ NodeArg, 
+	    ct:pal("cmd: ~p~n", [Cmd]),
+	    case open_port({spawn, Cmd}, [stderr_to_stdout]) of 
+	    	Port when is_port(Port) ->
+		    wait_node_up(Node, 10),
+		    ct:pal("~p", [rpc:call(Node, init, get_argument, [tftpd_69])]),
+		    ok = rpc:call(Node, inets, start, []),
+		    {ok, Pid} = rpc:call(Node, inets, start, 
+					 [tftpd,[{host, "localhost"}]]),
+		    {ok, Info} = rpc:call(Node, tftp, info, [Pid]),
+		    {value,{port, InetPort}} = lists:keysearch(port, 1, Info),
+		    rpc:call(Node, erlang, halt, []);
+		_  ->
+		    ct:fail(open_port_failed)
+	    end
+    end.
+%%-------------------------------------------------------------------------
+%% Internal functions
+%%-------------------------------------------------------------------------
+setup_node_info(nonode@nohost) ->
+    {skip, needs_distributed_node};
+setup_node_info(Node) ->
+    Static = "-detached -noinput",
+    Name = "inets_fd_test",
+    NameSw = case net_kernel:longnames() of
+		 false -> "-sname ";
+		 _ -> "-name "
+		     end,
+    StrNode = 
+	Static ++ " "
+	++ NameSw ++ " " ++ Name ++ " "
+	++ "-setcookie " ++ atom_to_list(erlang:get_cookie()),
+	    [_, Location] = string:tokens(atom_to_list(Node), "$@"),
+    TestNode =  Name ++ "@" ++ Location, 
+    {list_to_atom(TestNode), StrNode}.
+
+wait_node_up(Node, 0) ->
+    ct:fail({failed_to_start_node, Node});
+wait_node_up(Node, N) ->
+    ct:pal("(Node ~p: net_adm:ping(~p)~n", [node(), Node]),
+    case net_adm:ping(Node) of
+	pong ->
+	    ok;
+	pang ->
+	    ct:sleep(5000),
+	    wait_node_up(Node, N-1)
+    end.
diff --git a/lib/inets/test/inets_socketwrap_SUITE_data/Makefile.src b/lib/inets/test/inets_socketwrap_SUITE_data/Makefile.src
new file mode 100644
index 0000000000..0933815b58
--- /dev/null
+++ b/lib/inets/test/inets_socketwrap_SUITE_data/Makefile.src
@@ -0,0 +1,39 @@
+# 
+# %CopyrightBegin%
+# 
+# Copyright Ericsson AB 2015-2015. All Rights Reserved.
+# 
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# 
+# %CopyrightEnd%
+#
+
+CC = @CC@
+LD = @LD@
+CFLAGS = @CFLAGS@
+CROSSLDFLAGS = @CROSSLDFLAGS@
+
+PROGS = setuid_socket_wrap@exe@
+
+.PHONY: all
+@IFEQ@ (@os@, linux-gnu)
+all: $(PROGS)
+@ELSE@
+all:
+@ENDIF@
+
+setuid_socket_wrap@exe@: setuid_socket_wrap@obj@
+	$(LD) $(CROSSLDFLAGS) -o setuid_socket_wrap setuid_socket_wrap@obj@ @LIBS@
+
+setuid_socket_wrap@obj@: setuid_socket_wrap.c
+	$(CC) -c $(CFLAGS) -o setuid_socket_wrap@obj@ setuid_socket_wrap.c
diff --git a/lib/inets/test/inets_socketwrap_SUITE_data/setuid_socket_wrap.c b/lib/inets/test/inets_socketwrap_SUITE_data/setuid_socket_wrap.c
new file mode 100644
index 0000000000..b28f6b1c08
--- /dev/null
+++ b/lib/inets/test/inets_socketwrap_SUITE_data/setuid_socket_wrap.c
@@ -0,0 +1,259 @@
+/*
+ * %CopyrightBegin%
+ * 
+ * Copyright Ericsson AB 1999-2009. All Rights Reserved.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * 
+ * %CopyrightEnd%
+ */
+/*
+ * setuid_socket_wrap.c
+ *
+ * ./a.out [-s [tag,][addr]:[port]]* [-d [tag,][addr]:[port]]* 
+ *         [-r [tag,]proto]* [-p erl_path]* -- program args
+ *
+ * Where: -s = stream socket, -d datagram socket and -r means raw socket.
+ *
+ */
+#ifdef HAVE_CONFIG_H
+#  include "config.h"
+#endif
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <string.h>
+#include <ctype.h>
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
+#include <arpa/inet.h>
+#include <netdb.h>
+
+#ifndef INADDR_NONE
+#define INADDR_NONE 0xffffffff
+#endif
+
+struct sock_list {
+    struct sock_list *next;
+    int fd;
+    int type;
+    int protocol;
+    struct sockaddr_in addr;
+    char *arg;
+};
+
+int parse_addr(addr, str)
+    struct sockaddr_in *addr;
+    char *str;
+{
+    int port = 0;
+    char *cp;
+    struct hostent *hp;
+    struct servent *se;
+
+    if ((cp = strrchr(str, (int)':')) != NULL)
+        *cp++ = '\0';
+    if (cp) {
+        if (!isdigit((int)cp[0])) {
+            if ((se = getservbyname(cp, "tcp")) != NULL) {
+                port = ntohs(se->s_port);
+	    } else {
+		fprintf(stderr, "unknown port %s\n", cp);
+		return -1;
+	    }
+        } else {
+            port = atoi(cp);
+        }
+    }
+    if (port < 0 || port > 0xffff) {
+	fprintf(stderr, "bad port number %d\n", port);
+        return -1;
+    }
+    
+    bzero(addr, sizeof(*addr));
+    addr->sin_family = AF_INET;
+    addr->sin_port = htons(port);
+    if (*str == '\000') {
+	addr->sin_addr.s_addr = INADDR_ANY;
+    } else {
+	if ((addr->sin_addr.s_addr = inet_addr(str)) == INADDR_NONE) {
+	    if ((hp = gethostbyname(str)) == NULL) {
+		fprintf(stderr, "\"%s\" unknown host or address!\n", str);
+		return -1;
+	    } else {
+		bcopy(hp->h_addr_list[0], &addr->sin_addr.s_addr,hp->h_length);
+	    }
+	}
+    }
+    return 0;
+}
+
+struct sock_list *new_entry(type, argstr)
+    int type;
+    char *argstr;
+{
+    struct sock_list *sle;
+    char *cp;
+    
+    sle = (struct sock_list *)malloc(sizeof(struct sock_list));
+    if (!sle)
+	return NULL;
+    sle->next = NULL;
+    sle->fd = -1;
+
+    if ((cp = strchr(argstr, (int)',')) != NULL) {
+	*cp++ = '\0';
+	sle->arg = argstr;
+	argstr = cp;
+    } else {
+	sle->arg = "-fd";
+    }
+    sle->type = type;
+    switch (type) {
+        case SOCK_RAW: {
+	    struct protoent *pe;
+	    pe = getprotobyname(argstr);
+	    if (!pe) {
+		fprintf(stderr, "Unknown protocol: %s\n", argstr);
+		free(sle);
+		return NULL;
+	    }
+	    sle->protocol = pe->p_proto;
+	    break;
+	}
+        case SOCK_STREAM:
+        case SOCK_DGRAM:
+	    sle->protocol = 0;
+	    if (parse_addr(&sle->addr, argstr) < 0) {
+		free(sle);
+		return NULL;
+	    }
+	    break;
+    }
+    return sle;
+}
+
+int open_socket(sle)
+    struct sock_list *sle;
+{
+    sle->fd = socket(AF_INET, sle->type, sle->protocol);
+    if (sle->fd < 0) {
+	perror("socket");
+	return -1;
+    }
+    if (sle->type != SOCK_RAW) {
+#if 0
+	printf("binding fd %d to %s:%d\n", sle->fd,
+	       inet_ntoa(sle->addr.sin_addr), ntohs(sle->addr.sin_port));
+#endif
+	if (bind(sle->fd, (struct sockaddr *)&sle->addr, sizeof(sle->addr))<0){
+	    perror("bind");
+	    close(sle->fd);
+	    return -1;
+	}
+    }
+    return sle->fd;
+}
+
+int main(argc, argv)
+    int argc;
+    char *argv[];
+{
+    struct sock_list *sl = NULL, *sltmp = NULL;
+    int count = 0;
+    int c;
+    char *run_prog = NULL;
+    
+    while ((c = getopt(argc, argv, "s:d:r:p:")) != EOF)
+	switch (c) {
+	case 's':
+	    sltmp = new_entry(SOCK_STREAM, optarg);
+	    if (!sltmp) {
+		exit(1);
+	    }
+	    sltmp->next = sl;
+	    sl = sltmp;
+	    count++;
+	    break;
+	case 'd':
+	    sltmp = new_entry(SOCK_DGRAM, optarg);
+	    if (!sltmp) {
+		exit(1);
+	    }
+	    sltmp->next = sl;
+	    sl = sltmp;
+	    count++;
+	    break;
+	case 'r':
+	    sltmp = new_entry(SOCK_RAW, optarg);
+	    if (!sltmp) {
+		exit(1);
+	    }
+	    sltmp->next = sl;
+	    sl = sltmp;
+	    count++;
+	    break;
+	case 'p':
+	  run_prog = optarg;
+	  break;
+	default:
+	    exit(1);
+	}
+    argc -= optind;
+    argv += optind;
+
+    for(sltmp = sl; sltmp != NULL; sltmp = sltmp->next)
+	if (open_socket(sltmp) < 0) {
+	    fprintf(stderr, "failed to create socket!\n");
+	    exit(1);
+	}
+
+    setuid(getuid());
+    
+    {
+	int i;
+	char **newargv;
+	char *run_prog_name;
+
+	newargv = (char **)malloc((1 + 2*count + argc + 1) * sizeof(char*));
+
+	if ((run_prog_name = strrchr(run_prog, (int)'/')) == NULL)
+	    run_prog_name = run_prog;
+	else
+	    run_prog_name++;
+
+	i = 0;
+	newargv[i++] = run_prog_name;
+
+	for (; argc; argc--, argv++, i++)
+	    newargv[i] = *argv;
+	for(sltmp = sl; sltmp != NULL; ) {
+	    char *fd_str = (char *)malloc(8);
+	    if (!fd_str) exit(1);
+	    sprintf(fd_str, "%d", sltmp->fd);
+	    if (sltmp->arg && *(sltmp->arg))
+		newargv[i++] = sltmp->arg;
+	    newargv[i++] = fd_str;
+	    sl = sltmp;
+	    sltmp = sltmp->next;
+	    free(sl);
+	}
+	newargv[i] = (char *)NULL;
+	execv(run_prog, newargv);
+	perror("exec");
+	exit(1);
+    }
+    exit(0);
+}
diff --git a/lib/inets/test/inets_test_lib.erl b/lib/inets/test/inets_test_lib.erl
index b471dcf784..f1185f7574 100644
--- a/lib/inets/test/inets_test_lib.erl
+++ b/lib/inets/test/inets_test_lib.erl
@@ -563,3 +563,12 @@ stop_apps(Apps) ->
 			  application:stop(App)
 		  end, Apps).
 
+inet_port(Node) ->
+    {Port, Socket} = do_inet_port(Node),
+     rpc:call(Node, gen_tcp, close, [Socket]),
+     Port.
+
+do_inet_port(Node) ->
+    {ok, Socket} = rpc:call(Node, gen_tcp, listen, [0, [{reuseaddr, true}]]),
+    {ok, Port} = rpc:call(Node, inet, port, [Socket]),
+    {Port, Socket}.