aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2017-08-22 08:09:10 +0200
committerBjörn Gustavsson <[email protected]>2017-08-22 15:26:24 +0200
commitd8ffcdd05ec718225d6888ab4919443a87cd7c6c (patch)
tree60868494a19c6b953844f46e32a3ff8dc78d2df5
parentf392006644991074d2c4d5055773409c5e0503d7 (diff)
downloadotp-d8ffcdd05ec718225d6888ab4919443a87cd7c6c.tar.gz
otp-d8ffcdd05ec718225d6888ab4919443a87cd7c6c.tar.bz2
otp-d8ffcdd05ec718225d6888ab4919443a87cd7c6c.zip
Fix disksup:get_disksup_data() for High Sierra
On macOS 10.13 (High Sierra), disksup cannot grab information for any disks that use the new APFS file system. The reason is that the invocation of /bin/df explicitly limits the type of file systems to show: /bin/df -i -k -t ufs,hfs Add 'apfs' to also look at disks with APFS: /bin/df -i -k -t ufs,hfs,apfs That also works on older versions of macOS. An alternative solution would be to use the -l flag to only show local file systems. However, that would mean that USB memory sticks would also show up, and it might not be desirable to monitor them. https://bugs.erlang.org/browse/ERL-461
-rw-r--r--lib/os_mon/src/disksup.erl2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/os_mon/src/disksup.erl b/lib/os_mon/src/disksup.erl
index 492e4814da..044604b000 100644
--- a/lib/os_mon/src/disksup.erl
+++ b/lib/os_mon/src/disksup.erl
@@ -285,7 +285,7 @@ check_disk_space({unix, sunos4}, Port, Threshold) ->
Result = my_cmd("df", Port),
check_disks_solaris(skip_to_eol(Result), Threshold);
check_disk_space({unix, darwin}, Port, Threshold) ->
- Result = my_cmd("/bin/df -i -k -t ufs,hfs", Port),
+ Result = my_cmd("/bin/df -i -k -t ufs,hfs,apfs", Port),
check_disks_susv3(skip_to_eol(Result), Threshold).
% This code works for Linux and FreeBSD as well