diff options
author | Björn Gustavsson <[email protected]> | 2018-09-01 10:57:33 +0200 |
---|---|---|
committer | Björn Gustavsson <[email protected]> | 2018-09-03 10:47:24 +0200 |
commit | 47a2ff39ac75c69b41f90f05a63fd9a2e6c0b36a (patch) | |
tree | f6ac446058b62541b7ec14dfc28a21a06c5cbc7e /erts/emulator/beam/beam_debug.c | |
parent | 31e7b5ab0b72acbbca649b99ade82bba145cc390 (diff) | |
download | otp-47a2ff39ac75c69b41f90f05a63fd9a2e6c0b36a.tar.gz otp-47a2ff39ac75c69b41f90f05a63fd9a2e6c0b36a.tar.bz2 otp-47a2ff39ac75c69b41f90f05a63fd9a2e6c0b36a.zip |
Introduce a put_tuple2 instruction
Sometimes when building a tuple, there is no way to avoid an
extra `move` instruction. Consider this code:
make_tuple(A) -> {ok,A}.
The corresponding BEAM code looks like this:
{test_heap,3,1}.
{put_tuple,2,{x,1}}.
{put,{atom,ok}}.
{put,{x,0}}.
{move,{x,1},{x,0}}.
return.
To avoid overwriting the source register `{x,0}`, a `move`
instruction is necessary.
The problem doesn't exist when building a list:
%% build_list(A) -> [A].
{test_heap,2,1}.
{put_list,{x,0},nil,{x,0}}.
return.
Introduce a new `put_tuple2` instruction that builds a tuple in a
single instruction, so that the `move` instruction can be eliminated:
%% make_tuple(A) -> {ok,A}.
{test_heap,3,1}.
{put_tuple2,{x,0},{list,[{atom,ok},{x,0}]}}.
return.
Note that the BEAM loader already combines `put_tuple` and `put`
instructions into an internal instruction similar to `put_tuple2`.
Therefore the introduction of the new instruction will not speed up
execution of tuple building itself, but it will be less work for
the loader to load the new instruction.
Diffstat (limited to 'erts/emulator/beam/beam_debug.c')
-rw-r--r-- | erts/emulator/beam/beam_debug.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/erts/emulator/beam/beam_debug.c b/erts/emulator/beam/beam_debug.c index 9633de2021..b33aab7eee 100644 --- a/erts/emulator/beam/beam_debug.c +++ b/erts/emulator/beam/beam_debug.c @@ -786,8 +786,8 @@ print_op(fmtfn_t to, void *to_arg, int op, int size, BeamInstr* addr) } } break; - case op_i_put_tuple_xI: - case op_i_put_tuple_yI: + case op_put_tuple2_xI: + case op_put_tuple2_yI: case op_new_map_dtI: case op_update_map_assoc_sdtI: case op_update_map_exact_jsdtI: |