Merge branch 'bjorn/deprecate-tuple-funs/OTP-9649'

* bjorn/deprecate-tuple-funs/OTP-9649:
  erts: Warn the first time a tuple fun is called
  otp_mibs: Eliminate use of tuple fun
  os_mon: Eliminate use of tuple fun
  asn1: Eliminate use of tuple fun
  parsetools: Eliminate use of tuple fun
  mnesia tests: Eliminate use of tuple fun
  snmp: Eliminate use of tuple fun
  wrap_log_reader_SUITE: Eliminate use of tuple fun
  big_SUITE: Eliminate use of tuple fun
  file_SUITE: Eliminate use of tuple fun
  fprof: Eliminate use of tuple fun
  xref_compiler: Eliminate use of tuple fun
  shell: Eliminate use of tuple funs
  erl_eval: Eliminate use of tuple funs
  user_sup: Eliminate use of tuple fun

1 files changed, 27 insertions, 0 deletions

diff --git a/erts/emulator/beam/beam_emu.c b/erts/emulator/beam/beam_emu.c
index 9b2b47ffb7..c65b2be106 100644
--- a/erts/emulator/beam/beam_emu.c
+++ b/erts/emulator/beam/beam_emu.c
@@ -234,6 +234,12 @@ BeamInstr beam_return_trace[1];      /* OpCode(i_return_trace) */
 BeamInstr beam_exception_trace[1];   /* UGLY also OpCode(i_return_trace) */
 BeamInstr beam_return_time_trace[1]; /* OpCode(i_return_time_trace) */
 
+
+/*
+ * We should warn only once for tuple funs.
+ */
+static erts_smp_atomic_t warned_for_tuple_funs;
+
 /*
  * All Beam instructions in numerical order.
  */
@@ -1015,6 +1021,7 @@ init_emulator(void)
 #if defined(VXWORKS)
     init_done = 0;
 #endif
+    erts_smp_atomic_init_nob(&warned_for_tuple_funs, (erts_aint_t) 0);
     process_main();
 }
 
@@ -6188,6 +6195,26 @@ call_fun(Process* p,		/* Current process. */
 	if (!is_atom(module) || !is_atom(function)) {
 	    goto badfun;
 	}
+
+	/*
+	 * If this is the first time a tuple fun is used,
+	 * send a warning to the logger.
+	 */
+	if (erts_smp_atomic_xchg_nob(&warned_for_tuple_funs,
+				     (erts_aint_t) 1) == 0) {
+	    erts_dsprintf_buf_t* dsbufp;
+
+	    dsbufp = erts_create_logger_dsbuf();
+	    erts_dsprintf(dsbufp, "Call to tuple fun {%T,%T}.\n\n"
+			  "Tuple funs are deprecated and will be removed "
+			  "in R16. Use \"fun M:F/A\" instead, for example "
+			  "\"fun %T:%T/%d\".\n\n"
+			  "(This warning will only be shown the first time "
+			  "a tuple fun is called.)\n",
+			  module, function, module, function, arity);
+	    erts_send_warning_to_logger(p->group_leader, dsbufp);
+	}
+
 	if ((ep = erts_find_export_entry(module, function, arity)) == NULL) {
 	    ep = erts_find_export_entry(erts_proc_get_error_handler(p),
 					am_undefined_function, 3);