erts: Refactor LCNT

1 files changed, 31 insertions, 49 deletions

diff --git a/erts/emulator/beam/erl_bif_info.c b/erts/emulator/beam/erl_bif_info.c
index 397c68e199..8a675302b2 100644
--- a/erts/emulator/beam/erl_bif_info.c
+++ b/erts/emulator/beam/erl_bif_info.c
@@ -4296,59 +4296,41 @@ BIF_RETTYPE erts_debug_lock_counters_1(BIF_ALIST_1)
 
 	BIF_RET(am_ok);
     } else if (is_tuple(BIF_ARG_1)) {
-	Eterm* tp = tuple_val(BIF_ARG_1);
+        Eterm* ptr = tuple_val(BIF_ARG_1);
+
+        if ((arityval(ptr[0]) == 2) && (ptr[2] == am_false || ptr[2] == am_true)) {
+            int lock_opt = 0, enable = (ptr[2] == am_true) ? 1 : 0;
+            if (ERTS_IS_ATOM_STR("copy_save", ptr[1])) {
+                lock_opt = ERTS_LCNT_OPT_COPYSAVE;
+            } else if (ERTS_IS_ATOM_STR("process_locks", ptr[1])) {
+                lock_opt = ERTS_LCNT_OPT_PROCLOCK;
+            } else if (ERTS_IS_ATOM_STR("port_locks", ptr[1])) {
+                lock_opt = ERTS_LCNT_OPT_PORTLOCK;
+            } else if (ERTS_IS_ATOM_STR("suspend", ptr[1])) {
+                lock_opt = ERTS_LCNT_OPT_SUSPEND;
+            } else if (ERTS_IS_ATOM_STR("location", ptr[1])) {
+                lock_opt = ERTS_LCNT_OPT_LOCATION;
+            } else {
+                BIF_ERROR(BIF_P, BADARG);
+            }
 
-	switch (arityval(tp[0])) {
-	    case 2: {
-		int opt = 0;
-		int val = 0;
-		if (ERTS_IS_ATOM_STR("copy_save", tp[1])) {
-		    opt = ERTS_LCNT_OPT_COPYSAVE;
-		} else if (ERTS_IS_ATOM_STR("process_locks", tp[1])) {
-		    opt = ERTS_LCNT_OPT_PROCLOCK;
-		} else if (ERTS_IS_ATOM_STR("port_locks", tp[1])) {
-		    opt = ERTS_LCNT_OPT_PORTLOCK;
-		} else if (ERTS_IS_ATOM_STR("suspend", tp[1])) {
-		    opt = ERTS_LCNT_OPT_SUSPEND;
-		} else if (ERTS_IS_ATOM_STR("location", tp[1])) {
-		    opt = ERTS_LCNT_OPT_LOCATION;
-		} else {
-		    BIF_ERROR(BIF_P, BADARG);
-		}
-		if (tp[2] == am_true) {
-		    val = 1;
-		} else if (tp[2] == am_false) {
-		    val = 0;
-		} else {
-		    BIF_ERROR(BIF_P, BADARG);
-		}
+            erts_smp_proc_unlock(BIF_P, ERTS_PROC_LOCK_MAIN);
+            erts_smp_thr_progress_block();
 
-		erts_smp_proc_unlock(BIF_P, ERTS_PROC_LOCK_MAIN);
-		erts_smp_thr_progress_block();
-		
-		if (val) {
-		    res = erts_lcnt_set_rt_opt(opt) ? am_true : am_false;
-		} else {
-		    res = erts_lcnt_clear_rt_opt(opt) ? am_true : am_false;
-		}
+            if (enable) res = erts_lcnt_set_rt_opt(lock_opt) ? am_true : am_false;
+            else res = erts_lcnt_clear_rt_opt(lock_opt) ? am_true : am_false;
+            
 #ifdef ERTS_SMP
-		if (res != tp[2]) {
-		    if (opt == ERTS_LCNT_OPT_PORTLOCK) {
-			erts_lcnt_enable_io_lock_count(val);
-		    } else if (opt == ERTS_LCNT_OPT_PROCLOCK) {
-			erts_lcnt_enable_proc_lock_count(val);
-		    }
-		}
+            if (res != ptr[2] && lock_opt == ERTS_LCNT_OPT_PORTLOCK) {
+                erts_lcnt_enable_io_lock_count(enable);
+            } else if (res != ptr[2] && lock_opt == ERTS_LCNT_OPT_PROCLOCK) {
+                erts_lcnt_enable_proc_lock_count(enable);
+            }
 #endif
-		erts_smp_thr_progress_unblock();
-		erts_smp_proc_lock(BIF_P, ERTS_PROC_LOCK_MAIN);
-		BIF_RET(res);
-		break;
-	    }
-     
-	    default:
-	    break;
-	}
+            erts_smp_thr_progress_unblock();
+            erts_smp_proc_lock(BIF_P, ERTS_PROC_LOCK_MAIN);
+            BIF_RET(res);
+        }
     } 
 
 #endif