diff options
author | Boshan Sun <[email protected]> | 2017-11-20 10:21:29 -0800 |
---|---|---|
committer | Boshan Sun <[email protected]> | 2017-11-20 10:21:29 -0800 |
commit | 23e511d470e6795799c29b5ccb2ab6a17589e543 (patch) | |
tree | ebf6266e2e0b87c58d6b36c5cc6e24da5fe9cf1c /erts/emulator/beam/erl_thr_progress.h | |
parent | 4c736d27d32b5334d8ba978c100a591caf0ac604 (diff) | |
download | otp-23e511d470e6795799c29b5ccb2ab6a17589e543.tar.gz otp-23e511d470e6795799c29b5ccb2ab6a17589e543.tar.bz2 otp-23e511d470e6795799c29b5ccb2ab6a17589e543.zip |
Fix integer overflow when set a large maximum value for atom table
When setting maximum atom table size using +t option, there will be a
integer overflow for a large size.
$ erl +t2147482625
ll_alloc: Cannot allocate 18446744073692774400 bytes of memory
(of type "atom_tab").
The overflow is caused by the arithmetic operations on int type.
When 2147482625 + 1024 it will become -2147483647 due to the signed
integerger overflow. Then the result will be resized to Uint type, which
is a unsigned long type, the negative int will first be expand to 64
bits long via sign extension, then change to unsigned type, which
becomes 18446744073692774400.
The fix is done by convert `limit` to Uint type before doing any
arithmetic operation. This will expand variable to 64 bits long type via
zero extension, then the following operation are all positive, therefore
no overflow will happen.
Note: here we assume the int `limit` passed in is always positive. If
some future change cause the `limit` passed in maybe negative, then the
current fix will also cause overflow.
Diffstat (limited to 'erts/emulator/beam/erl_thr_progress.h')
0 files changed, 0 insertions, 0 deletions