Merge branch 'bjorn/erts/minor-fixes' into dev

* bjorn/erts/minor-fixes:
  BEAM loader: Add an assertion to check for overflowed code space
  beam_emu: Eliminate redundant #ifdef
  beam_emu: Remove unnecessary decrement of I in "case_end r"

2 files changed, 13 insertions, 17 deletions

diff --git a/erts/emulator/beam/beam_emu.c b/erts/emulator/beam/beam_emu.c
index 16741aa2d7..12a8022861 100644
--- a/erts/emulator/beam/beam_emu.c
+++ b/erts/emulator/beam/beam_emu.c
@@ -3424,7 +3424,6 @@ void process_main(void)
 
     OpCase(case_end_r):
 	case_end_val = r(0);
-	I--;
 
     do_case_end:
 	c_p->fvalue = case_end_val;
@@ -5865,9 +5864,6 @@ build_stacktrace(Process* c_p, Eterm exc) {
     Eterm  args;
     int    depth;
     BeamInstr* current;
-#if HALFWORD_HEAP
-    BeamInstr current_buff[3];
-#endif
     Eterm  Where = NIL;
     Eterm *next_p = &Where;
 
@@ -5897,14 +5893,7 @@ build_stacktrace(Process* c_p, Eterm exc) {
      * (e.g. spawn_link(erlang, abs, [1])).
      */
     if (current == NULL) {
-#if HALFWORD_HEAP
-	current = current_buff;
-	current[0] = (BeamInstr) c_p->initial[0];
-	current[1] = (BeamInstr) c_p->initial[1];
-	current[2] = (BeamInstr) c_p->initial[2];
-#else
 	current = c_p->initial;
-#endif
 	args = am_true; /* Just in case */
     } else {
 	args = get_args_from_exc(exc);
diff --git a/erts/emulator/beam/beam_load.c b/erts/emulator/beam/beam_load.c
index 4e0d19dafa..788cb4209c 100644
--- a/erts/emulator/beam/beam_load.c
+++ b/erts/emulator/beam/beam_load.c
@@ -3770,25 +3770,32 @@ freeze_code(LoaderState* stp)
     CHKBLK(ERTS_ALC_T_CODE,code);
     if (compile_size) {
 	byte* compile_info = str_table + strtab_size + attr_size;
-    CHKBLK(ERTS_ALC_T_CODE,code);
+	CHKBLK(ERTS_ALC_T_CODE,code);
 	sys_memcpy(compile_info, stp->chunks[COMPILE_CHUNK].start,
 	       stp->chunks[COMPILE_CHUNK].size);
-    CHKBLK(ERTS_ALC_T_CODE,code);
+
+	CHKBLK(ERTS_ALC_T_CODE,code);
 	code[MI_COMPILE_PTR] = (BeamInstr) compile_info;
-    CHKBLK(ERTS_ALC_T_CODE,code);
+	CHKBLK(ERTS_ALC_T_CODE,code);
 	code[MI_COMPILE_SIZE] = (BeamInstr) stp->chunks[COMPILE_CHUNK].size;
-    CHKBLK(ERTS_ALC_T_CODE,code);
+	CHKBLK(ERTS_ALC_T_CODE,code);
 	decoded_size = erts_decode_ext_size(compile_info, compile_size, 0);
-    CHKBLK(ERTS_ALC_T_CODE,code);
+	CHKBLK(ERTS_ALC_T_CODE,code);
 	if (decoded_size < 0) {
  	    LoadError0(stp, "bad external term representation of compilation information");
  	}
-    CHKBLK(ERTS_ALC_T_CODE,code);
+	CHKBLK(ERTS_ALC_T_CODE,code);
 	code[MI_COMPILE_SIZE_ON_HEAP] = decoded_size;
     }
     CHKBLK(ERTS_ALC_T_CODE,code);
 
     /*
+     * Make sure that we have not overflowed the allocated code space.
+     */
+    ASSERT(str_table + strtab_size + attr_size + compile_size ==
+	   ((byte *) code) + size);
+
+    /*
      * Go through all i_new_bs_put_strings instructions, restore the pointer to
      * the instruction and convert string offsets to pointers (to the
      * FIRST character).