Merge branch 'lukas/erts/spawn_driver_relative_cd/ERL-175/OTP-13733' into maint

* lukas/erts/spawn_driver_relative_cd/ERL-175/OTP-13733:
  erts: Add port_SUITE:cd invalid dir testcase
  erts: Fix spawn driver with relative cd option
  erts: Fix HARD_DEBUG printouts in erl_child_setup
  erts: Improve error printouts in erl_child_setup

Conflicts:
	erts/emulator/test/port_SUITE.erl

1 files changed, 24 insertions, 18 deletions

diff --git a/erts/emulator/sys/unix/sys_drivers.c b/erts/emulator/sys/unix/sys_drivers.c
index 3d7be020e1..400f163652 100644
--- a/erts/emulator/sys/unix/sys_drivers.c
+++ b/erts/emulator/sys/unix/sys_drivers.c
@@ -554,7 +554,7 @@ static ErlDrvData spawn_start(ErlDrvPort port_num, char* name,
     ErtsSysDriverData *dd;
     char *cmd_line;
     char wd_buff[MAXPATHLEN+1];
-    char *wd;
+    char *wd, *cwd;
     int ifd[2], ofd[2], stderrfd;
 
     if (pipe(ifd) < 0) return ERL_DRV_ERROR_ERRNO;
@@ -631,24 +631,22 @@ static ErlDrvData spawn_start(ErlDrvPort port_num, char* name,
 	return ERL_DRV_ERROR_ERRNO;
     }
 
-    if (opts->wd == NULL) {
-        if ((wd = getcwd(wd_buff, MAXPATHLEN+1)) == NULL) {
-            /* on some OSs this call opens a fd in the
-               background which means that this can
-               return EMFILE */
-            int err = errno;
-            close_pipes(ifd, ofd);
-            erts_free(ERTS_ALC_T_TMP, (void *) cmd_line);
-            if (new_environ != environ)
-                erts_free(ERTS_ALC_T_ENVIRONMENT, (void *) new_environ);
-            erts_smp_rwmtx_runlock(&environ_rwmtx);
-            errno = err;
-            return ERL_DRV_ERROR_ERRNO;
-        }
-    } else {
-        wd = opts->wd;
+    if ((cwd = getcwd(wd_buff, MAXPATHLEN+1)) == NULL) {
+        /* on some OSs this call opens a fd in the
+           background which means that this can
+           return EMFILE */
+        int err = errno;
+        close_pipes(ifd, ofd);
+        erts_free(ERTS_ALC_T_TMP, (void *) cmd_line);
+        if (new_environ != environ)
+            erts_free(ERTS_ALC_T_ENVIRONMENT, (void *) new_environ);
+        erts_smp_rwmtx_runlock(&environ_rwmtx);
+        errno = err;
+        return ERL_DRV_ERROR_ERRNO;
     }
 
+    wd = opts->wd;
+
     {
         struct iovec *io_vector;
         int iov_len = 5;
@@ -660,6 +658,8 @@ static ErlDrvData spawn_start(ErlDrvPort port_num, char* name,
             | (opts->read_write & DO_READ ? FORKER_FLAG_DO_READ : 0)
             | (opts->read_write & DO_WRITE ? FORKER_FLAG_DO_WRITE : 0);
 
+        if (wd) iov_len++;
+
         /* count number of elements in environment */
         while(new_environ[env_len] != NULL)
             env_len++;
@@ -704,10 +704,16 @@ static ErlDrvData spawn_start(ErlDrvPort port_num, char* name,
         io_vector[i++].iov_len = len;
         buffsz += len;
 
-        io_vector[i].iov_base = wd;
+        io_vector[i].iov_base = cwd;
         io_vector[i].iov_len = strlen(io_vector[i].iov_base) + 1;
         buffsz += io_vector[i++].iov_len;
 
+        if (wd) {
+            io_vector[i].iov_base = wd;
+            io_vector[i].iov_len = strlen(io_vector[i].iov_base) + 1;
+            buffsz += io_vector[i++].iov_len;
+        }
+
         io_vector[i].iov_base = nullbuff;
         io_vector[i++].iov_len = 1;
         buffsz += io_vector[i-1].iov_len;