[esock|test] Made the first ttest case (ssf/csf/s) work for local (stream)

Add the first *working* ttest test case for Unix Domain (stream) socket:

    Server:       socket with active = false
    Client:       socket with active = false
    Message Size: small

OTP-15822

1 files changed, 71 insertions, 33 deletions

diff --git a/erts/emulator/test/socket_test_ttest_tcp_socket.erl b/erts/emulator/test/socket_test_ttest_tcp_socket.erl
index 6a54d70d58..8df1cdfad3 100644
--- a/erts/emulator/test/socket_test_ttest_tcp_socket.erl
+++ b/erts/emulator/test/socket_test_ttest_tcp_socket.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2018-2018. All Rights Reserved.
+%% Copyright Ericsson AB 2018-2019. All Rights Reserved.
 %% 
 %% Licensed under the Apache License, Version 2.0 (the "License");
 %% you may not use this file except in compliance with the License.
@@ -99,41 +99,60 @@ active(#{reader := Pid}, NewActive)
 
 close(#{sock := Sock, reader := Pid}) ->
     Pid ! {?MODULE, stop},
-    socket:close(Sock).
+    Unlink = case socket:sockname(Sock) of
+                 {ok, #{family := local, path := Path}} ->
+                     fun() -> os:cmd("unlink " ++ Path), ok end;
+                 _ ->
+                     fun() -> ok end
+             end,
+    Res = socket:close(Sock),
+    Unlink(),
+    Res.
 
 %% Create a socket and connect it to a peer
 connect(ServerPath) when is_list(ServerPath) ->
     Domain   = local,
+    LocalSA  = #{family => Domain,
+                 path   => mk_unique_path()},
     ServerSA = #{family => Domain, path => ServerPath},
     Opts     = #{domain => Domain,
                  proto  => default,
                  method => plain},
-    do_connect(ServerSA, Opts).
+    Cleanup = fun() -> os:cmd("unlink " ++ ServerPath), ok end,
+    do_connect(LocalSA, ServerSA, Cleanup, Opts).
 
 connect(Addr, Port) when is_tuple(Addr) andalso is_integer(Port) ->
     Domain   = inet,
+    LocalSA  = any,
     ServerSA = #{family => Domain,
                  addr   => Addr,
                  port   => Port},
     Opts     = #{domain => Domain,
                  proto  => tcp,
                  method => plain},
-    do_connect(ServerSA, Opts);
+    Cleanup  = fun() -> ok end,
+    do_connect(LocalSA, ServerSA, Cleanup, Opts);
 connect(ServerPath,
-        #{domain := local = Domain, proto := default} = Opts)
+        #{domain := local = Domain} = Opts)
   when is_list(ServerPath) ->
-    ServerSA = #{family => Domain, path => ServerPath},
-    do_connect(ServerSA, Opts).
+    LocalSA  = #{family => Domain,
+                 path   => mk_unique_path()},
+    ServerSA = #{family => Domain,
+                 path   => ServerPath},
+    Cleanup  = fun() -> os:cmd("unlink " ++ ServerPath), ok end,
+    do_connect(LocalSA, ServerSA, Cleanup, Opts#{proto => default}).
 
-connect(Addr, Port, #{domain := Domain, proto := tcp} = Opts) ->
+connect(Addr, Port, #{domain := Domain} = Opts) ->
+    LocalSA  = any,
     ServerSA = #{family => Domain,
                  addr   => Addr,
                  port   => Port},
-    do_connect(ServerSA, Opts).
+    Cleanup  = fun() -> ok end,
+    do_connect(LocalSA, ServerSA, Cleanup, Opts#{proto => tcp}).
 
-do_connect(ServerSA, #{domain := Domain,
-                       proto  := Proto, 
-                       method := Method} = Opts) ->
+do_connect(LocalSA, ServerSA, Cleanup, #{domain := Domain,
+                                         proto  := Proto, 
+                                         method := Method} = Opts) ->
     try
 	begin
 	    Sock =
@@ -143,12 +162,12 @@ do_connect(ServerSA, #{domain := Domain,
 		    {error, OReason} ->
 			throw({error, {open, OReason}})
 		end,
-            LocalSA = which_sa(Domain),
 	    case socket:bind(Sock, LocalSA) of
 		{ok, _} ->
 		    ok;
 		{error, BReason} ->
 		    (catch socket:close(Sock)),
+                    Cleanup(),
 		    throw({error, {bind, BReason}})
 	    end,
 	    case socket:connect(Sock, ServerSA) of
@@ -156,6 +175,7 @@ do_connect(ServerSA, #{domain := Domain,
 		    ok;
 		{error, CReason} ->
 		    (catch socket:close(Sock)),
+                    Cleanup(),
 		    throw({error, {connect, CReason}})
 	    end,
 	    Self   = self(),
@@ -168,12 +188,6 @@ do_connect(ServerSA, #{domain := Domain,
 	    ERROR
     end.
 
-which_sa(local = Domain) ->
-    #{family => Domain,
-      path   => mk_unique_path()};
-which_sa(_) ->
-    any.
-
 mk_unique_path() ->
     [NodeName | _] = string:tokens(atom_to_list(node()), [$@]),
     ?LIB:f("/tmp/esock_~s_~w", [NodeName, erlang:system_time(nanosecond)]).
@@ -200,37 +214,57 @@ controlling_process(#{sock := Sock, reader := Pid}, NewPid) ->
 
 %% Create a listen socket
 listen() ->
-    listen(0, #{method => plain}).
-
-listen(Port) ->
-    listen(Port, #{method => plain}).
-listen(Port, #{method := Method} = Opts)
-  when (is_integer(Port) andalso (Port >= 0)) andalso
-       ((Method =:= plain) orelse (Method =:= msg)) ->
+    listen(0).
+
+listen(Port) when is_integer(Port) ->
+    listen(Port, #{domain => inet, method => plain});
+listen(Path) when is_list(Path) ->
+    listen(Path, #{domain => local, method => plain}).
+
+listen(0, #{domain := local} = Opts) ->
+    listen(mk_unique_path(), Opts);
+listen(Path, #{domain := local = Domain} = Opts)
+  when is_list(Path) andalso (Path =/= []) ->
+    SA = #{family => Domain,
+           path   => Path},
+    Cleanup = fun() -> os:cmd("unlink " ++ Path), ok end,
+    do_listen(SA, Cleanup, Opts#{proto => default});
+listen(Port, #{domain := Domain} = Opts)
+  when is_integer(Port) andalso (Port >= 0) ->
+    %% Bind fills in the rest
+    SA = #{family => Domain,
+           port   => Port},
+    Cleanup = fun() -> ok end,
+    do_listen(SA, Cleanup, Opts#{proto => tcp}).
+
+do_listen(SA,
+          Cleanup,
+          #{domain := Domain, proto := Proto, method := Method} = Opts)
+  when (Method =:= plain) orelse (Method =:= msg) ->
     try
 	begin
-	    Sock = case socket:open(inet, stream, tcp) of
+	    Sock = case socket:open(Domain, stream, Proto) of
 		       {ok, S} ->
 			   S;
 		       {error, OReason} ->
 			   throw({error, {open, OReason}})
 		   end,
-	    SA = #{family => inet,
-		   port   => Port},
 	    case socket:bind(Sock, SA) of
 		{ok, _} ->
 		    ok;
 		{error, BReason} ->
 		    (catch socket:close(Sock)),
+                    Cleanup(),
 		    throw({error, {bind, BReason}})
 	    end,
 	    case socket:listen(Sock) of
 		ok ->
-                        ok;
-                    {error, LReason} ->
+                    ok;
+                {error, LReason} ->
 		    (catch socket:close(Sock)),
-                        throw({error, {listen, LReason}})
-                end,
+                    Cleanup(),
+                    throw({error, {listen, LReason}})
+            end,
 	    {ok, #{sock => Sock, opts => Opts}}
 	end
     catch
@@ -241,6 +275,8 @@ listen(Port, #{method := Method} = Opts)
 
 port(#{sock := Sock}) ->
     case socket:sockname(Sock) of
+	{ok, #{family := local, path := Path}} ->
+	    {ok, Path};
 	{ok, #{port := Port}} ->
 	    {ok, Port};
 	{error, _} = ERROR ->
@@ -250,6 +286,8 @@ port(#{sock := Sock}) ->
 
 peername(#{sock := Sock}) ->
     case socket:peername(Sock) of
+	{ok, #{family := local, path := Path}} ->
+	    {ok, Path};
 	{ok, #{addr := Addr, port := Port}} ->
 	    {ok, {Addr, Port}};
 	{error, _} = ERROR ->