Merge branch 'john/erts/nif-map-from-array/OTP-14954'

* john/erts/nif-map-from-array/OTP-14954:
  Add enif_make_map_from_arrays

2 files changed, 40 insertions, 13 deletions

diff --git a/erts/emulator/test/nif_SUITE.erl b/erts/emulator/test/nif_SUITE.erl
index b6e15ababb..a9eb4b2768 100644
--- a/erts/emulator/test/nif_SUITE.erl
+++ b/erts/emulator/test/nif_SUITE.erl
@@ -1170,6 +1170,12 @@ maps(Config) when is_list(Config) ->
     {1, M2} = make_map_remove_nif(M2, "key3"),
     {0, undefined} = make_map_remove_nif(self(), key),
 
+    M1 = maps_from_list_nif(maps:to_list(M1)),
+    M2 = maps_from_list_nif(maps:to_list(M2)),
+    M3 = maps_from_list_nif(maps:to_list(M3)),
+
+    has_duplicate_keys = maps_from_list_nif([{1,1},{1,1}]),
+
     verify_tmpmem(TmpMem),
     ok.
  
diff --git a/erts/emulator/test/nif_SUITE_data/nif_SUITE.c b/erts/emulator/test/nif_SUITE_data/nif_SUITE.c
index fa9ae1015c..e8d9302505 100644
--- a/erts/emulator/test/nif_SUITE_data/nif_SUITE.c
+++ b/erts/emulator/test/nif_SUITE_data/nif_SUITE.c
@@ -2140,24 +2140,45 @@ static ERL_NIF_TERM make_map_remove_nif(ErlNifEnv* env, int argc, const ERL_NIF_
 /* maps */
 static ERL_NIF_TERM maps_from_list_nif(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
 {
-    ERL_NIF_TERM cell = argv[0];
-    ERL_NIF_TERM map  = enif_make_new_map(env);
-    ERL_NIF_TERM tuple;
-    const ERL_NIF_TERM *pair;
-    int arity = -1;
+    ERL_NIF_TERM *keys, *values;
+    ERL_NIF_TERM result, cell;
+    unsigned count;
 
-    if (argc != 1 && !enif_is_list(env, cell)) return enif_make_badarg(env);
+    if (argc != 1 || !enif_get_list_length(env, argv[0], &count)) {
+        return enif_make_badarg(env);
+    }
 
-    /* assume sorted keys */
+    keys = enif_alloc(sizeof(ERL_NIF_TERM) * count * 2);
+    values = keys + count;
 
-    while (!enif_is_empty_list(env,cell)) {
-	if (!enif_get_list_cell(env, cell, &tuple, &cell)) return enif_make_badarg(env);
-	if (enif_get_tuple(env,tuple,&arity,&pair)) {
-	    enif_make_map_put(env, map, pair[0], pair[1], &map);
-	}
+    cell = argv[0];
+    count = 0;
+
+    while (!enif_is_empty_list(env, cell)) {
+        const ERL_NIF_TERM *pair;
+        ERL_NIF_TERM tuple;
+        int arity;
+
+        if (!enif_get_list_cell(env, cell, &tuple, &cell)
+            || !enif_get_tuple(env, tuple, &arity, &pair)
+            || arity != 2) {
+            enif_free(keys);
+            return enif_make_badarg(env);
+        }
+
+        keys[count] = pair[0];
+        values[count] = pair[1];
+
+        count++;
     }
 
-    return map;
+    if (!enif_make_map_from_arrays(env, keys, values, count, &result)) {
+        result = enif_make_atom(env, "has_duplicate_keys");
+    }
+
+    enif_free(keys);
+
+    return result;
 }
 
 static ERL_NIF_TERM sorted_list_from_maps_nif(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]) {