Merge branch 'nox/fix-clang-warnings' into maint

* nox/fix-clang-warnings:
  Silence warnings about socklen_t pointers sign in erl_memory
  Compile in_heapfrag() only in debug mode
  Silence two warnings about tests being always true
  Conditionally compile my_gethostbyname_r and my_gethostbyaddr_r
  Silence a mismatching type pointer warning in ei_resolve
  Silence warnings about different buffer types in erl_memory
  erts: Remove unused file winsock_func.h
  Silence warnings about unused return values in ic
  Silence a warning in erl_poll about an empty loop body
  Fix erts_check_off_heap2 assertion
  Properly mark erl_assert_error as non-returning
  Remove uninitialized use of new_crr in erl_alloc_util

OTP-11517

6 files changed, 25 insertions, 123 deletions

diff --git a/erts/emulator/beam/erl_alloc_util.c b/erts/emulator/beam/erl_alloc_util.c
index 3914537d0d..c6cea0185f 100644
--- a/erts/emulator/beam/erl_alloc_util.c
+++ b/erts/emulator/beam/erl_alloc_util.c
@@ -3570,7 +3570,6 @@ resize_carrier(Allctr_t *allctr, Block_t *old_blk, Uint umem_sz, UWord flags)
 	    /* Old carrier unchanged; restore... */
 	    STAT_SYS_ALLOC_SBC_ALLOC(allctr, old_crr_sz, old_blk_sz);
 	}
-	DEBUG_SAVE_ALIGNMENT(new_crr);
 	return new_blk;
     }
 #endif
diff --git a/erts/emulator/beam/erl_gc.c b/erts/emulator/beam/erl_gc.c
index 8ba94d89e9..e89725c190 100644
--- a/erts/emulator/beam/erl_gc.c
+++ b/erts/emulator/beam/erl_gc.c
@@ -2770,7 +2770,7 @@ erts_check_off_heap2(Process *p, Eterm *htop)
 	    refc = erts_refc_read(&u.ext->node->refc, 1);
 	    break;
 	default:
-	    ASSERT(!!"erts_check_off_heap2: Invalid thing_word");
+	    ASSERT(!"erts_check_off_heap2: Invalid thing_word");
 	}
 	ERTS_CHK_OFFHEAP_ASSERT(refc >= 1);
 #ifdef ERTS_OFFHEAP_DEBUG_CHK_CIRCULAR_LIST
diff --git a/erts/emulator/beam/erl_message.c b/erts/emulator/beam/erl_message.c
index 325d77e911..6a9030fd99 100644
--- a/erts/emulator/beam/erl_message.c
+++ b/erts/emulator/beam/erl_message.c
@@ -46,10 +46,12 @@ ERTS_SCHED_PREF_QUICK_ALLOC_IMPL(message,
 
 
 
+#ifdef DEBUG
 static ERTS_INLINE int in_heapfrag(const Eterm* ptr, const ErlHeapFragment *bp)
 {
     return ((unsigned)(ptr - bp->mem) < bp->used_size);
 }
+#endif
 
 
 void
diff --git a/erts/emulator/beam/sys.h b/erts/emulator/beam/sys.h
index d22f125945..31252ed78f 100644
--- a/erts/emulator/beam/sys.h
+++ b/erts/emulator/beam/sys.h
@@ -149,9 +149,28 @@ typedef ERTS_SYS_FD_TYPE ErtsSysFdType;
 #  define ERTS_EXIT_AFTER_DUMP exit
 #endif
 
+/* In VC++, noreturn is a declspec that has to be before the types,
+ * but in GNUC it is an att ribute to be placed between return type
+ * and function name, hence __decl_noreturn <types> __noreturn <function name>
+ */
+#if __GNUC__
+#  define __decl_noreturn
+#  define __noreturn __attribute__((noreturn))
+#else
+#  if defined(__WIN32__) && defined(_MSC_VER)
+#    define __noreturn
+#    define __decl_noreturn __declspec(noreturn)
+#  else
+#    define __noreturn
+#    define __decl_noreturn
+#  endif
+#endif
+
 #define ERTS_ASSERT(e) \
     ((void) ((e) ? 1 : (erl_assert_error(#e, __func__, __FILE__, __LINE__), 0)))
-void erl_assert_error(const char* expr, const char *func, const char* file, int line);
+
+__decl_noreturn void __noreturn erl_assert_error(const char* expr, const char *func,
+						 const char* file, int line);
 
 #ifdef DEBUG
 #  define ASSERT(e) ERTS_ASSERT(e)
@@ -192,23 +211,6 @@ void erl_assert_error(const char* expr, const char *func, const char* file, int
 #  define erts_align_attribute(SZ)
 #endif
 
-/* In VC++, noreturn is a declspec that has to be before the types,
- * but in GNUC it is an att ribute to be placed between return type 
- * and function name, hence __decl_noreturn <types> __noreturn <function name>
- */
-#if __GNUC__
-#  define __decl_noreturn 
-#  define __noreturn __attribute__((noreturn))
-#else
-#  if defined(__WIN32__) && defined(_MSC_VER)
-#    define __noreturn 
-#    define __decl_noreturn __declspec(noreturn)
-#  else
-#    define __noreturn
-#    define __decl_noreturn 
-#  endif
-#endif
-
 /*
 ** Data types:
 **
diff --git a/erts/emulator/drivers/win32/winsock_func.h b/erts/emulator/drivers/win32/winsock_func.h
deleted file mode 100644
index 9d2c099c4d..0000000000
--- a/erts/emulator/drivers/win32/winsock_func.h
+++ /dev/null
@@ -1,102 +0,0 @@
-/*
- * %CopyrightBegin%
- * 
- * Copyright Ericsson AB 1997-2009. All Rights Reserved.
- * 
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
- * 
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
- * 
- * %CopyrightEnd%
- */
-
-typedef struct _WinSockFuncs {
-  int (WSAAPI *WSAStartup)(WORD wVersionRequired, LPWSADATA lpWSAData);
-  int (WSAAPI *WSACleanup)(void);
-  int (WSAAPI *WSAGetLastError)(void);
-  DWORD (WSAAPI *WSAWaitForMultipleEvents) (DWORD cEvents,
-					    const WSAEVENT FAR * lphEvents,
-					    BOOL fWaitAll,
-					    DWORD dwTimeout,
-					    BOOL fAlertable);
-  WSAEVENT (WSAAPI *WSACreateEvent)(void);
-  BOOL (WSAAPI *WSACloseEvent)(WSAEVENT hEvent);
-
-  BOOL (WSAAPI *WSASetEvent)(WSAEVENT hEvent);
-  BOOL (WSAAPI *WSAResetEvent)(WSAEVENT hEvent);
-  int (WSAAPI *WSAEventSelect)(SOCKET s, WSAEVENT hEventObject,
-			       long lNetworkEvents);
-  int (WSAAPI *WSAEnumNetworkEvents)(SOCKET s,
-				     WSAEVENT hEventObject,
-				     LPWSANETWORKEVENTS lpNetworkEvents);
-  int (WSAAPI *WSAIoctl)(SOCKET s,
-			 DWORD dwIoControlCode,
-			 LPVOID lpvInBuffer,
-			 DWORD cbInBuffer,
-			 LPVOID lpvOUTBuffer,
-			 DWORD cbOUTBuffer,
-			 LPDWORD lpcbBytesReturned,
-			 LPWSAOVERLAPPED lpOverlapped,
-			 LPWSAOVERLAPPED_COMPLETION_ROUTINE lpCompletionROUTINE
-			 );
-   SOCKET (WSAAPI *accept)(SOCKET s, struct sockaddr FAR *addr,
-			  int FAR *addrlen);
-  int (WSAAPI *bind)(SOCKET s, const struct sockaddr FAR *addr,
-		     int namelen);
-  int (WSAAPI *closesocket)(SOCKET s);
-  int (WSAAPI *connect)(SOCKET s, const struct sockaddr FAR *name,
-			int namelen);
-  int (WSAAPI *ioctlsocket)(SOCKET s, long cmd, u_long FAR *argp);
-  int (WSAAPI *getsockopt)(SOCKET s, int level, int optname,
-				char FAR * optval, int FAR *optlen);
-  u_long (WSAAPI *htonl)(u_long hostlong);
-  u_short (WSAAPI *htons)(u_short hostshort);
-  unsigned long (WSAAPI *inet_addr)(const char FAR * cp);
-  char FAR * (WSAAPI *inet_ntoa)(struct in_addr in);
-  int (WSAAPI *listen)(SOCKET s, int backlog);
-  u_short (WSAAPI *ntohs)(u_short netshort);
-  int (WSAAPI *recv)(SOCKET s, char FAR * buf, int len, int flags);
-  int (WSAAPI *send)(SOCKET s, const char FAR * buf, int len, int flags);
-  int (WSAAPI *setsockopt)(SOCKET s, int level, int optname,
-			   const char FAR * optval, int optlen);
-  int (WSAAPI *shutdown)(SOCKET s, int how);
-  SOCKET (WSAAPI *socket)(int af, int type, int protocol);
-  struct hostent FAR * (WSAAPI *gethostbyname)(const char FAR * name);
-  struct hostent FAR * (WSAAPI *gethostbyaddr)(const char FAR *addr,
-					       int addrlen, int addrtype);
-  int (WSAAPI *gethostname)(char FAR * name, int namelen);
-  struct servent FAR * (WSAAPI *getservbyname)(const char FAR * name,
-					       const char FAR * proto);
-  struct servent FAR * (WSAAPI *getservbyport)(int port,
-					       const char FAR * proto);
-  int (WSAAPI *getsockname)(SOCKET sock, struct sockaddr FAR *name,
-			    int FAR *namelen);
-
-  /*
-   * New, added for inet_drv.
-   */
-
-  int (WSAAPI *getpeername)(SOCKET s, struct sockaddr FAR * name,
-			    int FAR * namelen);
-  u_long (WSAAPI *ntohl)(u_long netlong);
-  int (WSAAPI *WSASend)(SOCKET s, LPWSABUF lpBuffers, DWORD dwBufferCount,
-			LPDWORD lpNumberOfBytesSent, DWORD dwFlags,
-			LPWSAOVERLAPPED lpOverlapped,
-			LPWSAOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine);
-  int (WSAAPI *sendto)(SOCKET s, const char FAR * buf, int len,
-		       int flags, const struct sockaddr FAR * to, int tolen);
-  int (WSAAPI *recvfrom)(SOCKET s, char FAR * buf, int len, int flags,
-			 struct sockaddr FAR * from, int FAR * fromlen);
-} WinSockFuncs;
-
-
-extern WinSockFuncs winSock;
-
-extern int tcp_lookup_functions(void);
diff --git a/erts/emulator/sys/common/erl_poll.c b/erts/emulator/sys/common/erl_poll.c
index 7676d8872a..0a58a625b2 100644
--- a/erts/emulator/sys/common/erl_poll.c
+++ b/erts/emulator/sys/common/erl_poll.c
@@ -2510,7 +2510,8 @@ ERTS_POLL_EXPORT(erts_poll_destroy_pollset)(ErtsPollSet ps)
 	pollsets = pollsets->next;
     else {
 	ErtsPollSet prev_ps;
-	for (prev_ps = pollsets; ps != prev_ps->next; prev_ps = prev_ps->next);
+	for (prev_ps = pollsets; ps != prev_ps->next; prev_ps = prev_ps->next)
+            ;
 	ASSERT(ps == prev_ps->next);
 	prev_ps->next = ps->next;
     }