diff options
author | Magnus Ottenklinger <[email protected]> | 2015-10-02 11:29:05 +0200 |
---|---|---|
committer | Magnus Ottenklinger <[email protected]> | 2015-10-02 15:13:10 +0200 |
commit | 731890f3b4ac62eed1221aa7d9fd2bfa6bf51d8c (patch) | |
tree | 6517fcce3b266ea067645ac7a8e1b681b03ed7f0 /erts/etc/common/erlc.c | |
parent | 46178552c4622b29d5a70ca23d945e9036caa437 (diff) | |
download | otp-731890f3b4ac62eed1221aa7d9fd2bfa6bf51d8c.tar.gz otp-731890f3b4ac62eed1221aa7d9fd2bfa6bf51d8c.tar.bz2 otp-731890f3b4ac62eed1221aa7d9fd2bfa6bf51d8c.zip |
Fix erroneous splitting of emulator path
`ct_run.c`, `erlc.c`, `escript.c` and `typer.c` do not preserve space characters in the emulator
path. Thus, if a path containing space is passed via environment variables, such as
`ESCRIPT_EMULATOR`, or if `get_default_emulator(progname)` returns a path with space, the execution
of the programs fail. This patch fixes all occurrences found with `grep push_words -R $ERL_TOP`.
Diffstat (limited to 'erts/etc/common/erlc.c')
-rw-r--r-- | erts/etc/common/erlc.c | 22 |
1 files changed, 1 insertions, 21 deletions
diff --git a/erts/etc/common/erlc.c b/erts/etc/common/erlc.c index f9d909e01c..049afc526a 100644 --- a/erts/etc/common/erlc.c +++ b/erts/etc/common/erlc.c @@ -200,7 +200,7 @@ int main(int argc, char** argv) eargv_base = (char **) emalloc(eargv_size*sizeof(char*)); eargv = eargv_base; eargc = 0; - push_words(emulator); + PUSH(strsave(emulator)); eargc_base = eargc; eargv = eargv + eargv_size/2; eargc = 0; @@ -330,26 +330,6 @@ process_opt(int* pArgc, char*** pArgv, int offset) return argv[1]; } -static void -push_words(char* src) -{ - char sbuf[MAXPATHLEN]; - char* dst; - - dst = sbuf; - while ((*dst++ = *src++) != '\0') { - if (isspace((int)*src)) { - *dst = '\0'; - PUSH(strsave(sbuf)); - dst = sbuf; - do { - src++; - } while (isspace((int)*src)); - } - } - if (sbuf[0]) - PUSH(strsave(sbuf)); -} #ifdef __WIN32__ wchar_t *make_commandline(char **argv) { |