erts: Fix windows widestring args and paths in tools

Fix erlc, escript, dialyzer, typer, ct_run, heart
and epmd should all be using widestrings on windows

1 files changed, 174 insertions, 73 deletions

diff --git a/erts/etc/common/escript.c b/erts/etc/common/escript.c
index 118bc6ef90..c92fedee4b 100644
--- a/erts/etc/common/escript.c
+++ b/erts/etc/common/escript.c
@@ -45,7 +45,8 @@ static int eargc;		/* Number of arguments in eargv. */
 #  define QUOTE(s) possibly_quote(s)
 #  define IS_DIRSEP(c) ((c) == '/' || (c) == '\\')
 #  define DIRSEPSTR "\\"
-#  define PATHSEPSTR ";"
+#  define LDIRSEPSTR L"\\"
+#  define LPATHSEPSTR L";"
 #  define PMAX MAX_PATH
 #  define ERL_NAME "erl.exe"
 #else
@@ -112,20 +113,31 @@ get_env(char *key)
 {
 #ifdef __WIN32__
     DWORD size = 32;
-    char *value = NULL;
+    char  *value=NULL;
+    wchar_t *wcvalue = NULL;
+    wchar_t wckey[256];
+    int len; 
+
+    MultiByteToWideChar(CP_UTF8, 0, key, -1, wckey, 256);
+    
     while (1) {
 	DWORD nsz;
-	if (value)
-	    efree(value);
-	value = emalloc(size);
+	if (wcvalue)
+	    efree(wcvalue);
+	wcvalue = (wchar_t *) emalloc(size*sizeof(wchar_t));
 	SetLastError(0);
-	nsz = GetEnvironmentVariable((LPCTSTR) key, (LPTSTR) value, size);
+	nsz = GetEnvironmentVariableW(wckey, wcvalue, size);
 	if (nsz == 0 && GetLastError() == ERROR_ENVVAR_NOT_FOUND) {
-	    efree(value);
+	    efree(wcvalue);
 	    return NULL;
 	}
-	if (nsz <= size)
+	if (nsz <= size) {
+	    len = WideCharToMultiByte(CP_UTF8, 0, wcvalue, -1, NULL, 0, NULL, NULL);
+	    value = emalloc(len*sizeof(char));
+	    WideCharToMultiByte(CP_UTF8, 0, wcvalue, -1, value, len, NULL, NULL);
+	    efree(wcvalue);
 	    return value;
+	}
 	size = nsz;
     }
 #else
@@ -145,6 +157,88 @@ free_env_val(char *value)
  * Find absolute path to this program
  */
 
+#ifdef __WIN32__
+static char *
+find_prog(char *origpath)
+{
+    wchar_t relpath[PMAX];
+    wchar_t abspath[PMAX];
+
+    if (strlen(origpath) >= PMAX)
+        error("Path too long");
+
+    MultiByteToWideChar(CP_UTF8, 0, origpath, -1, relpath, PMAX);
+
+    if (wcsstr(relpath, LDIRSEPSTR) == NULL) {
+        /* Just a base name */
+	int sz;
+        wchar_t *envpath;
+	sz = GetEnvironmentVariableW(L"PATH", NULL, 0);
+        if (sz) {	    
+            /* Try to find the executable in the path */
+            wchar_t dir[PMAX];
+            wchar_t *beg;
+            wchar_t *end;
+
+	    HANDLE dir_handle;	        /* Handle to directory. */
+	    wchar_t wildcard[PMAX];	/* Wildcard to search for. */
+	    WIN32_FIND_DATAW find_data;	/* Data found by FindFirstFile() or FindNext(). */
+
+            BOOL look_for_sep = TRUE;
+
+	    envpath = (wchar_t *) emalloc(sz * sizeof(wchar_t*));
+	    GetEnvironmentVariableW(L"PATH", envpath, sz);
+	    beg = envpath;
+
+            while (look_for_sep) {
+                end = wcsstr(beg, LPATHSEPSTR);
+                if (end != NULL) {
+                    sz = end - beg;
+                } else {
+                    sz = wcslen(beg);
+                    look_for_sep = FALSE;
+                }
+                if (sz >= PMAX) {
+                    beg = end + 1;
+                    continue;
+                }
+                wcsncpy(dir, beg, sz);
+                dir[sz] = L'\0';
+                beg = end + 1;
+
+		swprintf(wildcard, PMAX, L"%s" LDIRSEPSTR L"%s",
+			      dir, relpath /* basename */);
+		dir_handle = FindFirstFileW(wildcard, &find_data);
+		if (dir_handle == INVALID_HANDLE_VALUE) {
+		    /* Try next directory in path */
+		    continue;
+		} else {
+		    /* Wow we found the executable. */
+		    wcscpy(relpath, wildcard);
+		    FindClose(dir_handle);
+		    look_for_sep = FALSE;
+		    break;
+		}
+            }
+	    efree(envpath);
+        }
+    }
+    
+    {
+	DWORD size;
+	wchar_t *absrest;
+	size = GetFullPathNameW(relpath, PMAX, abspath, &absrest);
+	if ((size == 0) || (size > PMAX)) {
+	    /* Cannot determine absolute path to escript. Try the origin.  */
+	    return strsave(origpath);
+	} else {
+	    char utf8abs[PMAX];
+	    WideCharToMultiByte(CP_UTF8, 0, abspath, -1, utf8abs, PMAX, NULL, NULL);
+	    return strsave(utf8abs);
+	}
+    }
+}
+#else
 static char *
 find_prog(char *origpath)
 {
@@ -168,14 +262,8 @@ find_prog(char *origpath)
             char *end;
             int sz;
 
-#ifdef __WIN32__
-	    HANDLE dir_handle;	        /* Handle to directory. */
-	    char wildcard[PMAX];	/* Wildcard to search for. */
-	    WIN32_FIND_DATA find_data;	/* Data found by FindFirstFile() or FindNext(). */
-#else
             DIR *dp;             /* Pointer to directory structure. */
             struct dirent* dirp; /* Pointer to directory entry.     */
-#endif /* __WIN32__ */
 
             BOOL look_for_sep = TRUE;
 
@@ -195,21 +283,6 @@ find_prog(char *origpath)
                 dir[sz] = '\0';
                 beg = end + 1;
 
-#ifdef __WIN32__
-		erts_snprintf(wildcard, sizeof(wildcard), "%s" DIRSEPSTR "%s",
-            dir, relpath /* basename */);
-		dir_handle = FindFirstFile(wildcard, &find_data);
-		if (dir_handle == INVALID_HANDLE_VALUE) {
-		    /* Try next directory in path */
-		    continue;
-		} else {
-		    /* Wow we found the executable. */
-		    strcpy(relpath, wildcard);
-		    FindClose(dir_handle);
-		    look_for_sep = FALSE;
-		    break;
-		}
-#else
                 dp = opendir(dir);
                 if (dp != NULL) {
                     while (TRUE) {
@@ -230,21 +303,12 @@ find_prog(char *origpath)
                         }
                     }
                 }
-#endif /* __WIN32__ */
             }
         }
     }
     
     {
-#ifdef __WIN32__
-	DWORD size;
-	char *absrest;
-	size = GetFullPathName(relpath, PMAX, abspath, &absrest);
-	if ((size == 0) || (size > PMAX)) {
-	
-#else
         if (!realpath(relpath, abspath)) {
-#endif /* __WIN32__ */
 	    /* Cannot determine absolute path to escript. Try the origin.  */
 	    return strsave(origpath);
 	} else {
@@ -252,12 +316,21 @@ find_prog(char *origpath)
 	}
     }
 }
+#endif
 
 static void
 append_shebang_args(char* scriptname)
 {
     /* Open script file */
-    FILE* fd = fopen (scriptname,"r");
+    FILE* fd; 
+#ifdef __WIN32__
+    wchar_t wcscriptname[PMAX];
+
+    MultiByteToWideChar(CP_UTF8, 0, scriptname, -1, wcscriptname, PMAX);
+    fd = _wfopen(wcscriptname, L"r");
+#else
+    fd = fopen (scriptname,"r");
+#endif
 
     if (fd != NULL)	{
 	/* Read first line in script file */
@@ -321,9 +394,15 @@ append_shebang_args(char* scriptname)
     }
 }
 
+#ifdef __WIN32__
+int wmain(int argc, wchar_t **wcargv)
+{
+    char** argv;
+#else
 int
 main(int argc, char** argv)
 {
+#endif
     int eargv_size;
     int eargc_base;		/* How many arguments in the base of eargv. */
     char* emulator;
@@ -333,6 +412,19 @@ main(int argc, char** argv)
     char scriptname[PMAX];
     char** last_opt;
     char** first_opt;
+    
+#ifdef __WIN32__
+    int i;
+    int len;
+    /* Convert argv to utf8 */
+    argv = malloc((argc+1) * sizeof(char*));
+    for (i=0; i<argc; i++) {
+	len = WideCharToMultiByte(CP_UTF8, 0, wcargv[i], -1, NULL, 0, NULL, NULL);
+	argv[i] = malloc(len*sizeof(char));
+	WideCharToMultiByte(CP_UTF8, 0, wcargv[i], -1, argv[i], len, NULL, NULL);
+    }
+    argv[argc] = NULL;
+#endif
 
     emulator = env = get_env("ESCRIPT_EMULATOR");
     if (emulator == NULL) {
@@ -412,9 +504,8 @@ main(int argc, char** argv)
 #endif
 
 	erts_snprintf(scriptname, sizeof(scriptname), "%s.escript",
-        absname);
+		      absname);
 	efree(absname);
-
     }
 
     /*
@@ -483,63 +574,65 @@ push_words(char* src)
 	PUSH(strsave(sbuf));
 }
 #ifdef __WIN32__
-char *make_commandline(char **argv)
+wchar_t *make_commandline(char **argv)
 {
-    static char *buff = NULL;
+    static wchar_t *buff = NULL;
     static int siz = 0;
-    int num = 0;
-    char **arg, *p;
+    int num = 0, len;
+    char **arg;
+    wchar_t *p;
 
     if (*argv == NULL) { 
-	return "";
+	return L"";
     }
     for (arg = argv; *arg != NULL; ++arg) {
 	num += strlen(*arg)+1;
     }
     if (!siz) {
 	siz = num;
-	buff = emalloc(siz*sizeof(char));
+	buff = (wchar_t *) emalloc(siz*sizeof(wchar_t));
     } else if (siz < num) {
 	siz = num;
-	buff = realloc(buff,siz*sizeof(char));
+	buff = (wchar_t *) realloc(buff,siz*sizeof(wchar_t));
     }
     p = buff;
+    num=0;
     for (arg = argv; *arg != NULL; ++arg) {
-	strcpy(p,*arg);
-	p+=strlen(*arg);
-	*p++=' ';
+	len = MultiByteToWideChar(CP_UTF8, 0, *arg, -1, p, siz);
+	p+=(len-1);
+	*p++=L' ';
     }
-    *(--p) = '\0';
+    *(--p) = L'\0';
 
     if (debug) {
-	printf("Processed command line:%s\n",buff);
+	printf("Processed command line:%S\n",buff);
     }
     return buff;
 }
 
 int my_spawnvp(char **argv)
 {
-    STARTUPINFO siStartInfo;
+    STARTUPINFOW siStartInfo;
     PROCESS_INFORMATION piProcInfo;
     DWORD ec;
 
-    memset(&siStartInfo,0,sizeof(STARTUPINFO));
-    siStartInfo.cb = sizeof(STARTUPINFO); 
+    memset(&siStartInfo,0,sizeof(STARTUPINFOW));
+    siStartInfo.cb = sizeof(STARTUPINFOW); 
     siStartInfo.dwFlags = STARTF_USESTDHANDLES;
     siStartInfo.hStdInput = GetStdHandle(STD_INPUT_HANDLE);
     siStartInfo.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE);
     siStartInfo.hStdError = GetStdHandle(STD_ERROR_HANDLE);
 
-    if (!CreateProcess(NULL, 
-		       make_commandline(argv),
-		       NULL, 
-		       NULL, 
-		       TRUE, 
-		       0,
-		       NULL, 
-		       NULL, 
-		       &siStartInfo, 
-		       &piProcInfo)) {
+    if (!CreateProcessW(NULL, 
+			make_commandline(argv),
+			NULL, 
+			NULL, 
+			TRUE, 
+			0,
+			NULL, 
+			NULL, 
+			&siStartInfo, 
+			&piProcInfo)) {
 	return -1;
     }
     CloseHandle(piProcInfo.hThread);
@@ -623,6 +716,18 @@ strsave(char* string)
     return p;
 }
 
+static int 
+file_exists(char *progname) 
+{
+#ifdef __WIN32__
+    wchar_t wcsbuf[MAXPATHLEN];
+    MultiByteToWideChar(CP_UTF8, 0, progname, -1, wcsbuf, MAXPATHLEN);
+    return (_waccess(wcsbuf, 0) != -1);
+#else
+    return (access(progname, 1) != -1);
+#endif
+}
+
 static char*
 get_default_emulator(char* progname)
 {
@@ -636,15 +741,11 @@ get_default_emulator(char* progname)
     for (s = sbuf+strlen(sbuf); s >= sbuf; s--) {
 	if (IS_DIRSEP(*s)) {
 	    strcpy(s+1, ERL_NAME);
-#ifdef __WIN32__
-	    if (_access(sbuf, 0) != -1) {
+	    if(file_exists(sbuf))
 		return strsave(sbuf);
-	    }
-#else
-	    if (access(sbuf, 1) != -1) {
+	    strcpy(s+1, "bin" DIRSEPSTR ERL_NAME);
+	    if(file_exists(sbuf))
 		return strsave(sbuf);
-	    }
-#endif
 	    break;
 	}
     }