Merge tag 'OTP-19.0' into sverker/19/binary_to_atom-utf8-crash/ERL-474/OTP-14590

1 files changed, 110 insertions, 81 deletions

diff --git a/erts/etc/common/heart.c b/erts/etc/common/heart.c
index 81d797dc7e..d67b997d6d 100644
--- a/erts/etc/common/heart.c
+++ b/erts/etc/common/heart.c
@@ -1,18 +1,19 @@
 /*
  * %CopyrightBegin%
  * 
- * Copyright Ericsson AB 1996-2012. All Rights Reserved.
+ * Copyright Ericsson AB 1996-2016. All Rights Reserved.
  * 
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
- * 
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  * 
  * %CopyrightEnd%
  */
@@ -109,7 +110,7 @@
 #  include <sys/time.h>
 #  include <unistd.h>
 #  include <signal.h>
-#  if defined(CORRECT_USING_TIMES)
+#  if defined(OS_MONOTONIC_TIME_USING_TIMES)
 #    include <sys/times.h>
 #    include <limits.h>
 #  endif
@@ -117,11 +118,14 @@
 
 #define HEART_COMMAND_ENV          "HEART_COMMAND"
 #define ERL_CRASH_DUMP_SECONDS_ENV "ERL_CRASH_DUMP_SECONDS"
+#define HEART_KILL_SIGNAL          "HEART_KILL_SIGNAL"
+#define HEART_NO_KILL              "HEART_NO_KILL"
+
 
-#define MSG_HDR_SIZE        2
-#define MSG_HDR_PLUS_OP_SIZE 3
-#define MSG_BODY_SIZE      2048
-#define MSG_TOTAL_SIZE     2050
+#define MSG_HDR_SIZE         (2)
+#define MSG_HDR_PLUS_OP_SIZE (3)
+#define MSG_BODY_SIZE        (2048)
+#define MSG_TOTAL_SIZE       (2050)
 
 unsigned char cmd[MSG_BODY_SIZE];
 
@@ -201,7 +205,6 @@ static BOOL do_shutdown(int);
 static void print_last_error(void);
 static HANDLE start_reader_thread(void);
 static DWORD WINAPI reader(LPVOID);
-static int test_win95(void);
 #define read _read
 #define write _write
 #endif
@@ -239,24 +242,39 @@ get_env(char *key)
 {
 #ifdef __WIN32__
     DWORD size = 32;
-    char *value = NULL;
+    char  *value=NULL;
+    wchar_t *wcvalue = NULL;
+    wchar_t wckey[256];
+    int len; 
+
+    MultiByteToWideChar(CP_UTF8, 0, key, -1, wckey, 256);
+    
     while (1) {
 	DWORD nsz;
-	if (value)
-	    free(value);
-	value = malloc(size);
-	if (!value) {
+	if (wcvalue)
+	    free(wcvalue);
+	wcvalue = malloc(size*sizeof(wchar_t));
+	if (!wcvalue) {
 	    print_error("Failed to allocate memory. Terminating...");
 	    exit(1);
 	}
 	SetLastError(0);
-	nsz = GetEnvironmentVariable((LPCTSTR) key, (LPTSTR) value, size);
+	nsz = GetEnvironmentVariableW(wckey, wcvalue, size);
 	if (nsz == 0 && GetLastError() == ERROR_ENVVAR_NOT_FOUND) {
-	    free(value);
+	    free(wcvalue);
 	    return NULL;
 	}
-	if (nsz <= size)
+	if (nsz <= size) {
+	    len = WideCharToMultiByte(CP_UTF8, 0, wcvalue, -1, NULL, 0, NULL, NULL);
+	    value = malloc(len*sizeof(char));
+	    if (!value) {
+		print_error("Failed to allocate memory. Terminating...");
+		exit(1);
+	    }
+	    WideCharToMultiByte(CP_UTF8, 0, wcvalue, -1, value, len, NULL, NULL);
+	    free(wcvalue);
 	    return value;
+	}
 	size = nsz;
     }
 #else
@@ -456,10 +474,6 @@ message_loop(erlin_fd, erlout_fd)
 			switch (mp->op) {
 			case HEART_BEAT:
 				timestamp(&last_received);
-#ifdef USE_WATCHDOG
-				/* reset the hardware watchdog timer */
-				wd_reset();
-#endif
 				break;
 			case SHUT_DOWN:
 				return R_SHUT_DOWN;
@@ -512,6 +526,12 @@ static void
 kill_old_erlang(void){
     HANDLE erlh;
     DWORD exit_code;
+    char* envvar = NULL;
+
+    envvar = get_env(HEART_NO_KILL);
+    if (envvar && strcmp(envvar, "TRUE") == 0)
+      return;
+
     if(heart_beat_kill_pid != 0){
 	if((erlh = OpenProcess(PROCESS_TERMINATE | 
 			       SYNCHRONIZE | 
@@ -541,14 +561,26 @@ kill_old_erlang(void){
 static void 
 kill_old_erlang(void){
     pid_t pid;
-    int i;
-    int res;
+    int i, res;
+    int sig = SIGKILL;
+    char *envvar = NULL;
+
+    envvar = get_env(HEART_NO_KILL);
+    if (envvar && strcmp(envvar, "TRUE") == 0)
+      return;
+
+    envvar = get_env(HEART_KILL_SIGNAL);
+    if (envvar && strcmp(envvar, "SIGABRT") == 0) {
+        print_error("kill signal SIGABRT requested");
+        sig = SIGABRT;
+    }
+
     if(heart_beat_kill_pid != 0){
 	pid = (pid_t) heart_beat_kill_pid;
-	res = kill(pid,SIGKILL);
+	res = kill(pid,sig);
 	for(i=0; i < 5 && res == 0; ++i){
 	    sleep(1);
-	    res = kill(pid,SIGKILL);
+	    res = kill(pid,sig);
 	}
 	if(errno != ESRCH){
 	    print_error("Unable to kill old process, "
@@ -564,13 +596,22 @@ void win_system(char *command)
     char *comspec;
     char * cmdbuff;
     char * extra = " /C ";
+    wchar_t *wccmdbuff;
     char *env;
-    STARTUPINFO start;
+    STARTUPINFOW start;
     SECURITY_ATTRIBUTES attr;
     PROCESS_INFORMATION info;
+    int len;
 
-    if (!debug_on || test_win95()) {
-	system(command);
+    if (!debug_on) {
+	len = MultiByteToWideChar(CP_UTF8, 0, command, -1, NULL, 0);
+	wccmdbuff = malloc(len*sizeof(wchar_t));
+	if (!wccmdbuff) {
+	    print_error("Failed to allocate memory. Terminating...");
+	    exit(1);
+	}
+	MultiByteToWideChar(CP_UTF8, 0, command, -1, wccmdbuff, len);
+	_wsystem(wccmdbuff);
 	return;
     }
     comspec = env = get_env("COMSPEC");
@@ -602,20 +643,29 @@ void win_system(char *command)
 
     fflush(stderr);
 
-    if (!CreateProcess(NULL,
-		       cmdbuff,
-		       &attr,
-		       NULL,
-		       TRUE,
-		       0,
-		       NULL,
-		       NULL,
-		       &start,
-		       &info)) {
+    len = MultiByteToWideChar(CP_UTF8, 0, cmdbuff, -1, NULL, 0);
+    wccmdbuff = malloc(len*sizeof(wchar_t));
+    if (!wccmdbuff) {
+	print_error("Failed to allocate memory. Terminating...");
+	exit(1);
+    }
+    MultiByteToWideChar(CP_UTF8, 0, cmdbuff, -1, wccmdbuff, len);
+
+    if (!CreateProcessW(NULL,
+			wccmdbuff,
+			&attr,
+			NULL,
+			TRUE,
+			0,
+			NULL,
+			NULL,
+			&start,
+			&info)) {
 	debugf("Could not create process for the command %s.\r\n", cmdbuff);
     }
     WaitForSingleObject(info.hProcess,INFINITE);
     free(cmdbuff);
+    free(wccmdbuff);
 }
 #endif /* defined(__WIN32__) */
 
@@ -676,14 +726,12 @@ do_terminate(int erlin_fd, int reason) {
 		print_error("Would reboot. Terminating.");
 	    else {
 		kill_old_erlang();
-		/* suppress gcc warning with 'if' */
 		ret = system(command);
 		print_error("Executed \"%s\" -> %d. Terminating.",command, ret);
 	    }
 	    free_env_val(command);
 	} else {
 	    kill_old_erlang();
-	    /* suppress gcc warning with 'if' */
 	    ret = system((char*)&cmd[0]);
 	    print_error("Executed \"%s\" -> %d. Terminating.",cmd, ret);
 	}
@@ -966,16 +1014,6 @@ void print_last_error() {
 	LocalFree( lpMsgBuf );
 }
 
-static int test_win95(void)
-{
-    OSVERSIONINFO osinfo;
-    osinfo.dwOSVersionInfoSize=sizeof(OSVERSIONINFO);
-    GetVersionEx(&osinfo);
-    if (osinfo.dwPlatformId == VER_PLATFORM_WIN32_WINDOWS) 
-	return 1;
-    else
-	return 0;
-}
 
 static BOOL enable_privilege() {
 	HANDLE ProcessHandle;
@@ -993,27 +1031,18 @@ static BOOL enable_privilege() {
 }
 
 static BOOL do_shutdown(int really_shutdown) {
-    if (test_win95()) {
-    	if (ExitWindowsEx(EWX_REBOOT,0)) {
-		return TRUE;
-	} else {
-		print_last_error();
-		return FALSE;
-	}
-    } else {
-	enable_privilege();
-	if (really_shutdown) {
-	    if (InitiateSystemShutdown(NULL,"shutdown by HEART",10,TRUE,TRUE))
-		return TRUE;
-	} else if (InitiateSystemShutdown(NULL,
-					  "shutdown by HEART\n"
-					  "will be interrupted",
-					  30,TRUE,TRUE)) {
-	    AbortSystemShutdown(NULL);
+    enable_privilege();
+    if (really_shutdown) {
+	if (InitiateSystemShutdown(NULL,"shutdown by HEART",10,TRUE,TRUE))
 	    return TRUE;
-	}
-	return FALSE;
+    } else if (InitiateSystemShutdown(NULL,
+				      "shutdown by HEART\n"
+				      "will be interrupted",
+				      30,TRUE,TRUE)) {
+	AbortSystemShutdown(NULL);
+	return TRUE;
     }
+    return FALSE;
 }
 
 DWORD WINAPI reader(LPVOID lpvParam) {
@@ -1071,9 +1100,9 @@ time_t timestamp(time_t *res)
     return r;
 }
 
-#elif defined(HAVE_GETHRTIME)  || defined(GETHRTIME_WITH_CLOCK_GETTIME)
+#elif defined(OS_MONOTONIC_TIME_USING_GETHRTIME) || defined(OS_MONOTONIC_TIME_USING_CLOCK_GETTIME)
 
-#if defined(GETHRTIME_WITH_CLOCK_GETTIME)
+#if defined(OS_MONOTONIC_TIME_USING_CLOCK_GETTIME)
 typedef long long SysHrTime;
 
 SysHrTime sys_gethrtime(void);
@@ -1082,7 +1111,7 @@ SysHrTime sys_gethrtime(void)
 {
     struct timespec ts;
     long long result;
-    if (clock_gettime(CLOCK_MONOTONIC,&ts) != 0) {
+    if (clock_gettime(MONOTONIC_CLOCK_ID,&ts) != 0) {
 	print_error("Fatal, could not get clock_monotonic value, terminating! "
 		    "errno = %d\n", errno);
 	exit(1);
@@ -1109,7 +1138,7 @@ time_t timestamp(time_t *res)
     return r;
 }
 
-#elif defined(CORRECT_USING_TIMES)
+#elif defined(OS_MONOTONIC_TIME_USING_TIMES)
 
 #  ifdef NO_SYSCONF
 #    include <sys/param.h>