Simplify get_flag() and get_flag_list()

The get_flag/3 function which returns a default value if the
flag doesn't exist, is implemented in terms of get_flag/2
which throws an exception if the flag doesn't exist.

get_flag/3 is frequently used for the flags that don't exist,
which means that means that an exception will be generated and
catched for no good reason.

Reimplement get_flag/3 so that it doesn't have to call get_flag/2
and catch an exception. Eliminate the get_flag/2 function by
writing a special purpose function for the only time it's used,
that is for retrieving the value for the -root flag. As a
side-effect, we will get a nicer error message if there is
something wrong with the -root flag.

Similarly, simplify get_flag_list/3 and remove get_flag_list/2.

We can also eliminate search/3 and use the lists:keyfind/3
BIF instead.

0 files changed, 0 insertions, 0 deletions