Replace autoimport_SUITE with bif_SUITE:auto_imports/1

erts/test/autoimport_SUITE tested that auto-import information in
erl_internal:bif/2 was consistent with the documentation. It did
it by scanning erlang.xml.

Since the documentation is now based on the specs in erlang.erl,
we should now test consistency of the specs and erl_internal:bif/2.

Since anyone that adds a new BIF runs the emulator test suite, it
makes sense to do this test in bif_SUITE in the emulator test suite.

4 files changed, 32 insertions, 226 deletions

diff --git a/erts/emulator/test/bif_SUITE.erl b/erts/emulator/test/bif_SUITE.erl
index eaececdafa..3172d75e10 100644
--- a/erts/emulator/test/bif_SUITE.erl
+++ b/erts/emulator/test/bif_SUITE.erl
@@ -25,7 +25,7 @@
 	 init_per_group/2,end_per_group/2,
 	 init_per_testcase/2,end_per_testcase/2,
 	 display/1, display_huge/0,
-	 erl_bif_types/1,specs/1,improper_bif_stubs/1,
+	 erl_bif_types/1,specs/1,improper_bif_stubs/1,auto_imports/1,
 	 t_list_to_existing_atom/1,os_env/1,otp_7526/1,
 	 binary_to_atom/1,binary_to_existing_atom/1,
 	 atom_to_binary/1,min_max/1]).
@@ -33,7 +33,7 @@
 suite() -> [{ct_hooks,[ts_install_cth]}].
 
 all() -> 
-    [erl_bif_types, specs, improper_bif_stubs,
+    [erl_bif_types, specs, improper_bif_stubs, auto_imports,
      t_list_to_existing_atom, os_env, otp_7526,
      display,
      atom_to_binary, binary_to_atom, binary_to_existing_atom,
@@ -213,6 +213,35 @@ improper_bif_stubs(_) ->
     [check_stub(MFA, Body) || {MFA,Body} <- sofs:to_external(FuncRel)],
     ok.
 
+auto_imports(_Config) ->
+    Path = get_code_path(),
+    {erlang,Abstr} = extract_abstract(erlang, Path),
+    SpecFuns = [Name || {attribute,_,spec,{Name,_}} <- Abstr],
+    auto_imports(SpecFuns, 0).
+
+auto_imports([{F,A}|T], Errors) ->
+    case erl_internal:bif(F, A) of
+	false ->
+	    io:format("~p/~p: not auto-imported, but spec claims it "
+		      "is auto-imported", [F,A]),
+	    auto_imports(T, Errors+1);
+	true ->
+	    auto_imports(T, Errors)
+    end;
+auto_imports([{erlang,F,A}|T], Errors) ->
+    case erl_internal:bif(F, A) of
+	false ->
+	    auto_imports(T, Errors);
+	true ->
+	    io:format("~p/~p: auto-imported, but "
+		      "spec claims it is *not* auto-imported", [F,A]),
+	    auto_imports(T, Errors+1)
+    end;
+auto_imports([], 0) ->
+    ok;
+auto_imports([], Errors) ->
+    ?t:fail({Errors,inconsistencies}).
+
 extract_functions(M, Abstr) ->
     [{{M,F,A},Body} || {function,_,F,A,Body} <- Abstr].
 
diff --git a/erts/test/Makefile b/erts/test/Makefile
index 68be3f2178..f79bb6e5f0 100644
--- a/erts/test/Makefile
+++ b/erts/test/Makefile
@@ -28,7 +28,6 @@ EBIN = .
 # ----------------------------------------------------
 
 MODULES= \
-	autoimport_SUITE \
 	erlc_SUITE \
 	install_SUITE \
 	nt_SUITE \
@@ -39,14 +38,11 @@ MODULES= \
 	erlexec_SUITE \
 	z_SUITE
 
-ERL_XML = $(ERL_TOP)/erts/doc/src/erlang.xml
-ERL_XML_TARGET = autoimport_SUITE_data/erlang.xml
-
 ERL_FILES= $(MODULES:%=%.erl)
 
 TARGET_FILES = $(MODULES:%=$(EBIN)/%.$(EMULATOR))
 
-EXTRA_FILES = install_SUITE_data/install_bin $(ERL_XML_TARGET)
+EXTRA_FILES = install_SUITE_data/install_bin
 
 # ----------------------------------------------------
 # Release directory specification
@@ -68,10 +64,6 @@ install_SUITE_data/install_bin: ../../make/install_bin
 	rm -f $@
 	cp -p $< $@
 
-$(ERL_XML_TARGET): $(ERL_XML)
-	rm -f $@
-	cp -p $< $@
-
 clean:
 	rm -f $(TARGET_FILES) $(EXTRA_FILES)
 	rm -f core *~
diff --git a/erts/test/autoimport_SUITE.erl b/erts/test/autoimport_SUITE.erl
deleted file mode 100644
index 71ed5204b1..0000000000
--- a/erts/test/autoimport_SUITE.erl
+++ /dev/null
@@ -1,196 +0,0 @@
-%%
-%% %CopyrightBegin%
-%%
-%% Copyright Ericsson AB 1998-2011. All Rights Reserved.
-%%
-%% The contents of this file are subject to the Erlang Public License,
-%% Version 1.1, (the "License"); you may not use this file except in
-%% compliance with the License. You should have received a copy of the
-%% Erlang Public License along with this software. If not, it can be
-%% retrieved online at http://www.erlang.org/.
-%%
-%% Software distributed under the License is distributed on an "AS IS"
-%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-%% the License for the specific language governing rights and limitations
-%% under the License.
-%%
-%% %CopyrightEnd%
-%%
-%%% Purpose: Test erlang.xml re autoimports
--module(autoimport_SUITE).
-
--include_lib("test_server/include/test_server.hrl").
--export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1, 
-	 init_per_group/2,end_per_group/2,
-	 init_per_testcase/2,end_per_testcase/2,
-	 autoimports/1]).
--define(TEST_TIMEOUT, ?t:seconds(180)).
-
-suite() -> [{ct_hooks,[ts_install_cth]}].
-
-all() -> 
-    [autoimports].
-
-groups() -> 
-    [].
-
-init_per_suite(Config) ->
-    Config.
-
-end_per_suite(_Config) ->
-    ok.
-
-init_per_group(_GroupName, Config) ->
-    Config.
-
-end_per_group(_GroupName, Config) ->
-    Config.
-
-
-init_per_testcase(_Func, Config) ->
-    Dog = test_server:timetrap(?TEST_TIMEOUT),
-    [{watchdog, Dog} | Config].
-
-end_per_testcase(_Func, Config) ->
-    Dog = ?config(watchdog, Config),
-    catch test_server:timetrap_cancel(Dog),
-    ok.
-
-
-autoimports(suite) ->
-    [];
-autoimports(doc) ->
-    ["Check that erlang.xml documents autoimports correctly"];
-autoimports(Config) when is_list(Config) ->
-    ?line XML = filename:join([?config(data_dir,Config),"erlang.xml"]),
-    ?line case xml(XML) of
-	      [] ->
-		  ok;
-	      List ->
-		  lists:foreach(fun({[],F,A}) ->
-					io:format("erlang:~s/~p is wrongly "
-						  "documented as ~s/~p~n",
-						  [F,A,F,A]);
-				   ({"erlang",F,A}) ->
-					io:format("~s/~p is wrongly "
-						  "documented as "
-						  "erlang:~s/~p~n",
-						  [F,A,F,A])
-				end,List),
-		  ?t:fail({wrong_autoimports,List})
-	  end.
-
-%%
-%% Ugly chunk of code to heuristically analyze the erlang.xml
-%% documentation file. Don't view this as an example...
-%%
-
-xml(XMLFile) ->
-    {ok,File} = file:open(XMLFile,[read]),
-    xskip_to_funcs(file:read_line(File),File),
-    DocData = xloop(file:read_line(File),File),
-    true = DocData =/= [],
-    file:close(File),
-    analyze(DocData).
-
-%% Skip lines up to and including the <funcs> tag.
-xskip_to_funcs({ok,Line},File) ->
-    case re:run(Line,"\\<funcs\\>",[{capture,none}]) of
-	nomatch ->
-	    xskip_to_funcs(file:read_line(File),File);
-	match ->
-	    ok
-    end.
-
-xloop({ok,Line},File) ->
-    case re:run(Line,"\\<name\\>",[{capture,none}]) of
-	nomatch ->
-	    xloop(file:read_line(File),File);
-	match ->
-	    X = re:replace(Line,"\\).*",")",[{return,list}]),
-	    Y = re:replace(X,".*\\>","",[{return,list}]),
-	    Mod = get_module(Y),
-	    Rest1 = fstrip(Mod++":",Y),
-	    Func = get_function(Rest1),
-	    Rest2 = fstrip(Func++"(", Rest1),
-	    Argc = count_args(Rest2,1,0,false),
-	    [{Mod,Func,Argc} |
-	     xloop(file:read_line(File),File)]
-    end;
-xloop(_,_) ->
-    [].
-
-analyze([{[],Func,Arity}|T]) ->
-    case erl_internal:bif(list_to_atom(Func),Arity) of
-	true ->
-	    analyze(T);
-	false ->
-	    [{[],Func,Arity} |
-	     analyze(T)]
-    end;
-analyze([{"erlang",Func,Arity}|T]) ->
-    case erl_internal:bif(list_to_atom(Func),Arity) of
-	true ->
-	    [{"erlang",Func,Arity}|analyze(T)];
-	false ->
-	    analyze(T)
-    end;
-analyze([_|T]) ->
-   analyze(T);
-analyze([]) ->
-   [].
-
-
-count_args([],_,N,false) ->
-    N;
-count_args([],_,N,true) ->
-    N+1;
-count_args(_,0,N,true) ->
-    N+1;
-count_args(_,0,N,false) ->
-    N;
-count_args([Par|T],Level,N,Got) when (Par =:= 40) or
-				 (Par =:= 123) or (Par =:= 91) ->
-    count_args(T,Level+1,N,(Level =:= 1) or Got);
-count_args([41|T],1,N,true) ->
-    count_args(T,0,N+1,false);
-count_args([Par|T],Level,N, Got) when (Par =:= 41) or
-				 (Par =:= 125) or (Par =:= 93) ->
-    count_args(T,Level-1,N,Got);
-count_args([$,|T],1,N,true) ->
-    count_args(T,1,N+1,false);
-count_args([$ |T],A,B,C) ->
-    count_args(T,A,B,C);
-count_args([_|T],1,N,_) ->
-    count_args(T,1,N,true);
-count_args([_|T],A,B,C) ->
-    count_args(T,A,B,C).
-
-fstrip([],X) ->
-    X;
-fstrip(_,[]) ->
-    [];
-fstrip([H|T1],[H|T2]) ->
-    fstrip(T1,T2);
-fstrip(_,L) ->
-    L.
-
-get_module(X) ->
-    get_module(X,[]).
-get_module([],_) ->
-    [];
-get_module([$:|_],Acc) ->
-    lists:reverse(Acc);
-get_module([40|_],_) -> %(
-    [];
-get_module([H|T],Acc) ->
-    get_module(T,[H|Acc]).
-
-get_function(X) ->
-    get_function(X,[]).
-get_function([],_) ->
-    [];
-get_function([40|_],Acc) -> %(
-    lists:reverse(Acc);
-get_function([H|T],Acc) ->
-    get_function(T,[H|Acc]).
diff --git a/erts/test/autoimport_SUITE_data/dummy.txt b/erts/test/autoimport_SUITE_data/dummy.txt
deleted file mode 100644
index 972643e527..0000000000
--- a/erts/test/autoimport_SUITE_data/dummy.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-%%
-%% %CopyrightBegin%
-%%
-%% Copyright Ericsson AB 1998-2010. All Rights Reserved.
-%%
-%% The contents of this file are subject to the Erlang Public License,
-%% Version 1.1, (the "License"); you may not use this file except in
-%% compliance with the License. You should have received a copy of the
-%% Erlang Public License along with this software. If not, it can be
-%% retrieved online at http://www.erlang.org/.
-%%
-%% Software distributed under the License is distributed on an "AS IS"
-%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-%% the License for the specific language governing rights and limitations
-%% under the License.
-%%
-%% %CopyrightEnd%
-%%
-%% Purpouse: Dummy