Add run-time library templates and use them

The template modules (asn1rtt_*.erl) are based on the existing
run-time modules, but with some simplifications and improvements,
for example:

The run-time functions for BER encoding took a Constraint argument which
was not used. It has been eliminated, along with the unused StringType
argument for the encode_restricted_string function.

The Range argument for decode_enumerated() has been dropped since it
was not used.

1 files changed, 39 insertions, 46 deletions

diff --git a/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl b/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl
index 78cb9297d8..021002c3b3 100644
--- a/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl
+++ b/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl
@@ -162,7 +162,8 @@ gen_encode_sequence(Erules,Typename,D) when is_record(D,type) ->
     emit([nl,"   BytesSoFar = "]),
     case SeqOrSet of
 	'SET' when (D#type.def)#'SET'.sorted == dynamic ->
-	    emit("asn1rt_check:dynamicsort_SET_components(["),
+	    asn1ct_func:need({ber,dynamicsort_SET_components,1}),
+	    emit("dynamicsort_SET_components(["),
 	    mkvlist(asn1ct_name:all(encBytes)),
 	    emit(["]),",nl]);
 	_ ->
@@ -177,8 +178,8 @@ gen_encode_sequence(Erules,Typename,D) when is_record(D,type) ->
 	    mkvplus(AllLengths)
     end,
     emit([",",nl]),
-    emit(["?RT_BER:encode_tags(TagIn, BytesSoFar, LenSoFar)."
-	  ,nl]).
+    call(encode_tags, ["TagIn","BytesSoFar","LenSoFar"]),
+    emit([".",nl]).
 
 gen_decode_sequence(Erules,Typename,D) when is_record(D,type) ->
     asn1ct_name:start(),
@@ -207,7 +208,8 @@ gen_decode_sequence(Erules,Typename,D) when is_record(D,type) ->
 	_ ->
 	    emit([{curr,tlv}," = "])
     end,
-    emit(["?RT_BER:match_tags(",{prev,tlv},",TagIn), ",nl]),
+    call(match_tags, [{prev,tlv},"TagIn"]),
+    emit([com,nl]),
     asn1ct_name:new(tlv),
     asn1ct_name:new(v),
 
@@ -371,7 +373,8 @@ gen_decode_set(Erules,Typename,D) when is_record(D,type) ->
 	_ ->
 	    emit([{curr,tlv}," = "])
     end,
-    emit(["?RT_BER:match_tags(",{prev,tlv},",TagIn), ",nl]),
+    call(match_tags, [{prev,tlv},"TagIn"]),
+    emit([com,nl]),
     asn1ct_name:new(v),
 
 
@@ -492,7 +495,8 @@ gen_encode_sof(Erules,Typename,_InnerTypename,D) when is_record(D,type) ->
     emit(["   {EncBytes,EncLen} = 'enc_",asn1ct_gen:list2name(Typename),
 	  "_components'(Val",Objfun,",[],0),",nl]),
 
-    emit(["   ?RT_BER:encode_tags(TagIn, EncBytes, EncLen).",nl,nl]),
+    emit(["   ",{call,ber,encode_tags,["TagIn","EncBytes","EncLen"]},
+	  ".",nl,nl]),
 
     gen_encode_sof_components(Erules,Typename,SeqOrSetOf,Cont).
     
@@ -512,8 +516,8 @@ gen_decode_sof(Erules,TypeName,_InnerTypeName,D) when is_record(D,type) ->
     emit(["   %%-------------------------------------------------",nl]),
     
     asn1ct_name:new(tlv),
-    emit([{curr,tlv},
-	  " = ?RT_BER:match_tags(",{prev,tlv},",TagIn), ",nl]),
+    emit([{curr,tlv}," = ",
+	  {call,ber,match_tags,[{prev,tlv},"TagIn"]},com,nl]),
     asn1ct_name:new(v),
 
     emit(["["]),
@@ -551,8 +555,9 @@ gen_encode_sof_components(Erules,Typename,SeqOrSetOf,Cont)
 
     case catch lists:member(der,get(encoding_options)) of
 	true when SeqOrSetOf=='SET OF'->
+	    asn1ct_func:need({ber,dynamicsort_SETOF,1}),
 	    emit([indent(3),
-		  "{asn1rt_check:dynamicsort_SETOF(AccBytes),AccLen};",nl,nl]);
+		  "{dynamicsort_SETOF(AccBytes),AccLen};",nl,nl]);
 	_ ->
 	    emit([indent(3),"{lists:reverse(AccBytes),AccLen};",nl,nl])
     end,
@@ -672,8 +677,9 @@ gen_dec_sequence_call2(Erules,TopType,{Root1,EList,Root2},_Ext,DecObjInf) ->
     %% including the first mandatory element.
     TagList = get_root2_taglist(Root2,[]),
     emit({com,nl}),
-    emit([{curr,tlv}," = ?RT_BER:skip_ExtensionAdditions(",
-	  {prev,tlv},", ",{asis,TagList},"),",nl]),
+    emit([{curr,tlv}," = ",
+	  {call,ber,skip_ExtensionAdditions,
+	   [{prev,tlv},{asis,TagList}]},com,nl]),
     asn1ct_name:new(tlv),
     gen_dec_sequence_call1(Erules,TopType,Root2,
 			   length(Root1)+length(EList),noext,
@@ -805,8 +811,8 @@ gen_enc_choice1(Erules,TopType,_Tag,CompList,_Ext) ->
     emit(["   {EncBytes,EncLen} = case element(1,Val) of",nl]),
     gen_enc_choice2(Erules,TopType,CompList),
     emit([nl,"   end,",nl,nl]),
-    
-    emit(["?RT_BER:encode_tags(TagIn, EncBytes, EncLen).",nl]).
+    call(encode_tags, ["TagIn","EncBytes","EncLen"]),
+    emit([".",nl]).
 
 
 gen_enc_choice2(Erules,TopType,[H1|T]) when is_record(H1,'ComponentType') ->
@@ -859,8 +865,8 @@ gen_enc_choice2(_Erules,_TopType,[])  ->
 gen_dec_choice(Erules,TopType, _ChTag, CompList, Ext) ->
     asn1ct_name:clear(),
     asn1ct_name:new(tlv),
-    emit([{curr,tlv},
-	  " = ?RT_BER:match_tags(",{prev,tlv},",TagIn), ",nl]),
+    emit([{curr,tlv}," = ",
+	  {call,ber,match_tags,[{prev,tlv},"TagIn"]},com,nl]),
     asn1ct_name:new(tlv),
     asn1ct_name:new(v),
     emit(["case (case ",{prev,tlv},
@@ -876,8 +882,8 @@ gen_dec_choice(Erules,TopType, _ChTag, CompList, Ext) ->
 	    emit([indent(9),"exit({error,{asn1,{invalid_choice_tag,",
 		  {curr,else},"}}})",nl]);
 	_ ->
-	    emit([indent(9),"{asn1_ExtAlt, ?RT_BER:encode(",{curr,else},
-		  asn1ct_gen:nif_parameter(),")}",nl])
+	    emit([indent(9),"{asn1_ExtAlt,",
+		  {call,ber,ber_encode,[{curr,else}]},"}",nl])
     end,
     emit([indent(3),"end",nl]),
     asn1ct_name:new(tag),
@@ -1018,29 +1024,20 @@ gen_enc_line(Erules,TopType,Cname,Type,Element,Indent,OptOrMand,Assign,EncObj)
 		    case OptOrMand of
 			mandatory ->
 			    emit(["{",{curr,encBytes},",",{curr,encLen},
-				  "} = "]),
-			    emit(["?RT_BER:encode_open_type(",{curr,tmpBytes},
-				  ",",{asis,Tag},")"]);
+				  "} = ",
+				  {call,ber,encode_open_type,
+				   [{curr,tmpBytes},{asis,Tag}]},nl]);
 			_ ->
-%			    emit(["{",{next,tmpBytes},", _} = "]),
 			    emit(["{",{next,tmpBytes},",",{curr,tmpLen},
-				  "} = "]),
-			    emit(["?RT_BER:encode_open_type(",{curr,tmpBytes},
-				  ",",{asis,Tag},"),",nl]),
+				  "} = ",
+				  {call,ber,encode_open_type,
+				   [{curr,tmpBytes},{asis,Tag}]},com,nl]),
 			    emit(IndDeep),
 			    emit(["{",{next,tmpBytes},", ",{curr,tmpLen},"}"])
 		    end;
 		Err ->
 		    throw({asn1,{'internal error',Err}})
 	    end;
-%% 	{{#'ObjectClassFieldType'{type={objectfield,PrimFieldName1,
-%% 					PFNList}},_},
-%% 	 {componentrelation,_,_}} ->
-%% 	    %% this is when the dotted list in the FieldName has more
-%% 	    %% than one element
-%% 	    {_LeadingAttrName,Fun} = EncObj,
-%% 	    emit(["?RT_BER:encode_open_type(",Fun,"(",{asis,PrimFieldName1},
-%% 		  ", ",Element,", ",{asis,PFNList},"))"]);
 	_ ->
 	    case WhatKind of
 		{primitive,bif} ->
@@ -1238,15 +1235,11 @@ gen_dec_call({typefield,_},_,_,_Cname,Type,BytesVar,Tag,_,_,false,_) ->
     asn1ct_name:new(tmptlv),
 
     {FirstPFName,RestPFName} = 
-% 	asn1ct_gen:get_constraint(Type#type.constraint,
-% 				  tableconstraint_info),
 	(Type#type.def)#'ObjectClassFieldType'.fieldname,
     emit([nl,indent(6),"begin",nl]),
-%    emit([indent(9),{curr,opendec}," = ?RT_BER:decode_open_type(",
-    emit([indent(9),{curr,tmptlv}," = ?RT_BER:decode_open_type(",
-	  BytesVar,",",{asis,Tag},asn1ct_gen:nif_parameter(),"),",nl]),
-%     emit([indent(9),"{",{curr,tmptlv},",_} = ?RT_BER:decode(",
-% 	  {curr,opendec},"),",nl]),
+    emit([indent(9),{curr,tmptlv}," = ",
+	  {call,ber,decode_open_type,
+	   [BytesVar,{asis,Tag}]},com,nl]),
 
     emit([indent(9),"case (catch ObjFun(",{asis,FirstPFName},
 	  ", ",{curr,tmptlv},", ",{asis,RestPFName},
@@ -1259,8 +1252,7 @@ gen_dec_call({typefield,_},_,_,_Cname,Type,BytesVar,Tag,_,_,false,_) ->
     emit([indent(9),"end",nl,indent(6),"end",nl]),
     [];
 gen_dec_call({typefield,_},_,_,Cname,Type,BytesVar,Tag,_,_,_DecObjInf,OptOrMandComp) ->
-    emit(["?RT_BER:decode_open_type(",BytesVar,",",{asis,Tag},
-	  asn1ct_gen:nif_parameter(),")"]),
+    call(decode_open_type, [BytesVar,{asis,Tag}]),
     RefedFieldName = 
 % 	asn1ct_gen:get_constraint(Type#type.constraint,
 % 				  tableconstraint_info),
@@ -1268,8 +1260,7 @@ gen_dec_call({typefield,_},_,_,Cname,Type,BytesVar,Tag,_,_,_DecObjInf,OptOrMandC
     [{Cname,RefedFieldName,asn1ct_gen:mk_var(asn1ct_name:curr(term)),
       asn1ct_gen:mk_var(asn1ct_name:curr(tmpterm)),Tag,OptOrMandComp}];
 gen_dec_call({objectfield,PrimFieldName,PFNList},_,_,Cname,_,BytesVar,Tag,_,_,_,OptOrMandComp) ->
-    emit(["?RT_BER:decode_open_type(",BytesVar,",",{asis,Tag},
-	  asn1ct_gen:nif_parameter(),")"]),
+    call(decode_open_type, [BytesVar,{asis,Tag}]),
     [{Cname,{PrimFieldName,PFNList},asn1ct_gen:mk_var(asn1ct_name:curr(term)),
       asn1ct_gen:mk_var(asn1ct_name:curr(tmpterm)),Tag,OptOrMandComp}];
 gen_dec_call(InnerType,Erules,TopType,Cname,Type,BytesVar,Tag,PrimOptOrMand,
@@ -1301,7 +1292,6 @@ gen_dec_call1({primitive,bif},InnerType,Erules,TopType,Cname,Type,BytesVar,
 	    asn1ct:add_generated_refed_func({[Cname|TopType],undecoded,
 					     Tag,Type}),
 	    asn1ct:update_gen_state(namelist,Rest),
-%	    emit(["?RT_BER:match_tags(",BytesVar,",",{asis,Tag},")"]);
 	    emit(["{'",asn1ct_gen:list2name([Cname|TopType]),"',",
 		  BytesVar,"}"]);
 	{_,{fixedtypevaluefield,_,Btype}} ->
@@ -1320,7 +1310,6 @@ gen_dec_call1('ASN1_OPEN_TYPE',_InnerType,Erules,TopType,Cname,Type,BytesVar,
 	    asn1ct:update_gen_state(namelist,Rest),
 	    emit(["{'",asn1ct_gen:list2name([Cname|TopType]),"',",
 		  BytesVar,"}"]);
-%	    emit(["?RT_BER:match_tags(",BytesVar,",",{asis,Tag},")"]);
 	{_,#'ObjectClassFieldType'{type=OpenType}} ->
 	    ?ASN1CT_GEN_BER:gen_dec_prim(Erules,#type{def=OpenType},
 					 BytesVar,Tag,[],
@@ -1393,7 +1382,8 @@ gen_dec_call1(WhatKind,_,_Erules,TopType,Cname,Type,BytesVar,
 						     parts,
 						     [],Type}),
 		    emit(["{'",asn1ct_gen:list2name([Cname|TopType]),"',"]),
-		    EmitDecFunCall("?RT_BER:match_tags"),
+		    asn1ct_func:need({ber,match_tags,2}),
+		    EmitDecFunCall("match_tags"),
 		    emit("}");
 		_ ->
 		    {DecFunName,_,_}=
@@ -1522,3 +1512,6 @@ value_match1(Value,[],Acc,Depth) ->
     Acc ++ Value ++ lists:concat(lists:duplicate(Depth,")"));
 value_match1(Value,[{VI,_}|VIs],Acc,Depth) ->
     value_match1(Value,VIs,Acc++lists:concat(["element(",VI,","]),Depth+1).
+
+call(F, Args) ->
+    asn1ct_func:call(ber, F, Args).