diff options
| author | Björn Gustavsson <[email protected]> | 2013-02-04 12:10:50 +0100 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2013-02-04 16:25:42 +0100 |
| commit | 10c73156d654bc1ada7afbc3cd7f81b2091057f0 (patch) | |
| tree | d03c8216c83a08491c9dbf3f540566a73549efcb /lib/asn1/test/asn1_SUITE.erl | |
| parent | e7cc9b2e81128632d3cd0a1d357527b7f5faa5f8 (diff) | |
| download | otp-10c73156d654bc1ada7afbc3cd7f81b2091057f0.tar.gz otp-10c73156d654bc1ada7afbc3cd7f81b2091057f0.tar.bz2 otp-10c73156d654bc1ada7afbc3cd7f81b2091057f0.zip | |
asn1_SUITE: Mend broken test_modified_x420/1
The test_modified_x420/1 test case had several problems that
prevented it to detect the bugs it was supposed to find:
1) There was a 'catch' at the top-level so that it could never fail.
2) There was a call to the now non-existing ssl_base64 module.
3) It did not test all options for the BER backend.
While at it, also clean way the remaining ?line macros and some
out-commented code.
Diffstat (limited to 'lib/asn1/test/asn1_SUITE.erl')
| -rw-r--r-- | lib/asn1/test/asn1_SUITE.erl | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/lib/asn1/test/asn1_SUITE.erl b/lib/asn1/test/asn1_SUITE.erl index 9a6201455d..0654d1c918 100644 --- a/lib/asn1/test/asn1_SUITE.erl +++ b/lib/asn1/test/asn1_SUITE.erl @@ -1054,11 +1054,14 @@ testDoubleEllipses(Config, Rule, Opts) -> testDoubleEllipses:main(Rule). test_modified_x420(Config) -> + test(Config, fun test_modified_x420/3, + [ber,ber_bin,ber_bin_v2,{ber_bin_v2,[nif]}]). +test_modified_x420(Config, Rule, Opts) -> Files = [filename:join(modified_x420, F) || F <- ["PKCS7", "InformationFramework", "AuthenticationFramework"]], - asn1_test_lib:compile_all(Files, Config, [der]), - test_modified_x420:test_io(Config). + asn1_test_lib:compile_all(Files, Config, [Rule,der|Opts]), + test_modified_x420:test(Config). testX420() -> |