Eliminate the use of asn1_wrapper

The asn1_wrapper made some sense when encode functions
could either produce a list or a binary, depending on the
backend. Now encode functions always produce a binary.

To improve readbility of the test suites, eliminate the asn1_wrapper
functions by replacing them with calls to one of the roundtrip
functions in asn1_test_lib. When it is not possible to use
the roundtrip functions, call the module in question directly.

While at it, also remove ?line macros that are near to the
touched code and use asn1_test_lib:hex_to_bin/1 instead of
home-brewn hex conversion routines.

1 files changed, 57 insertions, 141 deletions

diff --git a/lib/asn1/test/testSeqDefault.erl b/lib/asn1/test/testSeqDefault.erl
index a772b749bd..22c1b7ee3a 100644
--- a/lib/asn1/test/testSeqDefault.erl
+++ b/lib/asn1/test/testSeqDefault.erl
@@ -33,148 +33,64 @@
 -record('SeqDef3',{bool3 = asn1_DEFAULT, seq3 = asn1_DEFAULT, int3 = asn1_DEFAULT}).
 -record('SeqDef3Imp',{bool3 = asn1_DEFAULT, seq3 = asn1_DEFAULT, int3 = asn1_DEFAULT}).
 -record('SeqDef3Exp',{bool3 = asn1_DEFAULT, seq3 = asn1_DEFAULT, int3 = asn1_DEFAULT}).
--record('SeqIn',{boolIn, intIn}).
+-record('SeqIn',{boolIn = asn1_NOVALUE, intIn = 12}).
 
 
 main(_Rules) ->
-    
-    ?line {ok,Bytes11} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef1',#'SeqDef1'{bool1 = true,
-							int1 = 15,
-							seq1 = #'SeqIn'{boolIn = true,
-									intIn = 66}}), 
-    ?line {ok,{'SeqDef1',true,15,{'SeqIn',true,66}}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef1',lists:flatten(Bytes11)),
-    
-    
-    ?line {ok,Bytes12} = asn1_wrapper:encode('SeqDefault','SeqDef1',#'SeqDef1'{int1 = 15}), 
-    ?line {ok,{'SeqDef1',true,15,{'SeqIn',asn1_NOVALUE,12}}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef1',lists:flatten(Bytes12)),
-    
-    
-    ?line {ok,Bytes21} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef2',#'SeqDef2'{bool2 = true,
-							int2 = 15,
-							seq2 = #'SeqIn'{boolIn = true,
-									intIn = 66}}), 
-    ?line {ok,{'SeqDef2',{'SeqIn',true,66},true,15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef2',lists:flatten(Bytes21)),
-    
-    
-    ?line {ok,Bytes22} = asn1_wrapper:encode('SeqDefault','SeqDef2',#'SeqDef2'{int2 = 15}), 
-    ?line {ok,{'SeqDef2',{'SeqIn',asn1_NOVALUE,12},true,15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef2',lists:flatten(Bytes22)),
-    
-    
-    
-    ?line {ok,Bytes31} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef3',#'SeqDef3'{bool3 = true,
-							int3 = 15,
-							seq3 = #'SeqIn'{boolIn = true,
-									intIn = 66}}), 
-    ?line {ok,{'SeqDef3',true,{'SeqIn',true,66},15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef3',lists:flatten(Bytes31)),
-    
-    
-    ?line {ok,Bytes32} = asn1_wrapper:encode('SeqDefault','SeqDef3',#'SeqDef3'{int3 = 15}), 
-    ?line {ok,{'SeqDef3',true,{'SeqIn',asn1_NOVALUE,12},15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef3',lists:flatten(Bytes32)),
-    
-    
-    
-    
-    
-    ?line {ok,Bytes41} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef1Imp',#'SeqDef1Imp'{bool1 = true,
-							      int1 = 15,
-							      seq1 = #'SeqIn'{boolIn = true,
-									      intIn = 66}}), 
-    ?line {ok,{'SeqDef1Imp',true,15,{'SeqIn',true,66}}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef1Imp',lists:flatten(Bytes41)),
-    
-    
-    ?line {ok,Bytes42} = asn1_wrapper:encode('SeqDefault','SeqDef1Imp',#'SeqDef1Imp'{int1 = 15}), 
-    ?line {ok,{'SeqDef1Imp',true,15,{'SeqIn',asn1_NOVALUE,12}}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef1Imp',lists:flatten(Bytes42)),
-    
-    
-    ?line {ok,Bytes51} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef2Imp',#'SeqDef2Imp'{bool2 = true,
-							      int2 = 15,
-							      seq2 = #'SeqIn'{boolIn = true,
-									      intIn = 66}}), 
-    ?line {ok,{'SeqDef2Imp',{'SeqIn',true,66},true,15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef2Imp',lists:flatten(Bytes51)),
-    
-    
-    ?line {ok,Bytes52} = asn1_wrapper:encode('SeqDefault','SeqDef2Imp',#'SeqDef2Imp'{int2 = 15}), 
-    ?line {ok,{'SeqDef2Imp',{'SeqIn',asn1_NOVALUE,12},true,15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef2Imp',lists:flatten(Bytes52)),
-    
-    
-    
-    ?line {ok,Bytes61} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef3Imp',#'SeqDef3Imp'{bool3 = true,
-							      int3 = 15,
-							      seq3 = #'SeqIn'{boolIn = true,
-									      intIn = 66}}), 
-    ?line {ok,{'SeqDef3Imp',true,{'SeqIn',true,66},15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef3Imp',lists:flatten(Bytes61)),
-    
-    
-    ?line {ok,Bytes62} = asn1_wrapper:encode('SeqDefault','SeqDef3Imp',#'SeqDef3Imp'{int3 = 15}), 
-    ?line {ok,{'SeqDef3Imp',true,{'SeqIn',asn1_NOVALUE,12},15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef3Imp',lists:flatten(Bytes62)),
-    
-    
-    
-    
-    
-    
-    ?line {ok,Bytes71} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef1Exp',#'SeqDef1Exp'{bool1 = true,
-							      int1 = 15,
-							      seq1 = #'SeqIn'{boolIn = true,
-									      intIn = 66}}), 
-    ?line {ok,{'SeqDef1Exp',true,15,{'SeqIn',true,66}}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef1Exp',lists:flatten(Bytes71)),
-    
-    
-    ?line {ok,Bytes72} = asn1_wrapper:encode('SeqDefault','SeqDef1Exp',#'SeqDef1Exp'{int1 = 15}), 
-    ?line {ok,{'SeqDef1Exp',true,15,{'SeqIn',asn1_NOVALUE,12}}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef1Exp',lists:flatten(Bytes72)),
-    
-    
-    ?line {ok,Bytes81} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef2Exp',#'SeqDef2Exp'{bool2 = true,
-							      int2 = 15,
-							      seq2 = #'SeqIn'{boolIn = true,
-									      intIn = 66}}), 
-    ?line {ok,{'SeqDef2Exp',{'SeqIn',true,66},true,15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef2Exp',lists:flatten(Bytes81)),
-    
-    
-    ?line {ok,Bytes82} = asn1_wrapper:encode('SeqDefault','SeqDef2Exp',#'SeqDef2Exp'{int2 = 15,
-									       bool2 = true}), 
-    ?line {ok,{'SeqDef2Exp',{'SeqIn',asn1_NOVALUE,12},true,15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef2Exp',lists:flatten(Bytes82)),
-    
-    
-    
-    ?line {ok,Bytes91} = 
-	asn1_wrapper:encode('SeqDefault','SeqDef3Exp',#'SeqDef3Exp'{bool3 = true,
-							      int3 = 15,
-							      seq3 = #'SeqIn'{boolIn = true,
-									      intIn = 66}}), 
-    ?line {ok,{'SeqDef3Exp',true,{'SeqIn',true,66},15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef3Exp',lists:flatten(Bytes91)),
-    
-    
-    ?line {ok,Bytes92} = asn1_wrapper:encode('SeqDefault','SeqDef3Exp',#'SeqDef3Exp'{int3 = 15}), 
-    ?line {ok,{'SeqDef3Exp',true,{'SeqIn',asn1_NOVALUE,12},15}} = 
-	asn1_wrapper:decode('SeqDefault','SeqDef3Exp',lists:flatten(Bytes92)),
-    
-    
-    
-    
+    roundtrip('SeqDef1', #'SeqDef1'{bool1=true,int1=15,seq1=#'SeqIn'{boolIn=true,intIn=66}}),
+    roundtrip('SeqDef1',
+	      #'SeqDef1'{bool1=asn1_DEFAULT,int1=15,seq1=asn1_DEFAULT},
+	      #'SeqDef1'{bool1=true,int1=15,seq1=#'SeqIn'{}}),
+
+    roundtrip('SeqDef2', #'SeqDef2'{seq2=#'SeqIn'{boolIn=true,intIn=66},bool2=true,int2=15}),
+    roundtrip('SeqDef2',
+	      #'SeqDef2'{seq2=asn1_DEFAULT,bool2=asn1_DEFAULT,int2=15},
+	      #'SeqDef2'{seq2=#'SeqIn'{},bool2=true,int2=15}),
+
+    roundtrip('SeqDef3', #'SeqDef3'{bool3=true,seq3=#'SeqIn'{boolIn=true,intIn=66},int3=15}),
+    roundtrip('SeqDef3',
+	      #'SeqDef3'{bool3=asn1_DEFAULT,seq3=asn1_DEFAULT,int3=15},
+	      #'SeqDef3'{bool3=true,seq3=#'SeqIn'{},int3=15}),
+
+    roundtrip('SeqDef1Imp', #'SeqDef1Imp'{bool1=true,int1=15,
+              seq1=#'SeqIn'{boolIn=true,intIn=66}}),
+    roundtrip('SeqDef1Imp',
+	      #'SeqDef1Imp'{bool1=asn1_DEFAULT,int1=15,seq1=asn1_DEFAULT},
+	      #'SeqDef1Imp'{bool1=true,int1=15,seq1=#'SeqIn'{}}),
+
+    roundtrip('SeqDef2Imp', #'SeqDef2Imp'{seq2=#'SeqIn'{boolIn=true,intIn=66},
+					  bool2=true,int2=15}),
+    roundtrip('SeqDef2Imp',
+	      #'SeqDef2Imp'{seq2=asn1_DEFAULT,bool2=asn1_DEFAULT,int2=15},
+	      #'SeqDef2Imp'{seq2=#'SeqIn'{},bool2=true,int2=15}),
+
+    roundtrip('SeqDef3Imp',
+	      #'SeqDef3Imp'{bool3=true,seq3=#'SeqIn'{boolIn=true,intIn=66},int3=15}),
+    roundtrip('SeqDef3Imp',
+	      #'SeqDef3Imp'{bool3=asn1_DEFAULT,seq3=asn1_DEFAULT,int3=15},
+	      #'SeqDef3Imp'{bool3=true,seq3=#'SeqIn'{},int3=15}),
+
+    roundtrip('SeqDef1Exp',
+	      #'SeqDef1Exp'{bool1=true,int1=15,seq1=#'SeqIn'{boolIn=true,intIn=66}}),
+    roundtrip('SeqDef1Exp',
+	      #'SeqDef1Exp'{bool1=asn1_DEFAULT,int1=15,seq1=asn1_DEFAULT},
+	      #'SeqDef1Exp'{bool1=true,int1=15,seq1=#'SeqIn'{}}),
+
+    roundtrip('SeqDef2Exp', #'SeqDef2Exp'{seq2=#'SeqIn'{boolIn=true,intIn=66},
+              bool2=true,int2=15}),
+    roundtrip('SeqDef2Exp',
+	      #'SeqDef2Exp'{seq2=asn1_DEFAULT,bool2=true,int2=15},
+	      #'SeqDef2Exp'{seq2=#'SeqIn'{},bool2=true,int2=15}),
+
+    roundtrip('SeqDef3Exp',
+	      #'SeqDef3Exp'{bool3=true,seq3=#'SeqIn'{boolIn=true,intIn=66},int3=15}),
+    roundtrip('SeqDef3Exp',
+	      #'SeqDef3Exp'{bool3=asn1_DEFAULT,seq3=asn1_DEFAULT,int3=15},
+	      #'SeqDef3Exp'{bool3=true,seq3=#'SeqIn'{},int3=15}),
     ok.
+
+roundtrip(Type, Value) ->
+    roundtrip(Type, Value, Value).
+
+roundtrip(Type, Value, ExpectedValue) ->
+    asn1_test_lib:roundtrip('SeqDefault', Type, Value, ExpectedValue).