diff options
| author | Björn Gustavsson <[email protected]> | 2014-01-31 12:56:05 +0100 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2014-01-31 16:04:30 +0100 |
| commit | 3cff534f38d9600ae6e02d8dc361c6e35826ab43 (patch) | |
| tree | 37f32b43a41fc983106af7734a636bca540d39d3 /lib/asn1/test | |
| parent | 479198f91ce37547047250b0a654300aab8ed5f8 (diff) | |
| download | otp-3cff534f38d9600ae6e02d8dc361c6e35826ab43.tar.gz otp-3cff534f38d9600ae6e02d8dc361c6e35826ab43.tar.bz2 otp-3cff534f38d9600ae6e02d8dc361c6e35826ab43.zip | |
asn1ct_check: Correct error handling for illegal OCTET STRING values
The value for an OCTET STRING must be specified as either a bstring
or an hstring. Everything else (including character strings) is
illegal.
This correction also removes the offending code that caused an
unmatched return warning from dialyzer.
Diffstat (limited to 'lib/asn1/test')
| -rw-r--r-- | lib/asn1/test/error_SUITE.erl | 29 |
1 files changed, 25 insertions, 4 deletions
diff --git a/lib/asn1/test/error_SUITE.erl b/lib/asn1/test/error_SUITE.erl index 6451f81c01..930b44cea6 100644 --- a/lib/asn1/test/error_SUITE.erl +++ b/lib/asn1/test/error_SUITE.erl @@ -19,7 +19,7 @@ -module(error_SUITE). -export([suite/0,all/0,groups/0, - already_defined/1,enumerated/1,objects/1]). + already_defined/1,enumerated/1,objects/1,values/1]). -include_lib("test_server/include/test_server.hrl"). @@ -29,9 +29,11 @@ all() -> [{group,p}]. groups() -> - [{p,parallel(),[already_defined, - enumerated, - objects]}]. + [{p,parallel(), + [already_defined, + enumerated, + objects, + values]}]. parallel() -> case erlang:system_info(schedulers) > 1 of @@ -138,6 +140,25 @@ objects(Config) -> } = run(P, Config), ok. +values(Config) -> + M = 'Values', + P = {M, + <<"Values DEFINITIONS AUTOMATIC TAGS ::= BEGIN\n" + " os1 OCTET STRING ::= \"abc\"\n" + " os2 OCTET STRING ::= 42\n" + " os3 OCTET STRING ::= { 1, 3 }\n" + "END\n">>}, + {error, + [ + {structured_error,{M,2},asn1ct_check, + illegal_octet_string_value}, + {structured_error,{M,3},asn1ct_check, + illegal_octet_string_value}, + {structured_error,{M,4},asn1ct_check, + illegal_octet_string_value} + ] + } = run(P, Config), + ok. run({Mod,Spec}, Config) -> |